[Gimp-developer] [PATCH 3/4] Tile caching performance patches

2009-06-02 Thread Christopher Montgomery
Patch attached [to avoid any chance of gmail mangling lines]

Detailed patch description at:
http://web.mit.edu/xiphmont/Public/gimp-fu/gimp-cache.html

Monty


0003-Replace-two-list-flush-clean-first-cache-strategy-wi.patch
Description: Binary data
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


Re: [Gimp-developer] [PATCH 3/4] Tile caching performance patches

2009-06-02 Thread Sven Neumann
Hi,

a few more coding style despite the ones I already pointed out:

 +  if(!tile)return FALSE;

Please write this as

  if (! tile)
return FALSE;

 +  if(PENDING_WRITE(t))
 +acc+=t-size;
 +  t=t-next;

Please insert an empty line like this:

  if (PENDING_WRITE (t))
acc += t-size;

  t = t-next;


Other than these style issues, the patch looks good. In particular your
benchmarking data looks promising. Nice work!


Sven


___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer