Re: [Gimp-developer] Please bring back the old rectangle selection...
Hi, On Tue, 2006-07-25 at 23:49 +0200, Karl Günter Wünsch wrote: First of all the new one doesn't save it's options. That could be remedied but the amount of changes (I'm a C++ developer and really can't get my head around doing the way object orientation is done in the tool, the documentation for all the stuff that has to be done is lacking or isn't easy located - so I can't do it myself, I tried and failed) seem excessive as the gimprectangleoptions.c is the odd one out and uses a completely different way of storing it's properties to all the other tools - Bug #346683. Fixing this is as simple as adding the GIMP_CONFIG_PARAM_SERIALIZE flag to the registration of the interface properties. This is a simple change and it is already outlined in the bug report. Please stick to the facts, or if you don't know about the implementation details, don't make assumptions about them. If that were not bad enough, the usability is partially much worse than before. The new tools are not ready yet. We know that there are problems and it is nice that you took the time to point them out. But rest assured that we don't plan to release GIMP 2.4 with the selection tools in their current state. Sven ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Please bring back the old rectangle selection...
On Tuesday 08 August 2006 10:00, Sven Neumann wrote: Fixing this is as simple as adding the GIMP_CONFIG_PARAM_SERIALIZE flag to the registration of the interface properties. This is a simple change and it is already outlined in the bug report. Please stick to the facts, or if you don't know about the implementation details, don't make assumptions about them. And now you are making assumptions. The flag only alters the behaviour by resulting in a crash when trying to read or write the properties... This probably is the result of not using the macros every other tool uses to register it's properties. If that were not bad enough, the usability is partially much worse than before. The new tools are not ready yet. We know that there are problems and it is nice that you took the time to point them out. But rest assured that we don't plan to release GIMP 2.4 with the selection tools in their current state. And if you had read the followups on this (partially in the cited bug reports) you would have noticed that I started to work with the developers to fix the problems - part of the patches originate from me. My whole rant here was the result of the lack of feedback to those bug reports, which since has been cleared as a bad timing because of the holiday season... -- regards Karl Günter ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Please bring back the old rectangle selection...
Hi, On Tue, 2006-08-08 at 10:44 +0200, Karl Günter Wünsch wrote: I have no doubts about this but there is a problem discerning these two by just looking at the code if you are not that much into the GTK way of doing objects. There also is little documentation whatsoever on what parameters mean. The GObject documentation at http://developer.gnome.org/doc/API/2.0/gobject/ is quite extensive and should be considered a must-read if you want to understand the internals of the GIMP core. I debugged that down to the level of an object comparison (by name it seemed) which failed because one of the objects compared was NULL. If you'd like I can give it a try later (tonight after 8pm european summer time) and give some additional informations about this... It doesn't crash for me, but there are critical warnings when the interface properties are being deserialized. I will have a look at gimp_config_deserialize_property(), most probably we are making the wrong assumption here that the properties owner_type is a class. Sven ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
[Gimp-developer] Please bring back the old rectangle selection...
I have tried to like the new one. I honestly did. But there are some things that make life really hard when you have to work within certain contraints. First of all the new one doesn't save it's options. That could be remedied but the amount of changes (I'm a C++ developer and really can't get my head around doing the way object orientation is done in the tool, the documentation for all the stuff that has to be done is lacking or isn't easy located - so I can't do it myself, I tried and failed) seem excessive as the gimprectangleoptions.c is the odd one out and uses a completely different way of storing it's properties to all the other tools - Bug #346683. If that were not bad enough, the usability is partially much worse than before. Let me explain: the old rectangle selection tool didn't have the bells and wistles but it was more straight forward if you wanted to keep the aspect ratio to say 3:2 when cropping. You simply entered 3 into the x-dimension, 2 into the y dimension and ticked fixed aspect. Now you have to enter 1.5 into the aspect ratio box and tick the check box next to it. But what if you want 3:2 aspect (for a vertical compositional crop)? Now you have to enter 0. into the aspect ratio, and you already are suffering a loss of precision (it's off by a few pixels if your image is sufficiently large, because it's not 0. it's 0.666). Even worse - calculator on standby - imagine you want to have 16:9 or 9:16 aspect ratio because you want to use the image in your own DVD production. The old style was simple (took a bit getting used to but was workable), the new style of setting the aspect ratio is a pain in the proverbial... - Feature request/Usability Bug #346684. Then try to select some rectangular areas because you might want to make them partially transparent or only sharpen the remainder of the area. Now the new form of selection with the last selected area still visible is getting annoying to say the least. I cannot tell how often I find myself cursing at the new rectangle selection when selecting multiple rectangle areas to join them into a larger compound area because the last area stays visible and sometimes - I can't really pinpoint when - keeps me from selecting the next area. If I could pinpoint the culprit operation then I would file a bug. Then there are some usability issues with the way the last selected area is shown as stippled outline when you start resizing the area, there seems to be a random element to when the selection is supposed to be finished and what is supposed to be visualized - Bug #347945. My humble (well after this rant) request would be to resurrect the old rectangle selection tool and have the new one reworked so that the next milestone doesn't have to be postponed because of this (for me the first one is a true blocker, the other ones are very annoying to say the least). regards Karl Günter Wünsch ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
