Re: [Gimp-developer] Recent Gegl-0.1.7 build fails
You are absolutely right. fsync was a problem while compiling. I fixed that by passing -Dfsync=_commit See for example: http://lists-archives.org/mingw-users/10348-mingw-now-works-sorta.html Thanks, Partha On Mon, Jun 6, 2011 at 3:26 AM, Michael Schumacher wrote: >> > On Sat, Jun 4, 2011 at 12:14 PM, Partha Bagchi >> wrote: >> >> I tried again. The error still persists: >> >> >> >> gegl-buffer-save.c: In function 'gegl_buffer_save': >> >> gegl-buffer-save.c:227: error: 'S_IRGRP' undeclared (first use in > > [...] > >> Von: Partha Bagchi > >> OK. I create a patch using diff. Would that be sufficient? I attached >> it to this mail. Hope it comes through. > > The S_*GRP and S_*OTH flags aren't defined on the Windows platform, and to my > knowledge the bits associated to them don't have any meaning there anyway. > I've committed a change to GEGL to fix this (a #ifdef check to change the > open command to not use them on the Windows platform). > > The next problem that you'll most likely encounter is the undefined fsync in > gegl/buffer - in my local tree, I've added a AC_CHECK_FUNS(fsync) directive > to my configure.ac and wrapped the fsync calls in #if HAVE_FSYNC. > > I guess that fsync could be redefined to FlushFileBuffers (see > http://www.humboldt.co.uk/2009/03/fsync-across-platforms.html) on the Windows > platform unless a fsync implementation is found by the check. > > > Regards, > Michael > -- > Empfehlen Sie GMX DSL Ihren Freunden und Bekannten und wir > belohnen Sie mit bis zu 50,- Euro! https://freundschaftswerbung.gmx.de > ___ > Gimp-developer mailing list > Gimp-developer@lists.XCF.Berkeley.EDU > https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer > ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Recent Gegl-0.1.7 build fails
> > On Sat, Jun 4, 2011 at 12:14 PM, Partha Bagchi > wrote: > >> I tried again. The error still persists: > >> > >> gegl-buffer-save.c: In function 'gegl_buffer_save': > >> gegl-buffer-save.c:227: error: 'S_IRGRP' undeclared (first use in [...] > Von: Partha Bagchi > OK. I create a patch using diff. Would that be sufficient? I attached > it to this mail. Hope it comes through. The S_*GRP and S_*OTH flags aren't defined on the Windows platform, and to my knowledge the bits associated to them don't have any meaning there anyway. I've committed a change to GEGL to fix this (a #ifdef check to change the open command to not use them on the Windows platform). The next problem that you'll most likely encounter is the undefined fsync in gegl/buffer - in my local tree, I've added a AC_CHECK_FUNS(fsync) directive to my configure.ac and wrapped the fsync calls in #if HAVE_FSYNC. I guess that fsync could be redefined to FlushFileBuffers (see http://www.humboldt.co.uk/2009/03/fsync-across-platforms.html) on the Windows platform unless a fsync implementation is found by the check. Regards, Michael -- Empfehlen Sie GMX DSL Ihren Freunden und Bekannten und wir belohnen Sie mit bis zu 50,- Euro! https://freundschaftswerbung.gmx.de ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Recent Gegl-0.1.7 build fails
OK. I create a patch using diff. Would that be sufficient? I attached it to this mail. Hope it comes through. Thanks for all your help. Partha On Sat, Jun 4, 2011 at 1:55 PM, Øyvind Kolås wrote: > On Sat, Jun 4, 2011 at 12:14 PM, Partha Bagchi wrote: >> I tried again. The error still persists: >> >> gegl-buffer-save.c: In function 'gegl_buffer_save': >> gegl-buffer-save.c:227: error: 'S_IRGRP' undeclared (first use in this >> function) >> gegl-buffer-save.c:227: error: (Each undeclared identifier is reported only >> once >> gegl-buffer-save.c:227: error: for each function it appears in.) >> gegl-buffer-save.c:227: error: 'S_IWGRP' undeclared (first use in this >> function) >> gegl-buffer-save.c:227: error: 'S_IROTH' undeclared (first use in this >> function) >> gegl-buffer-save.c:227: error: 'S_IWOTH' undeclared (first use in this >> function) >> make[4]: *** [gegl-buffer-save.lo] Error 1 > > That is the same error, but elsewhere, if you provide git formatted > patches fixing such issues I will integrate them with GEGL. > > /Øyvind K. > > -- > «The future is already here. It's just not very evenly distributed» > -- William Gibson > http://pippin.gimp.org/ http://ffii.org/ > gegl-buffer-save.patch Description: Binary data ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Recent Gegl-0.1.7 build fails
On Sat, Jun 4, 2011 at 12:14 PM, Partha Bagchi wrote: > I tried again. The error still persists: > > gegl-buffer-save.c: In function 'gegl_buffer_save': > gegl-buffer-save.c:227: error: 'S_IRGRP' undeclared (first use in this > function) > gegl-buffer-save.c:227: error: (Each undeclared identifier is reported only > once > gegl-buffer-save.c:227: error: for each function it appears in.) > gegl-buffer-save.c:227: error: 'S_IWGRP' undeclared (first use in this > function) > gegl-buffer-save.c:227: error: 'S_IROTH' undeclared (first use in this > function) > gegl-buffer-save.c:227: error: 'S_IWOTH' undeclared (first use in this > function) > make[4]: *** [gegl-buffer-save.lo] Error 1 That is the same error, but elsewhere, if you provide git formatted patches fixing such issues I will integrate them with GEGL. /Øyvind K. -- «The future is already here. It's just not very evenly distributed» -- William Gibson http://pippin.gimp.org/ http://ffii.org/ ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Recent Gegl-0.1.7 build fails
I tried again. The error still persists: gegl-buffer-save.c: In function 'gegl_buffer_save': gegl-buffer-save.c:227: error: 'S_IRGRP' undeclared (first use in this function) gegl-buffer-save.c:227: error: (Each undeclared identifier is reported only once gegl-buffer-save.c:227: error: for each function it appears in.) gegl-buffer-save.c:227: error: 'S_IWGRP' undeclared (first use in this function) gegl-buffer-save.c:227: error: 'S_IROTH' undeclared (first use in this function) gegl-buffer-save.c:227: error: 'S_IWOTH' undeclared (first use in this function) make[4]: *** [gegl-buffer-save.lo] Error 1 On Sat, May 28, 2011 at 8:58 AM, Partha Bagchi wrote: > Sorry, forgot to send to the list. > > > -- Forwarded message -- > From: Partha Bagchi > Date: Sat, May 28, 2011 at 8:57 AM > Subject: Re: [Gimp-developer] Recent Gegl-0.1.7 build fails > To: Øyvind Kolås > > > On Sat, May 28, 2011 at 8:39 AM, Øyvind Kolås wrote: >>> Platform/Distribution HP Pavilion dv8t Intel Core i7/ Windows 7, 64bit >>> $ gcc -v >>> Using built-in specs. >>> Target: x86_64-w64-mingw32 >>> Configured with: ../gcc44-svn/configure --host=x86_64-w64-mingw32 >>> --target=x86_64-w64-mingw32 --disable-multilib --enable-checking=r >>> elease --prefix=/mingw64 --with-sysroot=/mingw64 >>> --enable-languages=c,c++,fortran,objc,obj-c++ --enable-libgomp >>> --with-gmp=/mingw64 >>> >>> --with-mpfr=/mingw64 --disable-nls --disable-win32-registry >>> Thread model: win32 >>> gcc version 4.4.5 20101001 (release) [svn/rev.164871 - mingw-w64/oz] (GCC) >>> >>> Note that this error did not happen a couple of weeks ago. >> >> The error might be fixed in git master now, you can either do a git >> checkout; or wait for new nightly tarballs to appear. I hope this >> fixes it. >> >> /Øyvind K. >> -- >> «The future is already here. It's just not very evenly distributed» >> -- William Gibson >> http://pippin.gimp.org/ http://ffii.org/ >> > > Thanks!! I did a temporary fix by doing the following: > > copied gegl-buffer-save.c & gegl-tile-backend.c from a previous git > source and built GEGL by passing -DHAVE_GIO since I noticed that, that > was removed from the current source. > > Moreover, (while I have your attention, :)) I noticed that > gdk-pixbuf-2.0 is no longer automatically configured. So, I had to > pass that in my command line as GDK_PIXBUF_CFLAGS="`pkg-config > --cflags gdk-pixbuf-2.0`" GDK_PIXBUF_LIBS="`pkg-config --libs > gdk-pixbuf-2.0`" > > Thanks again, > Partha > ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Recent Gegl-0.1.7 build fails
> Platform/Distribution HP Pavilion dv8t Intel Core i7/ Windows 7, 64bit > $ gcc -v > Using built-in specs. > Target: x86_64-w64-mingw32 > Configured with: ../gcc44-svn/configure --host=x86_64-w64-mingw32 > --target=x86_64-w64-mingw32 --disable-multilib --enable-checking=r > elease --prefix=/mingw64 --with-sysroot=/mingw64 > --enable-languages=c,c++,fortran,objc,obj-c++ --enable-libgomp > --with-gmp=/mingw64 > > --with-mpfr=/mingw64 --disable-nls --disable-win32-registry > Thread model: win32 > gcc version 4.4.5 20101001 (release) [svn/rev.164871 - mingw-w64/oz] (GCC) > > Note that this error did not happen a couple of weeks ago. The error might be fixed in git master now, you can either do a git checkout; or wait for new nightly tarballs to appear. I hope this fixes it. /Øyvind K. -- «The future is already here. It's just not very evenly distributed» -- William Gibson http://pippin.gimp.org/ http://ffii.org/ ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Recent Gegl-0.1.7 build fails
On Wed, May 25, 2011 at 7:07 AM, Øyvind Kolås wrote: > On Wed, May 25, 2011 at 9:38 AM, Partha Bagchi wrote: >> Thought I would mention it here. When building GEGL (downloaded from >> ftp://gimptest.flamingtext.com/pub/nightly-tarballs/ at 5:35 EST), I >> am getting the following error: >> >> gegl-buffer-save.c: In function 'gegl_buffer_save': >> gegl-buffer-save.c:227: error: 'S_IRGRP' undeclared (first use in this >> function) >> gegl-buffer-save.c:227: error: (Each undeclared identifier is reported only >> once >> gegl-buffer-save.c:227: error: for each function it appears in.) >> gegl-buffer-save.c:227: error: 'S_IWGRP' undeclared (first use in this >> function) >> gegl-buffer-save.c:227: error: 'S_IROTH' undeclared (first use in this >> function) >> gegl-buffer-save.c:227: error: 'S_IWOTH' undeclared (first use in this >> function) >> make[3]: *** [gegl-buffer-save.lo] Error 1 >> >> I noticed that this bit of code has changed from a previous tarball >> that I downloaded before. > > On what platform/distribution/compiler do you get this? (these > constants can be replaced by a numeric constant though; but it would > still be good to know where this does not work.) > > /Øyvind K. > -- > «The future is already here. It's just not very evenly distributed» > -- William Gibson > http://pippin.gimp.org/ http://ffii.org/ > Sorry about that. I should have mentioned it: Platform/Distribution HP Pavilion dv8t Intel Core i7/ Windows 7, 64bit $ gcc -v Using built-in specs. Target: x86_64-w64-mingw32 Configured with: ../gcc44-svn/configure --host=x86_64-w64-mingw32 --target=x86_64-w64-mingw32 --disable-multilib --enable-checking=r elease --prefix=/mingw64 --with-sysroot=/mingw64 --enable-languages=c,c++,fortran,objc,obj-c++ --enable-libgomp --with-gmp=/mingw64 --with-mpfr=/mingw64 --disable-nls --disable-win32-registry Thread model: win32 gcc version 4.4.5 20101001 (release) [svn/rev.164871 - mingw-w64/oz] (GCC) Note that this error did not happen a couple of weeks ago. Thanks in advance, Partha ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] Recent Gegl-0.1.7 build fails
On Wed, May 25, 2011 at 9:38 AM, Partha Bagchi wrote: > Thought I would mention it here. When building GEGL (downloaded from > ftp://gimptest.flamingtext.com/pub/nightly-tarballs/ at 5:35 EST), I > am getting the following error: > > gegl-buffer-save.c: In function 'gegl_buffer_save': > gegl-buffer-save.c:227: error: 'S_IRGRP' undeclared (first use in this > function) > gegl-buffer-save.c:227: error: (Each undeclared identifier is reported only > once > gegl-buffer-save.c:227: error: for each function it appears in.) > gegl-buffer-save.c:227: error: 'S_IWGRP' undeclared (first use in this > function) > gegl-buffer-save.c:227: error: 'S_IROTH' undeclared (first use in this > function) > gegl-buffer-save.c:227: error: 'S_IWOTH' undeclared (first use in this > function) > make[3]: *** [gegl-buffer-save.lo] Error 1 > > I noticed that this bit of code has changed from a previous tarball > that I downloaded before. On what platform/distribution/compiler do you get this? (these constants can be replaced by a numeric constant though; but it would still be good to know where this does not work.) /Øyvind K. -- «The future is already here. It's just not very evenly distributed» -- William Gibson http://pippin.gimp.org/ http://ffii.org/ ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
[Gimp-developer] Recent Gegl-0.1.7 build fails
Hi all, Thought I would mention it here. When building GEGL (downloaded from ftp://gimptest.flamingtext.com/pub/nightly-tarballs/ at 5:35 EST), I am getting the following error: gegl-buffer-save.c: In function 'gegl_buffer_save': gegl-buffer-save.c:227: error: 'S_IRGRP' undeclared (first use in this function) gegl-buffer-save.c:227: error: (Each undeclared identifier is reported only once gegl-buffer-save.c:227: error: for each function it appears in.) gegl-buffer-save.c:227: error: 'S_IWGRP' undeclared (first use in this function) gegl-buffer-save.c:227: error: 'S_IROTH' undeclared (first use in this function) gegl-buffer-save.c:227: error: 'S_IWOTH' undeclared (first use in this function) make[3]: *** [gegl-buffer-save.lo] Error 1 I noticed that this bit of code has changed from a previous tarball that I downloaded before. Thanks, Partha ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
