Re: [Gimp-developer] healing brush hanging X11

2006-09-13 Thread Kevin Sookocheff
Hi Sven,

I haven't had any time to try this. I depart this Saturday and don't anticipate having more time to devote to the healing brush in the near future. Once I get settled I'll set up a work environment and try and work on the code some more.


Kevin
On 9/13/06, Sven Neumann [EMAIL PROTECTED] wrote:
Hi Kevin,a while ago we discussed how to change the heal tool so that it doesn'tdo it's time-expensive calculations while the user is painting but to
delay it until after the mouse has been released. Have you tried tochange the code in this direction? Do you need more help with this?Sven
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


Re: [Gimp-developer] healing brush hanging X11

2006-09-05 Thread Sven Neumann
Hi Kevin,

On Tue, 2006-09-05 at 09:15 -0400, Kevin Sookocheff wrote:

 OK.  That seems logical.  So during the mouse stroke a region is
 selected, and after the mouse stroke healing is done on the selected
 region.  Are there any tools in GIMP right now that follow a similar
 sequence?  The problem I have is that I'm not sure how to implement
 this, I just don't know enough GIMP yet :)

I don't think there's a tool that does something similar. But then, it
shouldn't be that hard. The heal tool would simply do what the clone
tool is doing on motion. Or actually, it should share the code, either
by delegation or perhaps we would derive GimpHeal from GimpClone.

As far as I can see, there is currently no way to override
gimp_paint_core_finish(). That's probably where the heal tool would have
to do its magic. So we would have to make this a virtual method of the
GimpPaintCore class so the GimpHeal could override it.

Mitch knows this code a lot better, he should be able to help you with
this.


Sven



___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


[Gimp-developer] healing brush hanging X11

2006-09-04 Thread Campbell Barton

Hey,
Just tried the healing brush for the first time, on an 8mp image with a 
200px brush.

- Useually works ok for most tools.

With the healing brush it was very slow, thats ok too- I assume theres a 
lot of math to go for this tool


But after a click+drag it was so slow, it would not finish after about 
2min... even worse, I could not move any windows or click anywhere while 
it was thinking.


Only quick way out  was to kill X11 with a ctrl+alt+backspace. (or boot 
up another PC and kill the gimp via SSH)


it looks like this is more of a problem with the way gimp locks X11 then 
the healing tool its self.


- Cam
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer


Re: [Gimp-developer] healing brush hanging X11

2006-09-04 Thread Sven Neumann
Hi,

On Mon, 2006-09-04 at 20:45 -0400, Kevin Sookocheff wrote:

 A bad point about the current implementation is that it is slow.  The
 Laplacian solver is not optimized.  There are also other ways to
 implement the Laplacian solver that may increase the speed.  

As far as I know, the Heal tool in Photoshop solves this problem by only
going through the math after you release the mouse button. While you are
painting, the tool works just like the clone tool and just copies from
the source location. Only after you release the mouse button the healing
magic is performed.

I think that this would a good solution to our problem. It's
unacceptable for GIMP to get stuck in a long-time calculation while the
mouse is grabbed. And there's no way to not grab the mouse while the
user is painting.


Sven



___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer