Re: [Gimp-developer] [Gsoc 2011] Unified transformation tool
Hi Austin, This sounds pretty neat. I believe that since gimp still has certain tools in which one can undo the individual steps of that tool till one changes the tool, so I believe that there would already be a good enough infra tour for this. Still any ideas who might be a good person to discuss my ideas regarding the ui. The specification for the unified transform tool seem to be added on wiki by guiguru, any idea if he is on the mailing list. Regards, Mohit On Monday, March 28, 2011, Austin Donnelly -- yahoo austin_donne...@yahoo.co.uk wrote: I did the last major changes to the undo system, to support the Undo History dialog. When I last looked, there was only a single stack of undo actions. Some of those actions are special start undo group and end undo group markers: think of them as brackets ( ) around the individual operations. If you have an undo stack: A B (C D) E older - newer Then when you undo the ) operation, it undoes D, then C, then hits ( so it pops that an stops. It would be fairly straightforwards to modify the logic to handle the case when you don't have a closed undo group: A B (C D In fact, the code might already do this. The main problem is that there is no user-accessible way to start a group without also closing it. Mostly, groups are used for running plugins or other composite commands. Good luck! Austin -Original Message- From: gimp-developer-boun...@lists.xcf.berkeley.edu [mailto:gimp-developer-boun...@lists.xcf.berkeley.edu] On Behalf Of David Gowers (kampu) Sent: 27 March 2011 08:31 To: Mohit _ Cc: gimp-developer@lists.xcf.berkeley.edu Subject: Re: [Gimp-developer] [Gsoc 2011] Unified transformation tool On Sun, Mar 27, 2011 at 3:42 PM, Mohit _ mtan.n...@gmail.com wrote: David, Thanks for the reply, but in the case of undo group, are the sub components of that group still saved individually in some sort of stack or are there different stacks for the group, and one general stack for all the groups. Also, it would be great if you could point me to the code where it is happening. I have no idea about how the implementation works internally :) ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] [Gsoc 2011] Unified transformation tool
Hello, On Sat, Mar 26, 2011 at 8:20 PM, Mohit _ mtan.n...@gmail.com wrote: Hi, In the undo section it is mentioned that until the final pixel recalculation is done user should be able to undo every single step, though after that user should be able to undo the aggregate transformation only. Does this means that we would have to maintain another action stack just for unified transformation tool, or does gimp currently also maintains two different stacks, one for the current tool and one global stack for actions. If this is the case some reference to where it happens in code would be great. Although I'm nobody official, I believe that this would happen through the undo-group mechanism. That is, when the latest group of undos was not 'closed', we should undo within the group, and once it is 'closed', we should undo the group as a unit (undoing an undo group as a unit is what currently happens in general) ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] [Gsoc 2011] Unified transformation tool
David, Thanks for the reply, but in the case of undo group, are the sub components of that group still saved individually in some sort of stack or are there different stacks for the group, and one general stack for all the groups. Also, it would be great if you could point me to the code where it is happening. On Sun, Mar 27, 2011 at 4:14 AM, David Gowers (kampu) 00a...@gmail.comwrote: Hello, On Sat, Mar 26, 2011 at 8:20 PM, Mohit _ mtan.n...@gmail.com wrote: Hi, In the undo section it is mentioned that until the final pixel recalculation is done user should be able to undo every single step, though after that user should be able to undo the aggregate transformation only. Does this means that we would have to maintain another action stack just for unified transformation tool, or does gimp currently also maintains two different stacks, one for the current tool and one global stack for actions. If this is the case some reference to where it happens in code would be great. Although I'm nobody official, I believe that this would happen through the undo-group mechanism. That is, when the latest group of undos was not 'closed', we should undo within the group, and once it is 'closed', we should undo the group as a unit (undoing an undo group as a unit is what currently happens in general) ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
