Re: [Gimp-developer] [PATCH] Use Glade + GtkBuilder for file-png.c save_dialog()

2010-01-13 Thread Nils Philippsen
I have some experience with using glade/libglade to program UIs (gtk builder should be the same or better), so I wanted to chime in even if I'm a few days late on it. On Sat, 2010-01-09 at 11:21 +0100, peter sikking wrote: [...] however, let it be really clear that I will _not_ entertain the

Re: [Gimp-developer] [PATCH] Use Glade + GtkBuilder for file-png.c save_dialog()

2010-01-09 Thread peter sikking
Martin wrote: Right now GIMP has virtuall all of the UI imperatively constructed with code. This has a few problems: * Tweaking the UI requires re-building the app * A lot of code duplication * Not very modern The patch I am replying to ports the PNG save dialog to Glade and uses

Re: [Gimp-developer] [PATCH] Use Glade + GtkBuilder for file-png.c save_dialog()

2010-01-08 Thread Martin Nordholts
The conclusion was to go ahead so I will commit the patch soon after changing glade to ui as per Sven's comment. In response to Akira's comment on performance: We need to be aware of that we are introducing extra disk IO which can give us problems, especialy during startup if we have to load a

Re: [Gimp-developer] [PATCH] Use Glade + GtkBuilder for file-png.c save_dialog()

2010-01-08 Thread Aurimas Juška
Hi, On Fri, Jan 8, 2010 at 4:30 PM, Martin Nordholts ense...@gmail.com wrote: We need to be aware of that we are introducing extra disk IO which can give us problems, especialy during startup if we have to load a lot of files. In practice I don't think this will be a problem for a long time

Re: [Gimp-developer] [PATCH] Use Glade + GtkBuilder for file-png.c save_dialog()

2010-01-08 Thread Alexia Death
On Friday 08 January 2010 17:08:58 Martin Nordholts wrote: Aurimas Juška wrote: Why not to convert XML's to C code when compiling distribution ? XML's are large and not very fast to parse. This approach would have all the benefits of XML's while developing and would not cause additional

Re: [Gimp-developer] [PATCH] Use Glade + GtkBuilder for file-png.c save_dialog()

2010-01-08 Thread Liam R E Quin
On Fri, 2010-01-08 at 17:05 +0200, Aurimas Juška wrote: [...] Why not to convert XML's to C code when compiling distribution ? XML's are large and not very fast to parse. Large - that's subjective. XML is not a compact format, though. Not very fast - 50 MBytes per second isn't unreasonable

Re: [Gimp-developer] [PATCH] Use Glade + GtkBuilder for file-png.c save_dialog()

2010-01-08 Thread Sven Neumann
On Fri, 2010-01-08 at 17:05 +0200, Aurimas Juška wrote: Hi, On Fri, Jan 8, 2010 at 4:30 PM, Martin Nordholts ense...@gmail.com wrote: We need to be aware of that we are introducing extra disk IO which can give us problems, especialy during startup if we have to load

Re: [Gimp-developer] [PATCH] Use Glade + GtkBuilder for file-png.c save_dialog()

2010-01-07 Thread Martin Nordholts
Hi, Right now GIMP has virtuall all of the UI imperatively constructed with code. This has a few problems: * Tweaking the UI requires re-building the app * A lot of code duplication * Not very modern The patch I am replying to ports the PNG save dialog to Glade and uses GtkBuilder to

Re: [Gimp-developer] [PATCH] Use Glade + GtkBuilder for file-png.c save_dialog()

2010-01-07 Thread SHIRAKAWA Akira
On 2010-01-07 16:45, Martin Nordholts wrote: [...] The patch I am replying to ports the PNG save dialog to Glade and uses GtkBuilder to construct the UI. The purpose of this change is to introduce declarative construction of UIs in GIMP to give us experience in this area. The benefits of using

Re: [Gimp-developer] [PATCH] Use Glade + GtkBuilder for file-png.c save_dialog()

2010-01-07 Thread Stephen Griffiths
Ideally, would this be limited to dialog windows or, instead, the entire user interface? PiTiVi uses GtkBuilder to do this everywhere, and then uses python after that. Point being that the heavy lifting is still done by GTK+ and GStreamer. GIMP is a significantly larger program, but I don't

Re: [Gimp-developer] [PATCH] Use Glade + GtkBuilder for file-png.c save_dialog()

2010-01-07 Thread Torsten Neuer
Am Donnerstag, 7. Januar 2010 16:45:06 schrieb Martin Nordholts: Right now GIMP has virtuall all of the UI imperatively constructed with code. This has a few problems: [...] The patch I am replying to ports the PNG save dialog to Glade and uses GtkBuilder to construct the UI. The purpose of

Re: [Gimp-developer] [PATCH] Use Glade + GtkBuilder for file-png.c save_dialog()

2010-01-07 Thread Sven Neumann
On Thu, 2010-01-07 at 16:45 +0100, Martin Nordholts wrote: * We use GtkBuilder, not the deprecated libglade Why are the files still installed in a folder called glade then and use the file extension .glade? Since we have the chance to do this right from the beginning, that should probably be