Re: [Gimp-developer] [PATCH 1/4] Tile caching performance patches

2009-06-03 Thread Sven Neumann
Hi, On Wed, 2009-06-03 at 11:41 +0930, David Gowers wrote: I'd like to mention also that there are also some minor problems with whitespace Right. I suggest to add the following lines to your .emacs file: (setq c-mode-common-hook '(lambda () (setq indent-tabs-mode nil)

Re: [Gimp-developer] [PATCH 1/4] Tile caching performance patches

2009-06-03 Thread Sven Neumann
Hi, On Tue, 2009-06-02 at 22:15 -0400, Christopher Montgomery wrote: For about a month I'd turned on emacs's trailing whitespace autotrim and it was a cure worse than the disease. How shall I kill my own whitespace without generating patches 4x larger than necessary due to others' trailing

Re: [Gimp-developer] [PATCH 1/4] Tile caching performance patches

2009-06-03 Thread Christopher Montgomery
On Wed, Jun 3, 2009 at 3:12 AM, Sven Neumann s...@gimp.org wrote: There should not be any trailing whitespace in the GIMP source code. We have several times trimmed away all trailing whitespace and committed these cleanups. If new trailing whitespace sneaked in, then we should probably do

Re: [Gimp-developer] [PATCH 1/4] Tile caching performance patches

2009-06-02 Thread Sven Neumann
Hi, first of all thanks a lot for providing these patches. I definitely want to get them merged as soon as possible. But there are a few minor issues that should be discussed first. So let me start by commenting on your first patch: On Tue, 2009-06-02 at 04:11 -0400, Christopher Montgomery

Re: [Gimp-developer] [PATCH 1/4] Tile caching performance patches

2009-06-02 Thread Christopher Montgomery
On Tue, Jun 2, 2009 at 4:46 PM, Sven Neumann s...@gimp.org wrote: Hi, first of all thanks a lot for providing these patches. I definitely want to get them merged as soon as possible. But there are a few minor issues that should be discussed first. So let me start by commenting on your first

Re: [Gimp-developer] [PATCH 1/4] Tile caching performance patches

2009-06-02 Thread Sven Neumann
Hi, On Tue, 2009-06-02 at 16:56 -0400, Christopher Montgomery wrote: As far as I know pretty much any compiler out there should be able to replace a modulo by a power-of-2 constant by the bit-wise AND operation without us explicitly doing so (see also

Re: [Gimp-developer] [PATCH 1/4] Tile caching performance patches

2009-06-02 Thread David Gowers
I'd like to mention also that there are also some minor problems with whitespace i...@gbubuntu:~/st/gimp2/gimp$ git-am /tmp/0002*.patch Applying Add additional profiling to tile usage in order to analyze efficiency and behavior of the tile cache. Profiling includes run-time indication of idle

Re: [Gimp-developer] [PATCH 1/4] Tile caching performance patches

2009-06-02 Thread Christopher Montgomery
For about a month I'd turned on emacs's trailing whitespace autotrim and it was a cure worse than the disease. How shall I kill my own whitespace without generating patches 4x larger than necessary due to others' trailing whitespace? Monty ___

Re: [Gimp-developer] [PATCH 1/4] Tile caching performance patches

2009-06-02 Thread Christopher Montgomery
On Tue, Jun 2, 2009 at 10:15 PM, Christopher Montgomery xiphm...@gmail.com wrote: For about a month I'd turned on emacs's trailing whitespace autotrim and it was a cure worse than the disease.  How shall I kill my own whitespace without generating patches 4x larger than necessary due to

Re: [Gimp-developer] [PATCH 1/4] Tile caching performance patches

2009-06-02 Thread Christopher Montgomery
In fact, with -O2, gcc is generating more complex assembly for % than , though not an integer division. Assembly generated for version using : tile_data_pointer: .LFB29: movzwl 8(%rdi), %eax andl$63, %edx andl$63, %esi imull %eax, %edx movzbl

Re: [Gimp-developer] [PATCH 1/4] Tile caching performance patches

2009-06-02 Thread Martin Nordholts
Christopher Montgomery wrote: For about a month I'd turned on emacs's trailing whitespace autotrim and it was a cure worse than the disease. How shall I kill my own whitespace without generating patches 4x larger than necessary due to others' trailing whitespace? Caring too much about