Re: [Gimp-developer] GSoC GimpUnitEntry: Review round 2
Hi Martin I implemented your suggestion to follow the GtkSpinButton pattern: The UnitAdjustment now is to be created manually by the client and then set via gimp_unit_entry_set_adjustment(). I removed the majority of functions in GimpUnitEntry which mirrored GimpUnitAdjustment. Only set/get_pixels and set/get_bounds is remaining. I also added gimp_unit_entries_get_adjustment() in addition to gimp_unit_entries_get_entry() so that clients can access the adjustment easily. Have a look at the new API and tell me what you think (especially what part of GimpUnitAdjustment we still should mirror in GimpUnitEntry for convenience). I think I like it better now ;) But I made it a separate commit so we could rewind painlessly... Best regards Enrico Am 30.07.2011 um 13:30 schrieb Martin Nordholts: Hi Here are my review comments from a rather detailed review round. I've looked carefully at the GimpUnitAdjustment and GimpUnitEntry APIs, as I believe we can get the API in a state good enough for inclusion in the GIMP 2.10 plug-in API (that will also survive into GIMP 3.0). GimpUnitEntries should still be kept around, but not as part of a backwards compatible public API, only as a private convenience for us. Same goes for your new gimp_prop_*()-functions and GimpUnitParser. I did't look very closely at the GimpUnitEntries implementation or API this time. I didn't look very close at GimpUnitParser either since it's a small internal helper which is always nice. The diff with comments can be found here: http://files.chromecode.com/gimp/gimp-soc-2011-gimpunitentry-review-2011-07-17.txt Your focus now should be on fixing the review comments (and coding style and documentation) rather than continuing to port GIMP app to use GimpUnitEntry as there is not much time left in the project. Keep up the good job :) / Martin -- My GIMP Blog: http://www.chromecode.com/ GIMP 2.8 schedule on tasktaste.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] GSoC GimpUnitEntry: Review round 2
2011/8/1 Enrico Schröder enni.schroe...@gmail.com: Hey Martin, just a small status update: starting on documentation and fixing your review comments now. (Have been busy with moving to my new apartment last week). By going through your review comments I noticed that your diff file incorporates some old code (e.g. all that gimp_prop_coordinates_*2 stuff) which I already removed. Have you used an old revision? BTW: Of course I will continue working on GimpUnitEntries and maybe other parts of Gimp after GSOC, but since there is roughly a month left of official project time, what do you think needs to be done for my project to be rated successful? Anything major except documentation and fixing your review comments? How about porting (which is ~75% done I guess), does that need to be complete until end of august? Best regards, Enrico Hi (Keeping gimp-developer on CC) I had trouble finding time to do the review, so the snapshot I was reviewing is quite old by now, but hopefully most comments still apply. It would be great you could keep contributing also after GSoC. Regarding being rated successful, just do your best addressing the review comments. Your project basically already is successful :) Porting all GIMP to use the new widget is not as important as having the GimpUnitEntry widget itself fully completed, tested and documented, so focus on the latter. BR, Martin -- My GIMP Blog: http://www.chromecode.com/ GIMP 2.8 schedule on tasktaste.com ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
