Re: [Gimp-developer] Scope of variables

2009-11-18 Thread Sven Neumann
On Wed, 2009-11-18 at 00:23 -0200, Nelson A. de Oliveira wrote: > --- app/core/gimpimage-convert.c.old 2009-11-18 00:18:55.0 -0200 > +++ app/core/gimpimage-convert.c 2009-11-18 00:19:34.0 -0200 > @@ -835,8 +835,6 @@ >/* Convert to indexed? Build histogram if necessary.

Re: [Gimp-developer] Scope of variables

2009-11-17 Thread Martin Nordholts
Nelson A. de Oliveira wrote: > Hi! > > Is it interesting to limit the scope of the variables to where they > are only used? Hi! Yes, but this is the kind of changes you'd do when you have commit access. It would be too much work to review a big inflow of these kinds of patches. Regards, Marti

Re: [Gimp-developer] Scope of variables

2009-11-17 Thread Nelson A. de Oliveira
Hi again! On Wed, Nov 18, 2009 at 12:23 AM, Nelson A. de Oliveira wrote: > For example, i is not used inside only one if here in > app/core/gimpimage-convert.c (and thus has been moved to where it's > only necessary): I need to sleep. Read it as: "For example, i is used inside only one if here i