Re: [Gimp-developer] gimp 1.3.18 - Pink backgrounds on GIF's

2003-08-14 Thread Adam D. Moss
Adam D. Moss wrote:
Okay, in that case I think I must have made a mistake in
the forward-port of the 1.2.x fix to 1.3.x, because I can't
reproduce this in my 1.2.x tree with the equivilent GIF plugin
4.01.00 fix in it.
I'll try to spot what the forward-port does differently.
I can't see anything wrong with the forward-port, and still
can't reproduce this with the same mod on the 1.2.x branch.
Now I can't afford any more time to look into this in the
near future.
Maybe someone who can reproduce this in 1.3.18 can come
up with some ideas.
Here's the unpublished 1.2.x gif-save plugin with the same fix
that went into 1.3.17 (which I'm ASSUMING is the fix that is at
the root of this problem), for comparison:
http://icculus.org/~aspirin/gif.c
--Adam
--
Adam D. Moss   . ,,^^   [EMAIL PROTECTED]   http://www.foxbox.org/   co:3
I am NOT a nut!  I am the keeper of the seven universal truths!
___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] gimp 1.3.18 - Pink backgrounds on GIF's

2003-08-14 Thread Adam D. Moss
Steven P. Ulrick wrote:
How do I reproduce the problem -- would I be right in thinking
that if I load the GIF above, then re-save it again and re-load
the result then the resulting GIF will have a pink background?
I answered this question in my response above, but to reiterate, the
answer is yes, if you resave the image in Gimp 1.3.18 and reload it in
any version of the Gimp, GQview, ImageMagick, whatever, it now has a
pink background.
Okay, in that case I think I must have made a mistake in
the forward-port of the 1.2.x fix to 1.3.x, because I can't
reproduce this in my 1.2.x tree with the equivilent GIF plugin
4.01.00 fix in it.
I'll try to spot what the forward-port does differently.

--Adam
--
Adam D. Moss   . ,,^^   [EMAIL PROTECTED]   http://www.foxbox.org/   co:3
I am NOT a nut!  I am the keeper of the seven universal truths!
___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] gimp 1.3.18 - Pink backgrounds on GIF's

2003-08-14 Thread Tom Mraz
It is probably this checkin:
http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=contextwhitespace_mode=showfile=gifload.cbranch=root=/cvs/gnomesubdir=/gimp/plug-ins/commoncommand=DIFF_FRAMESETrev1=1.30rev2=1.31
The guchar - gchar change without correcting the code using the buf 
isn't probably good idea?

Tom

___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] gimp 1.3.18 - Pink backgrounds on GIF's

2003-08-14 Thread Adam D. Moss
Jeff Trefftzs wrote:
On Mon, 2003-08-11 at 08:49, Adam D. Moss wrote:

Hi.

Jeff Trefftzs wrote:

Without getting fancy, I just tried this image in gimp-1.3.18 (Linux,
RedHat 9).  It opened with the pink background
Wait, it OPENED with the pink background?  You didn't have
to save it out again first?


Yes indeedy!

I downloaded the GIF from the URL you provided.
(n.b. I didn't provide a URL, I didn't report the bug)

  When I opened it in
gimp-1.3.17 (yes, 17, not 18, my bad) it showed the pink bg.  Both in
preview and when I opened it.  This duplicates the reported behavior,
btw.
Okay, that's a pretty vital difference (and the reason I asked
for clarification from the original reporter about whether it
requires a save-then-reload, which he said it did in
contradiction to what you've just reported, hence my general
confusion).  This means it's a gifload.c bug, not a gif.c
bug (my last change to gifload.c was strictly a LZW bugfix
so I can't see a potential problem there, but I'll try to look
into it :( ).
Thanks,
--Adam
--
Adam D. Moss   . ,,^^   [EMAIL PROTECTED]   http://www.foxbox.org/   co:3
I am NOT a nut!  I am the keeper of the seven universal truths!
___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] gimp 1.3.18 - Pink backgrounds on GIF's

2003-08-14 Thread Steven P. Ulrick
On Mon, 11 Aug 2003 12:30:10 +0100
Adam D. Moss [EMAIL PROTECTED] wrote:

 Steven P. Ulrick wrote:
  http://www.faith4miracle.org/FaithLogo-circle.gif
 ...
  the image always displays properly before I open it in Gimp 1.3.17
  or 1.3.18.  Whenever I have saved one of the images that was given a
  pink background instead of a transparent one, there has been
  absolutely no error messages whatsoever.
 
 At what point is an image 'given' a pink background?

Hello, Adam :)
The image is first given a pink background in the preview before it is
even opened.  Here is an experiment I just tried:
1. Open up Gimp 1.2.3 and Gimp 1.3.18 (Examples of Gimp versions that
deal with this issure correctly and incorrectly)
2. In Gimp 1.2.3, click File | Open and choose the desired image.
3. In the preview box, before the image is even opened, the image
displays correctly, with a transparent background.  Remember, this is in
the Preview, before it's even opened.
4. At this point, we have seen that the image itself has a transparent
background.  So let's move on to the next step.
5. In Gimp 1.3.18, click File | Open and choose the desired image,
6. In the preview box, before the image is opened, the background is
already pink.
7. Just for fun, without resaving the image we just opened twice, reopen
the image that you just saw with a pink background with Gimp 1.2.3.  You
will notice that the background is still transparent.

Okay, now open up the orginal image:

http://www.faith4miracle.org/FaithLogo-circle.gif

in Gimp 1.3.18 and save it under a different name. (You could save it
under the same name if you wanted, but of course if you wanted to
investigate this further, you'd need to get a new copy :))
Now, since you saved the formerly background-less image in the Gimp
version that attatches a pink background to transparent GIF's, the image
has a pink background in every version of the Gimp.  It has become a
permanent part of the image. 

 How do I reproduce the problem -- would I be right in thinking
 that if I load the GIF above, then re-save it again and re-load
 the result then the resulting GIF will have a pink background?

I answered this question in my response above, but to reiterate, the
answer is yes, if you resave the image in Gimp 1.3.18 and reload it in
any version of the Gimp, GQview, ImageMagick, whatever, it now has a
pink background.

As an experiment, in a few hours, I'm going to take the original logo I
cut the Circle image out of, and use the same program in Windows that I
cropped the circle part out to begin with, and then save it as a
transparent GIF and run the same tests with that.  This is just in case
something funny has happened to the image itself.  Which of course only
changes the problem slightly  But at least it may eliminate some
possibilities :)

Steven P. Ulrick
___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] gimp 1.3.18 - Pink backgrounds on GIF's

2003-08-14 Thread Tom Mraz
Adam D. Moss wrote:
Tom Mraz wrote:
The guchar - gchar change without correcting the code using the buf 
isn't probably good idea?


I think you're right.  That bogus change totally sneaked under
my radar...  (heads will roll! :D  :D  :D )
If someone who sees the problem can test this fix: 
http://icculus.org/~aspirin/gifload.c that'd be good.

I've tested it and it fixes the bug.

Tom Mraz

___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] gimp 1.3.18 - Pink backgrounds on GIF's

2003-08-14 Thread Jeff Trefftzs
On Mon, 2003-08-11 at 07:33, Adam D. Moss wrote:
 Adam D. Moss wrote:
  Okay, in that case I think I must have made a mistake in
  the forward-port of the 1.2.x fix to 1.3.x, because I can't
  reproduce this in my 1.2.x tree with the equivilent GIF plugin
  4.01.00 fix in it.
  
  I'll try to spot what the forward-port does differently.
 
 I can't see anything wrong with the forward-port, and still
 can't reproduce this with the same mod on the 1.2.x branch.
 Now I can't afford any more time to look into this in the
 near future.
 
 Maybe someone who can reproduce this in 1.3.18 can come
 up with some ideas.
 
 Here's the unpublished 1.2.x gif-save plugin with the same fix
 that went into 1.3.17 (which I'm ASSUMING is the fix that is at
 the root of this problem), for comparison:
 http://icculus.org/~aspirin/gif.c
 
 --Adam

Without getting fancy, I just tried this image in gimp-1.3.18 (Linux,
RedHat 9).  It opened with the pink background, but I could repair the
transparency by (a) adding an alpha channel in the Layers and Channels
Dialog and (b) select by color/clear selection.  

Is the problem as simple as losing the alpha channel from the GIF in the
later versions?



-- 

--Jeff

Jeff Trefftzs [EMAIL PROTECTED]
http://www.tcsn.net/trefftzsHome Page
http://gug.sunsite.dk/gallery.php?artist=68 Gimp Gallery
http://trefftzs.topcities.com/  Photo Gallery 

___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] gimp 1.3.18 - Pink backgrounds on GIF's

2003-08-14 Thread Adam D. Moss
Tom Mraz wrote:
If someone who sees the problem can test this fix: 
http://icculus.org/~aspirin/gifload.c that'd be good.
I've tested it and it fixes the bug.
Thanks all, the fix is in.

--Adam
--
Adam D. Moss   . ,,^^   [EMAIL PROTECTED]   http://www.foxbox.org/   co:3
I am NOT a nut!  I am the keeper of the seven universal truths!
___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] gimp 1.3.18 - Pink backgrounds on GIF's

2003-08-14 Thread Branko Collin
On 11 Aug 2003, at 4:26, Steven P. Ulrick wrote:
  I've had this problem for the last two development versions of the
  Gimp: 1.3.17 and 1.3.18
  Hopefully, to maximize the clarity of the information that I have to
 give you, and minimize the size of this e-mail, I will proceed with a
 series of links to screen shots and brief, appropriate comments.
 
 1.For the sake of accuracy, I first include a screen-shot of GIF that
 has this problem, as viewed in a non-Gimp application: Gqview 1.3.2
 http://www.faith4miracle.org/01-GimpSS-GQVIEW.jpg
  You will notice that the background is transparent, as represented by
 the grey/light gray checks.  No problem here.

[...] 
 5.Gimp 1.3.17:
 http://www.faith4miracle.org/05-GimpSS-gimp-1.3.17.jpg
  As you can clearly see, the background is now pink.

Starting 1.3.17, the GIF plug-in has been changed in the following 
way (from plug-ins/common/gif.c, spacing edited to accommodate 
wrapping):

 * REVISION HISTORY
 *
 * 2003-06-16
 * 4.01.00 - Attempt to use the palette colour closest to 
 *   that of the GIMP's current brush background 
 *   colour for the GIF file's background index 
 *   hint for non-transparency-aware image 
 *   viewers.  NOTE that this is merely a hint 
 *   and may be ignored by this plugin for 
 *   various (rare) reasons that would usually 
 *   entail writing a somewhat larger image 
 *   file.

This may be related.

-- 
branko collin
[EMAIL PROTECTED]
___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] gimp 1.3.18 - Pink backgrounds on GIF's

2003-08-14 Thread Steven P. Ulrick
On Mon, 11 Aug 2003 10:58:10 +0100
Adam D. Moss [EMAIL PROTECTED] wrote:

 Can you provide a copy of the GIF in question?
 
 To be clear, this only happens to the GIF when when you SAVE it
 out from .17 or .18?  If so, do you see any warnings on the
 console when you save from these versions?
 
 --Adam
 -- 
 Adam D. Moss   . ,,^^   [EMAIL PROTECTED]   http://www.foxbox.org/   co:3
 I am NOT a nut!  I am the keeper of the seven universal truths!

Hello, Adam :)
You should have already received an e-mail that I sent with a link to
the original image, but I sent it to myself instead of the list :)
Here is the link, though, to the image in question:
http://www.faith4miracle.org/FaithLogo-circle.gif

Since my original e-mail, I discovered that I didn't even have gtk+ on
my system.  But I since have installed gtk+-2.2.2 and recompiled and
installed Gimp 1.3.18, but I still have the same problem.

In reference to the following question:
  To be clear, this only happens to the GIF when when you SAVE it
  out from .17 or .18?  If so, do you see any warnings on the
  console when you save from these versions?

the image always displays properly before I open it in Gimp 1.3.17 or
1.3.18.  Whenever I have saved one of the images that was given a pink
background instead of a transparent one, there has been absolutely no
error messages whatsoever.

Thanks for your speedy response :), and when I get some time, I'll send
a message telling you everyting I love about the Gimp :)

Steven P. Ulrick
___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] gimp 1.3.18 - Pink backgrounds on GIF's

2003-08-11 Thread Adam D. Moss
Hi.

Jeff Trefftzs wrote:
Without getting fancy, I just tried this image in gimp-1.3.18 (Linux,
RedHat 9).  It opened with the pink background
Wait, it OPENED with the pink background?  You didn't have
to save it out again first?
--
Adam D. Moss   . ,,^^   [EMAIL PROTECTED]   http://www.foxbox.org/   co:3
I am NOT a nut!  I am the keeper of the seven universal truths!
___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer


Re: [Gimp-developer] gimp 1.3.18 - Pink backgrounds on GIF's

2003-08-11 Thread Adam D. Moss
Tom Mraz wrote:
It is probably this checkin:
http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=contextwhitespace_mode=showfile=gifload.cbranch=root=/cvs/gnomesubdir=/gimp/plug-ins/commoncommand=DIFF_FRAMESETrev1=1.30rev2=1.31 

The guchar - gchar change without correcting the code using the buf 
isn't probably good idea?
I think you're right.  That bogus change totally sneaked under
my radar...  (heads will roll! :D  :D  :D )
If someone who sees the problem can test this fix: 
http://icculus.org/~aspirin/gifload.c that'd be good.

Thanks,
--Adam
--
Adam D. Moss   . ,,^^   [EMAIL PROTECTED]   http://www.foxbox.org/   co:3
I am NOT a nut!  I am the keeper of the seven universal truths!
___
Gimp-developer mailing list
[EMAIL PROTECTED]
http://lists.xcf.berkeley.edu/mailman/listinfo/gimp-developer