Review Request: GIRAPH-124: Combiner should return IterableM instead of M or null.

2012-01-23 Thread Claudio Martella
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3592/ --- Review request for giraph. Summary --- Fixed the null check on the

[jira] [Commented] (GIRAPH-124) Combiner should return IterableM instead of M or null.

2012-01-23 Thread Claudio Martella (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13191154#comment-13191154 ] Claudio Martella commented on GIRAPH-124: - Ok, fixed the javadoc and the null

[jira] [Updated] (GIRAPH-45) Improve the way to keep outgoing messages

2012-01-23 Thread Claudio Martella (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claudio Martella updated GIRAPH-45: --- Attachment: GIRAPH-45.diff This a premature patch not meant for inclusion but as RFC. It

Review Request: GIRAPH-128: RPC port from BasicRPCCommunications should be only a starting port, and retried

2012-01-23 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3596/ --- Review request for giraph. Summary --- Simple handling of port collisions

[jira] [Commented] (GIRAPH-128) RPC port from BasicRPCCommunications should be only a starting port, and retried

2012-01-23 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13191425#comment-13191425 ] jirapos...@reviews.apache.org commented on GIRAPH-128: --

[jira] [Commented] (GIRAPH-124) Combiner should return IterableM instead of M or null.

2012-01-23 Thread Claudio Martella (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13191431#comment-13191431 ] Claudio Martella commented on GIRAPH-124: - damn RB. it should be fixed now...

Re: Review Request: GIRAPH-124: Combiner should return IterableM instead of M or null.

2012-01-23 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3592/#review4538 --- Ship it! Looks great! One very minor thing. Before you commit, can

[jira] [Commented] (GIRAPH-124) Combiner should return IterableM instead of M or null.

2012-01-23 Thread Claudio Martella (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13191480#comment-13191480 ] Claudio Martella commented on GIRAPH-124: - Commited, thanks.

[jira] [Commented] (GIRAPH-124) Combiner should return IterableM instead of M or null.

2012-01-23 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13191510#comment-13191510 ] Hudson commented on GIRAPH-124: --- Integrated in Giraph-trunk-Commit #65 (See

[jira] [Resolved] (GIRAPH-124) Combiner should return IterableM instead of M or null.

2012-01-23 Thread Claudio Martella (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claudio Martella resolved GIRAPH-124. - Resolution: Fixed Combiner should return IterableM instead of M or null.