Review Request: Refactor vertices to not expose the internal datastructure for holding messages

2011-12-15 Thread Sebastian Schelter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3203/ --- Review request for giraph. Summary --- refactoring that gives BasicVertex

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-12-15 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170115#comment-13170115 ] jirapos...@reviews.apache.org commented on GIRAPH-80: -

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-12-15 Thread Claudio Martella (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170178#comment-13170178 ] Claudio Martella commented on GIRAPH-80: is this re-based after GIRAPH-104?

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-12-15 Thread Sebastian Schelter (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170192#comment-13170192 ] Sebastian Schelter commented on GIRAPH-80: -- It should apply to current trunk, do

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-12-15 Thread Sebastian Schelter (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170299#comment-13170299 ] Sebastian Schelter commented on GIRAPH-80: -- No problem. I can rework them to fit

[jira] [Commented] (GIRAPH-57) Add new RPC call (putVertexIdMessagesList) to batch putMsgList RPCs together

2011-12-15 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170532#comment-13170532 ] jirapos...@reviews.apache.org commented on GIRAPH-57: -

Re: Review Request: Refactor vertices to not expose the internal datastructure for holding messages

2011-12-15 Thread Claudio Martella
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3203/#review3929 --- /trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java line

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-12-15 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170542#comment-13170542 ] jirapos...@reviews.apache.org commented on GIRAPH-80: -

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

2011-12-15 Thread Claudio Martella (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170563#comment-13170563 ] Claudio Martella commented on GIRAPH-45: Great, we're converge. The BTree is for

[jira] [Commented] (GIRAPH-57) Add new RPC call (putVertexIdMessagesList) to batch putMsgList RPCs together

2011-12-15 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170586#comment-13170586 ] Hudson commented on GIRAPH-57: -- Integrated in Giraph-trunk-Commit #48 (See

[jira] [Resolved] (GIRAPH-57) Add new RPC call (putVertexIdMessagesList) to batch putMsgList RPCs together

2011-12-15 Thread Avery Ching (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avery Ching resolved GIRAPH-57. --- Resolution: Fixed Thanks Claudio! I just want to note that I added the Apache License header to

[jira] [Commented] (GIRAPH-57) Add new RPC call (putVertexIdMessagesList) to batch putMsgList RPCs together

2011-12-15 Thread Claudio Martella (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170601#comment-13170601 ] Claudio Martella commented on GIRAPH-57: I guess how it passed mvn install...

[jira] [Commented] (GIRAPH-57) Add new RPC call (putVertexIdMessagesList) to batch putMsgList RPCs together

2011-12-15 Thread Jakob Homan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170605#comment-13170605 ] Jakob Homan commented on GIRAPH-57: --- Can we post the final patch, along with the I give

[jira] [Updated] (GIRAPH-57) Add new RPC call (putVertexIdMessagesList) to batch putMsgList RPCs together

2011-12-15 Thread Avery Ching (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avery Ching updated GIRAPH-57: -- Attachment: GIRAPH-57.diff.2 With the final patch (+Apache license header on VertexIdMessages.java).

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

2011-12-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170613#comment-13170613 ] Avery Ching commented on GIRAPH-45: --- You might not need the BTree for indexing the

[jira] [Commented] (GIRAPH-93) Hive input / output format

2011-12-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170631#comment-13170631 ] Avery Ching commented on GIRAPH-93: --- Just wanted to update that I did get this to work

Re: Review Request: Refactor vertices to not expose the internal datastructure for holding messages

2011-12-15 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3203/#review3936 --- I think that overall this looks pretty nice. I do have a couple of

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-12-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170651#comment-13170651 ] Avery Ching commented on GIRAPH-80: --- By the way Sebastian, you can run the Hadoop tests

[jira] [Commented] (GIRAPH-103) Added properties for commonly used package version to pom.xml

2011-12-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170803#comment-13170803 ] Avery Ching commented on GIRAPH-103: No one wants to take a quick look? It's very