[jira] [Updated] (GIRAPH-185) Improve concurrency of putMsg / putMsgList

2012-04-24 Thread Bo Wang (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Wang updated GIRAPH-185: --- Attachment: GIRAPH-185.patch Thanks for keeping up in the communication, Avery. I used putIfAbsent in the

Review Request: Improve concurrency of putMsg / putMsgList

2012-04-24 Thread Bo Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4852/ --- Review request for giraph. Summary --- Use ConcurrentHashMap and

[jira] [Commented] (GIRAPH-185) Improve concurrency of putMsg / putMsgList

2012-04-24 Thread jirapos...@reviews.apache.org (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260275#comment-13260275 ] jirapos...@reviews.apache.org commented on GIRAPH-185: --

Re: Review Request: Improve concurrency of putMsg / putMsgList

2012-04-24 Thread Claudio Martella
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4852/#review7169 --- Looks good to me, wound't hurt to see some stress test to check

[jira] [Commented] (GIRAPH-185) Improve concurrency of putMsg / putMsgList

2012-04-24 Thread jirapos...@reviews.apache.org (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260416#comment-13260416 ] jirapos...@reviews.apache.org commented on GIRAPH-185: --

[jira] [Commented] (GIRAPH-170) Workflow for loading RDF graph data into Giraph

2012-04-24 Thread Benjamin Heitmann (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260512#comment-13260512 ] Benjamin Heitmann commented on GIRAPH-170: -- Thanks guys for your comments!

[jira] [Created] (GIRAPH-188) Merge inMessages and vertex message list

2012-04-24 Thread Bo Wang (JIRA)
Bo Wang created GIRAPH-188: -- Summary: Merge inMessages and vertex message list Key: GIRAPH-188 URL: https://issues.apache.org/jira/browse/GIRAPH-188 Project: Giraph Issue Type: Improvement

[jira] [Commented] (GIRAPH-185) Improve concurrency of putMsg / putMsgList

2012-04-24 Thread jirapos...@reviews.apache.org (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261004#comment-13261004 ] jirapos...@reviews.apache.org commented on GIRAPH-185: --

Re: Review Request: Improve concurrency of putMsg / putMsgList

2012-04-24 Thread Bo Wang
On 2012-04-24 20:53:33, Avery Ching wrote: http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java, lines 776-777 https://reviews.apache.org/r/4852/diff/1/?file=104059#file104059line776 Bo, I'm a little leery about

[jira] [Commented] (GIRAPH-185) Improve concurrency of putMsg / putMsgList

2012-04-24 Thread jirapos...@reviews.apache.org (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261029#comment-13261029 ] jirapos...@reviews.apache.org commented on GIRAPH-185: -- bq. On

Re: Review Request: Improve concurrency of putMsg / putMsgList

2012-04-24 Thread Avery Ching
On 2012-04-24 20:53:33, Avery Ching wrote: http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java, lines 776-777 https://reviews.apache.org/r/4852/diff/1/?file=104059#file104059line776 Bo, I'm a little leery about

[jira] [Commented] (GIRAPH-185) Improve concurrency of putMsg / putMsgList

2012-04-24 Thread jirapos...@reviews.apache.org (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261046#comment-13261046 ] jirapos...@reviews.apache.org commented on GIRAPH-185: -- bq. On

Re: Review Request: Improve concurrency of putMsg / putMsgList

2012-04-24 Thread Avery Ching
On 2012-04-24 20:53:33, Avery Ching wrote: http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java, lines 776-777 https://reviews.apache.org/r/4852/diff/1/?file=104059#file104059line776 Bo, I'm a little leery about

[jira] [Commented] (GIRAPH-185) Improve concurrency of putMsg / putMsgList

2012-04-24 Thread jirapos...@reviews.apache.org (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13261054#comment-13261054 ] jirapos...@reviews.apache.org commented on GIRAPH-185: -- bq. On

[jira] [Updated] (GIRAPH-172) Javadoc for BasicVertex:compute link to compute is broken

2012-04-24 Thread Abhishek Srivastava (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Srivastava updated GIRAPH-172: --- Attachment: GIRAPH-172.patch Fixed the broken javadoc link in BasicVertex. Testing

[jira] [Updated] (GIRAPH-173) BspCase:getNumWorkers javadoc refers to non-existent parameter

2012-04-24 Thread Abhishek Srivastava (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Srivastava updated GIRAPH-173: --- Attachment: GIRAPH-173.patch Fixed broken comment for getNumWorkers. Testing Done: