[jira] [Commented] (GIRAPH-86) Simplify boolean expressions in ZooKeeperExt::createExt
[
https://issues.apache.org/jira/browse/GIRAPH-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152284#comment-13152284
]
Attila Csordas commented on GIRAPH-86:
--
it didn't help yesterday but I checked out the latest code today and now
rat:check is ok. This time cannot build the project due to Failed to execute
goal on project giraph: Could not resolve dependencies for project
org.apache.giraph:giraph:jar:0.70: Could not find artifact
org.apache.hadoop:hadoop-common:jar:0.21.0-dev-SNAPSHOT - [Help 1]
do we need that at all?
Simplify boolean expressions in ZooKeeperExt::createExt
---
Key: GIRAPH-86
URL: https://issues.apache.org/jira/browse/GIRAPH-86
Project: Giraph
Issue Type: Improvement
Affects Versions: 0.70.0
Reporter: Jakob Homan
Assignee: Attila Csordas
Labels: newbie
Attachments: GIRAPH-86.patch, pom.diff
In ZooKeeperExt::createExt there are two instances of {{recursive==false}}
that can be simplified to !recursive.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-86) Simplify boolean expressions in ZooKeeperExt::createExt
[
https://issues.apache.org/jira/browse/GIRAPH-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152328#comment-13152328
]
Jakob Homan commented on GIRAPH-86:
---
+1. I've committed this. Not sure why you ended up with a reference to Hadoop
0.21. That's an unstable, unsupported version. I can't find a reference to it
in our pom. In terms of the rat check, rather than making rat ignore the file
we should really just fix GIRAPH-20, which is triggering this. Thanks for the
contribution, Attila!
Simplify boolean expressions in ZooKeeperExt::createExt
---
Key: GIRAPH-86
URL: https://issues.apache.org/jira/browse/GIRAPH-86
Project: Giraph
Issue Type: Improvement
Affects Versions: 0.70.0
Reporter: Jakob Homan
Assignee: Attila Csordas
Labels: newbie
Fix For: 0.70.0
Attachments: GIRAPH-86.patch, pom.diff
In ZooKeeperExt::createExt there are two instances of {{recursive==false}}
that can be simplified to !recursive.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-86) Simplify boolean expressions in ZooKeeperExt::createExt
[
https://issues.apache.org/jira/browse/GIRAPH-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152337#comment-13152337
]
Hudson commented on GIRAPH-86:
--
Integrated in Giraph-trunk-Commit #37 (See
[https://builds.apache.org/job/Giraph-trunk-Commit/37/])
GIRAPH-86. Simplify boolean expressions in ZooKeeperExt::createExt.
Contributed by Attila Csordas.
jghoman :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1203369
Files :
* /incubator/giraph/trunk/CHANGELOG
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/zk/ZooKeeperExt.java
Simplify boolean expressions in ZooKeeperExt::createExt
---
Key: GIRAPH-86
URL: https://issues.apache.org/jira/browse/GIRAPH-86
Project: Giraph
Issue Type: Improvement
Affects Versions: 0.70.0
Reporter: Jakob Homan
Assignee: Attila Csordas
Labels: newbie
Fix For: 0.70.0
Attachments: GIRAPH-86.patch, pom.diff
In ZooKeeperExt::createExt there are two instances of {{recursive==false}}
that can be simplified to !recursive.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
