Review Request: Refactor vertices to not expose the internal datastructure for holding messages

2011-12-15 Thread Sebastian Schelter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3203/ --- Review request for giraph. Summary --- refactoring that gives BasicVertex t

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-12-15 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170115#comment-13170115 ] jirapos...@reviews.apache.org commented on GIRAPH-80: - ---

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

2011-12-15 Thread Claudio Martella (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170121#comment-13170121 ] Claudio Martella commented on GIRAPH-45: Yes, we don't, I agree. As a matter of fac

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-12-15 Thread Claudio Martella (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170178#comment-13170178 ] Claudio Martella commented on GIRAPH-80: is this re-based after GIRAPH-104?

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-12-15 Thread Sebastian Schelter (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170192#comment-13170192 ] Sebastian Schelter commented on GIRAPH-80: -- It should apply to current trunk, do y

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-12-15 Thread Claudio Martella (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170295#comment-13170295 ] Claudio Martella commented on GIRAPH-80: I guess the problem is that Avery got my +

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-12-15 Thread Sebastian Schelter (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170299#comment-13170299 ] Sebastian Schelter commented on GIRAPH-80: -- No problem. I can rework them to fit G

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-12-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170398#comment-13170398 ] Avery Ching commented on GIRAPH-80: --- Guys, GIRAPH-104 has been committed, the svn commit

[jira] [Commented] (GIRAPH-57) Add new RPC call (putVertexIdMessagesList) to batch putMsgList RPCs together

2011-12-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170489#comment-13170489 ] Avery Ching commented on GIRAPH-57: --- Anyone wanna review? This is a pretty straightforwa

Re: Review Request: GIRAPH-57 Add new RPC call (putVertexIdMessagesList) to batch putMsgList RPCs together

2011-12-15 Thread Claudio Martella
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3201/#review3928 --- Ship it! Looks cool and straight from here. All those CODE_CONVENTION

[jira] [Commented] (GIRAPH-57) Add new RPC call (putVertexIdMessagesList) to batch putMsgList RPCs together

2011-12-15 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170532#comment-13170532 ] jirapos...@reviews.apache.org commented on GIRAPH-57: - ---

Re: Review Request: Refactor vertices to not expose the internal datastructure for holding messages

2011-12-15 Thread Claudio Martella
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3203/#review3929 --- /trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java line 189

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-12-15 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170542#comment-13170542 ] jirapos...@reviews.apache.org commented on GIRAPH-80: - ---

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

2011-12-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170558#comment-13170558 ] Avery Ching commented on GIRAPH-45: --- Claudio, thanks for your response. I agree with you

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

2011-12-15 Thread Claudio Martella (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170563#comment-13170563 ] Claudio Martella commented on GIRAPH-45: Great, we're converge. The BTree is for in

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

2011-12-15 Thread Claudio Martella (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170568#comment-13170568 ] Claudio Martella commented on GIRAPH-45: btw what do you mean be stream the message

[jira] [Commented] (GIRAPH-57) Add new RPC call (putVertexIdMessagesList) to batch putMsgList RPCs together

2011-12-15 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170586#comment-13170586 ] Hudson commented on GIRAPH-57: -- Integrated in Giraph-trunk-Commit #48 (See [https://builds.ap

[jira] [Resolved] (GIRAPH-57) Add new RPC call (putVertexIdMessagesList) to batch putMsgList RPCs together

2011-12-15 Thread Avery Ching (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avery Ching resolved GIRAPH-57. --- Resolution: Fixed Thanks Claudio! I just want to note that I added the Apache License header to Vert

[jira] [Commented] (GIRAPH-57) Add new RPC call (putVertexIdMessagesList) to batch putMsgList RPCs together

2011-12-15 Thread Claudio Martella (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170601#comment-13170601 ] Claudio Martella commented on GIRAPH-57: I guess how it passed mvn install...

[jira] [Commented] (GIRAPH-57) Add new RPC call (putVertexIdMessagesList) to batch putMsgList RPCs together

2011-12-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170602#comment-13170602 ] Avery Ching commented on GIRAPH-57: --- I only ran mvn package =(. I need to remember to do

[jira] [Commented] (GIRAPH-57) Add new RPC call (putVertexIdMessagesList) to batch putMsgList RPCs together

2011-12-15 Thread Jakob Homan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170605#comment-13170605 ] Jakob Homan commented on GIRAPH-57: --- Can we post the final patch, along with the "I give

[jira] [Updated] (GIRAPH-57) Add new RPC call (putVertexIdMessagesList) to batch putMsgList RPCs together

2011-12-15 Thread Avery Ching (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avery Ching updated GIRAPH-57: -- Attachment: GIRAPH-57.diff.2 With the final patch (+Apache license header on VertexIdMessages.java).

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

2011-12-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170613#comment-13170613 ] Avery Ching commented on GIRAPH-45: --- You might not need the BTree for indexing the destin

[jira] [Commented] (GIRAPH-93) Hive input / output format

2011-12-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170631#comment-13170631 ] Avery Ching commented on GIRAPH-93: --- Just wanted to update that I did get this to work wi

Re: Review Request: Refactor vertices to not expose the internal datastructure for holding messages

2011-12-15 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3203/#review3936 --- I think that overall this looks pretty nice. I do have a couple of s

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-12-15 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170645#comment-13170645 ] jirapos...@reviews.apache.org commented on GIRAPH-80: - ---

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-12-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170651#comment-13170651 ] Avery Ching commented on GIRAPH-80: --- By the way Sebastian, you can run the Hadoop tests a

[jira] [Commented] (GIRAPH-103) Added properties for commonly used package version to pom.xml

2011-12-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170803#comment-13170803 ] Avery Ching commented on GIRAPH-103: No one wants to take a quick look? It's very sho