[
https://issues.apache.org/jira/browse/GIRAPH-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188331#comment-13188331
]
Avery Ching commented on GIRAPH-125:
Thanks for findings this. I agree this is a bug.
Use Collections.emptyList() in BasicRPCCommunications.java
--
Key: GIRAPH-126
URL: https://issues.apache.org/jira/browse/GIRAPH-126
Project: Giraph
Issue Type: Improvement
R
[
https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
André Kelpe updated GIRAPH-126:
---
Attachment: GIRAPH-126.patch
> Use Collections.emptyList() in BasicRPCCommunications.java
> -
[
https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jakob Homan reassigned GIRAPH-126:
--
Assignee: André Kelpe
> Use Collections.emptyList() in BasicRPCCommunications.java
> --
[
https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188572#comment-13188572
]
Jakob Homan commented on GIRAPH-126:
Looks good except for the introduction of two new
[
https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188578#comment-13188578
]
Avery Ching commented on GIRAPH-126:
Agree with Jakob. Thanks Andrei, every memory im
[
https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
André Kelpe updated GIRAPH-126:
---
Attachment: GIRAPH-126.patch
removed empty lines
> Use Collections.emptyList() in Ba
[
https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
André Kelpe updated GIRAPH-126:
---
Attachment: GIRAPH-126.patch
remove empty lines and grant apache the correct lines
>
[
https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188581#comment-13188581
]
André Kelpe commented on GIRAPH-126:
I have done that.
> Use Collecti
[
https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188588#comment-13188588
]
Avery Ching commented on GIRAPH-126:
Actually, looking at it some more, does this work
[
https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188606#comment-13188606
]
Claudio Martella commented on GIRAPH-126:
-
Avery is right, EMPTY_LIST is Immutable
[
https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188608#comment-13188608
]
Jakob Homan commented on GIRAPH-126:
yeah, good catch:
{noformat}scala> list3.add(42)
[
https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188624#comment-13188624
]
André Kelpe commented on GIRAPH-126:
True, overlooked that, I guess you can close the
[
https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188644#comment-13188644
]
Claudio Martella commented on GIRAPH-126:
-
I think the suggestion to use the initi
[
https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188654#comment-13188654
]
André Kelpe commented on GIRAPH-126:
@Claudio True. One question though: When I read E
[
https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188656#comment-13188656
]
Avery Ching commented on GIRAPH-126:
I think we are moving to guava. Much nicer in my
[
https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188666#comment-13188666
]
Jakob Homan commented on GIRAPH-126:
bq. I think we are moving to guava. Much nicer in
[
https://issues.apache.org/jira/browse/GIRAPH-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuanyuan Tian updated GIRAPH-125:
-
Attachment: LongDoubleFloatDoubleVertex.java.patch
> Bug in LongDoubleFloatDoubleVertex.sendM
[
https://issues.apache.org/jira/browse/GIRAPH-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188870#comment-13188870
]
Hudson commented on GIRAPH-125:
---
Integrated in Giraph-trunk-Commit #64 (See
[https://builds
19 matches
Mail list logo