[ https://issues.apache.org/jira/browse/GIRAPH-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256127#comment-13256127 ]
Hudson commented on GIRAPH-175: ------------------------------- Integrated in Giraph-trunk-Commit #104 (See [https://builds.apache.org/job/Giraph-trunk-Commit/104/]) GIRAPH-175. Replace manual array copy to utility method call. Contributed by Devaraj K. (Revision 1327344) Result = SUCCESS jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327344 Files : * /incubator/giraph/trunk/CHANGELOG * /incubator/giraph/trunk/src/main/java/org/apache/giraph/zk/ZooKeeperManager.java > Replace manual array copy to utility method call > ------------------------------------------------ > > Key: GIRAPH-175 > URL: https://issues.apache.org/jira/browse/GIRAPH-175 > Project: Giraph > Issue Type: Improvement > Reporter: Jakob Homan > Assignee: Devaraj K > Priority: Trivial > Fix For: 0.2.0 > > Attachments: GIRAPH-175.patch > > > {code} String[] zkJavaOptsArray = zkJavaOptsString.split(" "); > if (zkJavaOptsArray != null) { > for (String javaOpt : zkJavaOptsArray) { > commandList.add(javaOpt); > } > }{code} > Rather than doing the loop ourselves, Collections.addAll would be simpler > (and faster, though that doesn't matter with such a small array). Still > cleaner, though. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira