[jira] [Commented] (GIRAPH-184) Upgrade to junit4
[ https://issues.apache.org/jira/browse/GIRAPH-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256882#comment-13256882 ] Hudson commented on GIRAPH-184: --- Integrated in Giraph-trunk-Commit #105 (See [https://builds.apache.org/job/Giraph-trunk-Commit/105/]) GIRAPH-184. Upgrade to junit4. Contributed by Devaraj K. (Revision 1327637) Result = SUCCESS jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327637 Files : * /incubator/giraph/trunk/CHANGELOG * /incubator/giraph/trunk/pom.xml * /incubator/giraph/trunk/src/test/java/org/apache/giraph/BspCase.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestAutoCheckpoint.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestBspBasic.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestGraphPartitioner.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestJsonBase64Format.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestManualCheckpoint.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestMutateGraphVertex.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestNotEnoughMapTasks.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestPredicateLock.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestVertexTypes.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestZooKeeperExt.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/comm/RPCCommunicationsTest.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTest.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/examples/MinimumIntCombinerTest.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/examples/SimpleShortestPathVertexTest.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/examples/TryMultiRpcBindingPortsTest.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/graph/TestEdgeListVertex.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/lib/TestAdjacencyListTextVertexOutputFormat.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/lib/TestIdWithValueTextOutputFormat.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/lib/TestLongDoubleDoubleAdjacencyListVertexInputFormat.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/lib/TestTextDoubleDoubleAdjacencyListVertexInputFormat.java * /incubator/giraph/trunk/src/test/java/org/apache/giraph/utils/ComparisonUtilsTest.java * /incubator/giraph/trunk/src/test/java/zk/TestZooKeeperManager.java > Upgrade to junit4 > - > > Key: GIRAPH-184 > URL: https://issues.apache.org/jira/browse/GIRAPH-184 > Project: Giraph > Issue Type: Bug >Reporter: Devaraj K >Assignee: Devaraj K > Fix For: 0.2.0 > > Attachments: GIRAPH-184-1.patch, GIRAPH-184-2.patch, GIRAPH-184.patch > > > Presently Giraph uses JUnit 3.8.1. We can upgrade to JUnit 4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-184) Upgrade to junit4
[
https://issues.apache.org/jira/browse/GIRAPH-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256874#comment-13256874
]
Jakob Homan commented on GIRAPH-184:
+1. There are a couple other changes in terms of simplifying {{boolean ==
true}}, but that's fine.
> Upgrade to junit4
> -
>
> Key: GIRAPH-184
> URL: https://issues.apache.org/jira/browse/GIRAPH-184
> Project: Giraph
> Issue Type: Bug
>Reporter: Devaraj K
> Attachments: GIRAPH-184-1.patch, GIRAPH-184-2.patch, GIRAPH-184.patch
>
>
> Presently Giraph uses JUnit 3.8.1. We can upgrade to JUnit 4
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-184) Upgrade to junit4
[
https://issues.apache.org/jira/browse/GIRAPH-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256115#comment-13256115
]
Jakob Homan commented on GIRAPH-184:
We can dramatically shrink this patch with static imports to make this type of
change unnecessary:
{code}-assertFalse(ComparisonUtils.equal(one, two));
-assertFalse(ComparisonUtils.equal(two, one));
+Assert.assertFalse(ComparisonUtils.equal(one, two));
+Assert.assertFalse(ComparisonUtils.equal(two, one));{code}
> Upgrade to junit4
> -
>
> Key: GIRAPH-184
> URL: https://issues.apache.org/jira/browse/GIRAPH-184
> Project: Giraph
> Issue Type: Bug
>Reporter: Devaraj K
> Attachments: GIRAPH-184-1.patch, GIRAPH-184.patch
>
>
> Presently Giraph uses JUnit 3.8.1. We can upgrade to JUnit 4
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-184) Upgrade to junit4
[ https://issues.apache.org/jira/browse/GIRAPH-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254838#comment-13254838 ] Eugene Koontz commented on GIRAPH-184: -- (sorry for the double post) > Upgrade to junit4 > - > > Key: GIRAPH-184 > URL: https://issues.apache.org/jira/browse/GIRAPH-184 > Project: Giraph > Issue Type: Bug >Reporter: Devaraj K > Attachments: GIRAPH-184.patch > > > Presently Giraph uses JUnit 3.8.1. We can upgrade to JUnit 4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-184) Upgrade to junit4
[
https://issues.apache.org/jira/browse/GIRAPH-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254834#comment-13254834
]
Eugene Koontz commented on GIRAPH-184:
--
Hi Devaraj,
I noticed in your patch, for
{{src/test/java/org/apache/giraph/TestBspBasic.java}}, you added:
{code}
import org.junit.Assert;
import org.junit.Test;
{code}
within the scope of a munge ifdef - it should be outside of the ifdef,
shouldn't it?
Even with this fix, I get 7 test failures:
{code}
Results :
Tests in error:
initializationError0(org.apache.giraph.TestManualCheckpoint)
initializationError0(org.apache.giraph.TestAutoCheckpoint)
initializationError0(org.apache.giraph.TestBspBasic)
initializationError0(org.apache.giraph.TestGraphPartitioner)
initializationError0(org.apache.giraph.TestNotEnoughMapTasks)
initializationError0(org.apache.giraph.TestMutateGraphVertex)
initializationError0(org.apache.giraph.TestJsonBase64Format)
Tests run: 50, Failures: 0, Errors: 7, Skipped: 0
{code}
> Upgrade to junit4
> -
>
> Key: GIRAPH-184
> URL: https://issues.apache.org/jira/browse/GIRAPH-184
> Project: Giraph
> Issue Type: Bug
>Reporter: Devaraj K
> Attachments: GIRAPH-184.patch
>
>
> Presently Giraph uses JUnit 3.8.1. We can upgrade to JUnit 4
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-184) Upgrade to junit4
[
https://issues.apache.org/jira/browse/GIRAPH-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254835#comment-13254835
]
Eugene Koontz commented on GIRAPH-184:
--
Hi Devaraj,
I noticed in your patch, for
{{src/test/java/org/apache/giraph/TestBspBasic.java}}, you added:
{code}
import org.junit.Assert;
import org.junit.Test;
{code}
within the scope of a munge ifdef - it should be outside of the ifdef,
shouldn't it?
Even with this fix, I get 7 test failures:
{code}
Results :
Tests in error:
initializationError0(org.apache.giraph.TestManualCheckpoint)
initializationError0(org.apache.giraph.TestAutoCheckpoint)
initializationError0(org.apache.giraph.TestBspBasic)
initializationError0(org.apache.giraph.TestGraphPartitioner)
initializationError0(org.apache.giraph.TestNotEnoughMapTasks)
initializationError0(org.apache.giraph.TestMutateGraphVertex)
initializationError0(org.apache.giraph.TestJsonBase64Format)
Tests run: 50, Failures: 0, Errors: 7, Skipped: 0
{code}
> Upgrade to junit4
> -
>
> Key: GIRAPH-184
> URL: https://issues.apache.org/jira/browse/GIRAPH-184
> Project: Giraph
> Issue Type: Bug
>Reporter: Devaraj K
> Attachments: GIRAPH-184.patch
>
>
> Presently Giraph uses JUnit 3.8.1. We can upgrade to JUnit 4
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-184) Upgrade to junit4
[ https://issues.apache.org/jira/browse/GIRAPH-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254152#comment-13254152 ] Avery Ching commented on GIRAPH-184: Thanks! > Upgrade to junit4 > - > > Key: GIRAPH-184 > URL: https://issues.apache.org/jira/browse/GIRAPH-184 > Project: Giraph > Issue Type: Bug >Reporter: Devaraj K >Assignee: Devaraj K > > Presently Giraph uses JUnit 3.8.1. We can upgrade to JUnit 4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-184) Upgrade to junit4
[ https://issues.apache.org/jira/browse/GIRAPH-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254151#comment-13254151 ] Devaraj K commented on GIRAPH-184: -- Sure Avery, I will start working on this. > Upgrade to junit4 > - > > Key: GIRAPH-184 > URL: https://issues.apache.org/jira/browse/GIRAPH-184 > Project: Giraph > Issue Type: Bug >Reporter: Devaraj K >Assignee: Devaraj K > > Presently Giraph uses JUnit 3.8.1. We can upgrade to JUnit 4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-184) Upgrade to junit4
[ https://issues.apache.org/jira/browse/GIRAPH-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254150#comment-13254150 ] Avery Ching commented on GIRAPH-184: Sounds good. Would you like to work on this Devaraj? > Upgrade to junit4 > - > > Key: GIRAPH-184 > URL: https://issues.apache.org/jira/browse/GIRAPH-184 > Project: Giraph > Issue Type: Bug >Reporter: Devaraj K > > Presently Giraph uses JUnit 3.8.1. We can upgrade to JUnit 4 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
