[jira] [Commented] (GIRAPH-27) Mutable static global state in Vertex.java should be refactored

2011-09-16 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/GIRAPH-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13106815#comment-13106815
 ] 

Hudson commented on GIRAPH-27:
--

Integrated in Giraph-trunk-Commit #7 (See 
[https://builds.apache.org/job/Giraph-trunk-Commit/7/])
GIRAPH-34: Failure of Vertex reflection for putVertexList from
GIRAPH-27. (aching)

aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1171776
Files : 
* /incubator/giraph/trunk/CHANGELOG
* 
/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
* 
/incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Vertex.java
* 
/incubator/giraph/trunk/src/test/java/org/apache/giraph/TestVertexRangeBalancer.java


 Mutable static global state in Vertex.java should be refactored
 ---

 Key: GIRAPH-27
 URL: https://issues.apache.org/jira/browse/GIRAPH-27
 Project: Giraph
  Issue Type: Improvement
  Components: graph
Affects Versions: 0.70.0
Reporter: Jake Mannix
Assignee: Jake Mannix
 Attachments: GIRAPH-27.patch, GIRAPH-27.patch


 Vertex.java has a bunch of static methods for getting/setting global graph 
 state (total number of vertices, edges, a reference to the GraphMapper, etc). 
  Refactoring this into a GraphState object, which every Vertex can hold onto 
 a reference to (yes, a tiny bit more memory per Vertex, but in comparison to 
 what's already in there...)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (GIRAPH-27) Mutable static global state in Vertex.java should be refactored

2011-09-12 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/GIRAPH-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102916#comment-13102916
 ] 

Hudson commented on GIRAPH-27:
--

Integrated in Giraph-trunk-Commit #4 (See 
[https://builds.apache.org/job/Giraph-trunk-Commit/4/])
GIRAPH-27: Fixed type parameter errors in Hudson (aching).

aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1169863
Files : 
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Vertex.java


 Mutable static global state in Vertex.java should be refactored
 ---

 Key: GIRAPH-27
 URL: https://issues.apache.org/jira/browse/GIRAPH-27
 Project: Giraph
  Issue Type: Improvement
  Components: graph
Affects Versions: 0.70.0
Reporter: Jake Mannix
Assignee: Jake Mannix
 Attachments: GIRAPH-27.patch, GIRAPH-27.patch


 Vertex.java has a bunch of static methods for getting/setting global graph 
 state (total number of vertices, edges, a reference to the GraphMapper, etc). 
  Refactoring this into a GraphState object, which every Vertex can hold onto 
 a reference to (yes, a tiny bit more memory per Vertex, but in comparison to 
 what's already in there...)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (GIRAPH-27) Mutable static global state in Vertex.java should be refactored

2011-09-12 Thread Jake Mannix (JIRA)

[ 
https://issues.apache.org/jira/browse/GIRAPH-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102937#comment-13102937
 ] 

Jake Mannix commented on GIRAPH-27:
---

Why are you using redundant type parameters?  Type inference gets you the type 
for free, and it compiles fine without it, and is unambiguous and more 
compact...

 Mutable static global state in Vertex.java should be refactored
 ---

 Key: GIRAPH-27
 URL: https://issues.apache.org/jira/browse/GIRAPH-27
 Project: Giraph
  Issue Type: Improvement
  Components: graph
Affects Versions: 0.70.0
Reporter: Jake Mannix
Assignee: Jake Mannix
 Attachments: GIRAPH-27.patch, GIRAPH-27.patch


 Vertex.java has a bunch of static methods for getting/setting global graph 
 state (total number of vertices, edges, a reference to the GraphMapper, etc). 
  Refactoring this into a GraphState object, which every Vertex can hold onto 
 a reference to (yes, a tiny bit more memory per Vertex, but in comparison to 
 what's already in there...)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (GIRAPH-27) Mutable static global state in Vertex.java should be refactored

2011-09-12 Thread Avery Ching (JIRA)

[ 
https://issues.apache.org/jira/browse/GIRAPH-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102986#comment-13102986
 ] 

Avery Ching commented on GIRAPH-27:
---

Oh, it's very annoying.  This problem has bitten me many times. =)

 Mutable static global state in Vertex.java should be refactored
 ---

 Key: GIRAPH-27
 URL: https://issues.apache.org/jira/browse/GIRAPH-27
 Project: Giraph
  Issue Type: Improvement
  Components: graph
Affects Versions: 0.70.0
Reporter: Jake Mannix
Assignee: Jake Mannix
 Attachments: GIRAPH-27.patch, GIRAPH-27.patch


 Vertex.java has a bunch of static methods for getting/setting global graph 
 state (total number of vertices, edges, a reference to the GraphMapper, etc). 
  Refactoring this into a GraphState object, which every Vertex can hold onto 
 a reference to (yes, a tiny bit more memory per Vertex, but in comparison to 
 what's already in there...)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (GIRAPH-27) Mutable static global state in Vertex.java should be refactored

2011-09-09 Thread Jake Mannix (JIRA)

[ 
https://issues.apache.org/jira/browse/GIRAPH-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13101026#comment-13101026
 ] 

Jake Mannix commented on GIRAPH-27:
---

+1 (non-committer) from me.

 Mutable static global state in Vertex.java should be refactored
 ---

 Key: GIRAPH-27
 URL: https://issues.apache.org/jira/browse/GIRAPH-27
 Project: Giraph
  Issue Type: Improvement
  Components: graph
Affects Versions: 0.70.0
Reporter: Jake Mannix
Assignee: Jake Mannix
 Attachments: GIRAPH-27.patch, GIRAPH-27.patch


 Vertex.java has a bunch of static methods for getting/setting global graph 
 state (total number of vertices, edges, a reference to the GraphMapper, etc). 
  Refactoring this into a GraphState object, which every Vertex can hold onto 
 a reference to (yes, a tiny bit more memory per Vertex, but in comparison to 
 what's already in there...)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (GIRAPH-27) Mutable static global state in Vertex.java should be refactored

2011-09-09 Thread Jakob Homan (JIRA)

[ 
https://issues.apache.org/jira/browse/GIRAPH-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13101602#comment-13101602
 ] 

Jakob Homan commented on GIRAPH-27:
---

+1. reviewboard on an iPad on hotel wifi sucks.

 Mutable static global state in Vertex.java should be refactored
 ---

 Key: GIRAPH-27
 URL: https://issues.apache.org/jira/browse/GIRAPH-27
 Project: Giraph
  Issue Type: Improvement
  Components: graph
Affects Versions: 0.70.0
Reporter: Jake Mannix
Assignee: Jake Mannix
 Attachments: GIRAPH-27.patch, GIRAPH-27.patch


 Vertex.java has a bunch of static methods for getting/setting global graph 
 state (total number of vertices, edges, a reference to the GraphMapper, etc). 
  Refactoring this into a GraphState object, which every Vertex can hold onto 
 a reference to (yes, a tiny bit more memory per Vertex, but in comparison to 
 what's already in there...)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (GIRAPH-27) Mutable static global state in Vertex.java should be refactored

2011-09-09 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/GIRAPH-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13101950#comment-13101950
 ] 

Hudson commented on GIRAPH-27:
--

Integrated in Giraph-trunk-Commit #3 (See 
[https://builds.apache.org/job/Giraph-trunk-Commit/3/])
GIRAPH-27: Mutable static global state in Vertex.java should be
refactored. jake.mannix via aching.

aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1167420
Files : 
* /incubator/giraph/trunk/CHANGELOG
* 
/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedService.java
* 
/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspService.java
* 
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspUtils.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GraphState.java
* 
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/MutableVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Vertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexRange.java
* 
/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/VertexResolver.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestBspBasic.java


 Mutable static global state in Vertex.java should be refactored
 ---

 Key: GIRAPH-27
 URL: https://issues.apache.org/jira/browse/GIRAPH-27
 Project: Giraph
  Issue Type: Improvement
  Components: graph
Affects Versions: 0.70.0
Reporter: Jake Mannix
Assignee: Jake Mannix
 Attachments: GIRAPH-27.patch, GIRAPH-27.patch


 Vertex.java has a bunch of static methods for getting/setting global graph 
 state (total number of vertices, edges, a reference to the GraphMapper, etc). 
  Refactoring this into a GraphState object, which every Vertex can hold onto 
 a reference to (yes, a tiny bit more memory per Vertex, but in comparison to 
 what's already in there...)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (GIRAPH-27) Mutable static global state in Vertex.java should be refactored

2011-09-08 Thread Avery Ching (JIRA)

[ 
https://issues.apache.org/jira/browse/GIRAPH-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13100856#comment-13100856
 ] 

Avery Ching commented on GIRAPH-27:
---

Thanks.  I just updated it.

 Mutable static global state in Vertex.java should be refactored
 ---

 Key: GIRAPH-27
 URL: https://issues.apache.org/jira/browse/GIRAPH-27
 Project: Giraph
  Issue Type: Improvement
  Components: graph
Affects Versions: 0.70.0
Reporter: Jake Mannix
Assignee: Jake Mannix
 Attachments: GIRAPH-27.patch, GIRAPH-27.patch


 Vertex.java has a bunch of static methods for getting/setting global graph 
 state (total number of vertices, edges, a reference to the GraphMapper, etc). 
  Refactoring this into a GraphState object, which every Vertex can hold onto 
 a reference to (yes, a tiny bit more memory per Vertex, but in comparison to 
 what's already in there...)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (GIRAPH-27) Mutable static global state in Vertex.java should be refactored

2011-09-08 Thread Jake Mannix (JIRA)

[ 
https://issues.apache.org/jira/browse/GIRAPH-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13100901#comment-13100901
 ] 

Jake Mannix commented on GIRAPH-27:
---

Awesome, thanks Avery.  Looks good to me.

In looking over the diff in more detail in reviewboard, I notice that there are 
still a bunch of places where Vertex is referred to, but really BasicVertex (or 
at most MutableVertex) is all that's needed.  But I'll open another ticket for 
those changes once this has been merged in.

 Mutable static global state in Vertex.java should be refactored
 ---

 Key: GIRAPH-27
 URL: https://issues.apache.org/jira/browse/GIRAPH-27
 Project: Giraph
  Issue Type: Improvement
  Components: graph
Affects Versions: 0.70.0
Reporter: Jake Mannix
Assignee: Jake Mannix
 Attachments: GIRAPH-27.patch, GIRAPH-27.patch


 Vertex.java has a bunch of static methods for getting/setting global graph 
 state (total number of vertices, edges, a reference to the GraphMapper, etc). 
  Refactoring this into a GraphState object, which every Vertex can hold onto 
 a reference to (yes, a tiny bit more memory per Vertex, but in comparison to 
 what's already in there...)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (GIRAPH-27) Mutable static global state in Vertex.java should be refactored

2011-09-08 Thread Avery Ching (JIRA)

[ 
https://issues.apache.org/jira/browse/GIRAPH-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13100928#comment-13100928
 ] 

Avery Ching commented on GIRAPH-27:
---

That is actually intentional, since I need to have access to the 
get/setGraphState() internally and I removed the get/setGraphState() from 
BasicVertex.  So rather than expose get/setGraphState() to the user 
(BasicVertex), I opted to to this.  I suppose we could have another interface 
internally that extended BasicVertex to allow getting and setting the graph 
state if you're concerned about exposed the vertex to the internals.  Let me 
know what you think.

 Mutable static global state in Vertex.java should be refactored
 ---

 Key: GIRAPH-27
 URL: https://issues.apache.org/jira/browse/GIRAPH-27
 Project: Giraph
  Issue Type: Improvement
  Components: graph
Affects Versions: 0.70.0
Reporter: Jake Mannix
Assignee: Jake Mannix
 Attachments: GIRAPH-27.patch, GIRAPH-27.patch


 Vertex.java has a bunch of static methods for getting/setting global graph 
 state (total number of vertices, edges, a reference to the GraphMapper, etc). 
  Refactoring this into a GraphState object, which every Vertex can hold onto 
 a reference to (yes, a tiny bit more memory per Vertex, but in comparison to 
 what's already in there...)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira