[jira] [Commented] (GIRAPH-63) Typo in PageRankBenchmark
[
https://issues.apache.org/jira/browse/GIRAPH-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148625#comment-13148625
]
Hudson commented on GIRAPH-63:
--
Integrated in Giraph-trunk-Commit #27 (See
[https://builds.apache.org/job/Giraph-trunk-Commit/27/])
GIRAPH-63. Typo in PageRankBenchmark. Contributed by Shaunak Kashyap.
jghoman :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1200988
Files :
* /incubator/giraph/trunk/CHANGELOG
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
*
/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/RandomMessageBenchmark.java
> Typo in PageRankBenchmark
> -
>
> Key: GIRAPH-63
> URL: https://issues.apache.org/jira/browse/GIRAPH-63
> Project: Giraph
> Issue Type: Bug
>Reporter: Jakob Homan
>Assignee: Shaunak Kashyap
>Priority: Trivial
> Labels: newbie
> Fix For: 0.70.0
>
> Attachments: GIRAPH-63.diff
>
>
> {code:title=PageRankBenchmark.java|borderStyle=solid}
> if (!cmd.hasOption('s')) {
> System.out.println("Need to set the number of supesteps (-s)");
> return -1;
> }{code}
> supesteps -> supersteps
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-63) Typo in PageRankBenchmark
[
https://issues.apache.org/jira/browse/GIRAPH-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148598#comment-13148598
]
Jakob Homan commented on GIRAPH-63:
---
Perfect, thanks! +1 on the patch. Will commit shortly.
> Typo in PageRankBenchmark
> -
>
> Key: GIRAPH-63
> URL: https://issues.apache.org/jira/browse/GIRAPH-63
> Project: Giraph
> Issue Type: Bug
>Reporter: Jakob Homan
>Assignee: Shaunak Kashyap
>Priority: Trivial
> Labels: newbie
> Attachments: GIRAPH-63.diff
>
>
> {code:title=PageRankBenchmark.java|borderStyle=solid}
> if (!cmd.hasOption('s')) {
> System.out.println("Need to set the number of supesteps (-s)");
> return -1;
> }{code}
> supesteps -> supersteps
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-63) Typo in PageRankBenchmark
[
https://issues.apache.org/jira/browse/GIRAPH-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148592#comment-13148592
]
Jakob Homan commented on GIRAPH-63:
---
Ah, thanks. Actually, for some reason, JIRA hides this option with its latest
upgrade. On More Actions there's an Attach File option that will upload the
patch file itself. Then we can download this and apply it to the tree. Looks
good though, from what was pasted in!
> Typo in PageRankBenchmark
> -
>
> Key: GIRAPH-63
> URL: https://issues.apache.org/jira/browse/GIRAPH-63
> Project: Giraph
> Issue Type: Bug
>Reporter: Jakob Homan
>Assignee: Shaunak Kashyap
>Priority: Trivial
> Labels: newbie
> Attachments: GIRAPH-63.diff
>
>
> {code:title=PageRankBenchmark.java|borderStyle=solid}
> if (!cmd.hasOption('s')) {
> System.out.println("Need to set the number of supesteps (-s)");
> return -1;
> }{code}
> supesteps -> supersteps
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-63) Typo in PageRankBenchmark
[
https://issues.apache.org/jira/browse/GIRAPH-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148586#comment-13148586
]
Jakob Homan commented on GIRAPH-63:
---
Hey Shaunak- Can you attach the patch to the JIRA? Thanks.
> Typo in PageRankBenchmark
> -
>
> Key: GIRAPH-63
> URL: https://issues.apache.org/jira/browse/GIRAPH-63
> Project: Giraph
> Issue Type: Bug
>Reporter: Jakob Homan
>Assignee: Shaunak Kashyap
>Priority: Trivial
> Labels: newbie
>
> {code:title=PageRankBenchmark.java|borderStyle=solid}
> if (!cmd.hasOption('s')) {
> System.out.println("Need to set the number of supesteps (-s)");
> return -1;
> }{code}
> supesteps -> supersteps
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-63) Typo in PageRankBenchmark
[
https://issues.apache.org/jira/browse/GIRAPH-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148585#comment-13148585
]
jirapos...@reviews.apache.org commented on GIRAPH-63:
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2807/
---
Review request for giraph.
Summary
---
Fixing typo "supestep" -> "superstep".
This addresses bug GIRAPH-63.
https://issues.apache.org/jira/browse/GIRAPH-63
Diffs
-
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
1200720
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/benchmark/RandomMessageBenchmark.java
1200720
Diff: https://reviews.apache.org/r/2807/diff
Testing
---
$ mvn test
Thanks,
shaunak
> Typo in PageRankBenchmark
> -
>
> Key: GIRAPH-63
> URL: https://issues.apache.org/jira/browse/GIRAPH-63
> Project: Giraph
> Issue Type: Bug
>Reporter: Jakob Homan
>Assignee: Shaunak Kashyap
>Priority: Trivial
> Labels: newbie
>
> {code:title=PageRankBenchmark.java|borderStyle=solid}
> if (!cmd.hasOption('s')) {
> System.out.println("Need to set the number of supesteps (-s)");
> return -1;
> }{code}
> supesteps -> supersteps
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-63) Typo in PageRankBenchmark
[
https://issues.apache.org/jira/browse/GIRAPH-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148579#comment-13148579
]
Shaunak Kashyap commented on GIRAPH-63:
---
Also found the same typo in
{{org/apache/giraph/benchmark/RandomMessageBenchmark.java}}:
{code:title=RandomMessageBenchmark.java|borderStyle=solid}
if (!cmd.hasOption('s')) {
System.out.println("Need to set the number of supesteps (-s)");
return -1;
}
{code}
> Typo in PageRankBenchmark
> -
>
> Key: GIRAPH-63
> URL: https://issues.apache.org/jira/browse/GIRAPH-63
> Project: Giraph
> Issue Type: Bug
>Reporter: Jakob Homan
>Priority: Trivial
> Labels: newbie
>
> {code:title=PageRankBenchmark.java|borderStyle=solid}
> if (!cmd.hasOption('s')) {
> System.out.println("Need to set the number of supesteps (-s)");
> return -1;
> }{code}
> supesteps -> supersteps
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
