[
https://issues.apache.org/jira/browse/GIRAPH-74?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claudio Martella updated GIRAPH-74:
---
Attachment: GIRAPH-70.diff
Refactored according to feedback.
Removed isHalted() and setHalted().
BasicVertex has now package-level boolean isHalted that package-level classes,
such as GraphMapper, are setting and reading accordingly. Vertex and other
subclasses are implementing voteToHalt() accordingly.
At this point I guess BasicVertex could just implement it.
> GIRAPH-36 missed a couple of liners when passing from Vertex to BasicVertex
> ---
>
> Key: GIRAPH-74
> URL: https://issues.apache.org/jira/browse/GIRAPH-74
> Project: Giraph
> Issue Type: Bug
> Components: graph
>Affects Versions: 0.70.0
>Reporter: Claudio Martella
>Assignee: Claudio Martella
> Fix For: 0.70.0
>
> Attachments: GIRAPH-36-cleaup.diff, GIRAPH-70.diff
>
>
> After GIRAPH-36, in a couple of places Vertex was left instead of
> BasicVertex. To achieve the fix a BasicVertex was extended with a new boolean
> isHalted(boolean state) method that totally hides boolean halt field. I
> believe this unifies the voteToHalt() and isHalted() methods totally hiding
> the halting management of Vertices (before it was relying on the existence of
> boolean halt field).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira