Re: Review Request: GIRAPH-11 : Improve the graph distribution of Giraph

2011-11-14 Thread Jakob Homan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2788/#review3211 --- Overall I like it. Please avoid non-essential format changes in

Re: Review Request: GIRAPH-11 : Improve the graph distribution of Giraph

2011-11-14 Thread Avery Ching
On 2011-11-14 20:54:28, Jakob Homan wrote: Overall I like it. Please avoid non-essential format changes in large patches; when reviewing it's like trying to run a marathon with a pebble in your shoe. There needs to be quite a bit of unit test coverage on the new classes. Most of

Re: Review Request: GIRAPH-11 : Improve the graph distribution of Giraph

2011-11-13 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2788/ --- (Updated 2011-11-14 06:56:19.251685) Review request for giraph. Changes