zmike pushed a commit to branch efl-1.22.

http://git.enlightenment.org/core/efl.git/commit/?id=e739f551feab3afba732254677d671e1169b5088

commit e739f551feab3afba732254677d671e1169b5088
Author: Cedric BAIL <cedric.b...@free.fr>
Date:   Thu Mar 28 14:09:54 2019 -0700

    elementary: fix error path during shutdown of fileselector.
    
    During shutdown, sometimes, we can have an error generated on the object
    while it is invalidating, but before it is invalidated. This lead to
    properties on the object to change to an error state and trigger the
    properties changed logic. At this point, the parent has already been
    destroyed and we don't really have anything more to do. So let's not
    do anything.
    
    Reviewed-by: Mike Blumenkrantz <michael.blumenkra...@gmail.com>
    Differential Revision: https://phab.enlightenment.org/D8502
---
 src/lib/elementary/elc_fileselector.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/lib/elementary/elc_fileselector.c 
b/src/lib/elementary/elc_fileselector.c
index 5121e6d112..b718924429 100644
--- a/src/lib/elementary/elc_fileselector.c
+++ b/src/lib/elementary/elc_fileselector.c
@@ -823,6 +823,10 @@ _process_model(Elm_Fileselector_Data *sd, Efl_Model *child)
    double mtime = 0;
    Eina_Bool dir = EINA_FALSE;
 
+   // In case we are shutting down, there might be an error being gnerated
+   if (!parent) return ;
+
+   // We should be good now
    if (!_fetch_string_value(parent, "path", &parent_path) ||
        !_fetch_string_value(child, "path", &path) ||
        !_fetch_string_value(child, "filename", &filename) ||

-- 


Reply via email to