devilhorns pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=cbf2aa2bf99d54cdcc3cf68966b6630c9094a547
commit cbf2aa2bf99d54cdcc3cf68966b6630c9094a547
Author: Chris Michael <cpmich...@osg.samsung.com>
Date: Wed Jan 27 12:05:59 2016 -0500
evas: Fix explicit NULL dereference
This patch fixes an Coverity issue that if 'dst' gets set to NULL (as can
happen above) then this eo_do call may segfault as it is directly
accessing 'dst->buffer'.
@fix
CID1347415
Signed-off-by: Chris Michael <cpmich...@osg.samsung.com>
---
src/lib/evas/filters/evas_filter_utils.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/lib/evas/filters/evas_filter_utils.c
b/src/lib/evas/filters/evas_filter_utils.c
index 802f09a..ec84301 100644
--- a/src/lib/evas/filters/evas_filter_utils.c
+++ b/src/lib/evas/filters/evas_filter_utils.c
@@ -63,7 +63,8 @@ evas_filter_buffer_scaled_get(Evas_Filter_Context *ctx,
end:
if (src_map) eo_do(src->buffer, ector_buffer_unmap(src_map, src_len));
- if (dst_map) eo_do(dst->buffer, ector_buffer_unmap(dst_map, dst_len));
+ if ((dst) && (dst_map))
+ eo_do(dst->buffer, ector_buffer_unmap(dst_map, dst_len));
DEBUG_TIME_END();
return dst;
}
--
