[EGIT] [core/elementary] master 01/01: Add a test to reveal a focus bug in Genlist/Gengrid

[Dave Andreoli]

davemds pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=7072fe56c4ca386e6d68e65a1d6ee454362d76af

commit 7072fe56c4ca386e6d68e65a1d6ee454362d76af
Author: Dave Andreoli 
Date:   Sun Jan 24 14:35:49 2016 +0100

Add a test to reveal a focus bug in Genlist/Gengrid

To reproduce:
 * elm_test -to "GenGrid Focus"
 * turn on the "Focus Highlight" checkbox
 * double-click an item to show a popup that should have the focus

As you can see the mouse-up event on the gengrid item steal the focus from 
the popup.
When, instead, the item is activated with the keyboard the popup correctly 
keep the focus.

I have this problem in both genlist and gengrid, so probably the error is 
not in the gengrid code, but somewhere else that I cannot find.

...any help appreciated
---
 src/bin/test_gengrid.c | 33 +++--
 1 file changed, 31 insertions(+), 2 deletions(-)

diff --git a/src/bin/test_gengrid.c b/src/bin/test_gengrid.c
index bd74e5b..18ab97c 100644
--- a/src/bin/test_gengrid.c
+++ b/src/bin/test_gengrid.c
@@ -1568,6 +1568,8 @@ test_gengrid_speed(void *data EINA_UNUSED, Evas_Object 
*obj EINA_UNUSED, void *e
evas_object_show(win);
 }
 
+
+/***  Gengrid Focus  */
 static void
 _gengrid_focus_item_cb(void *data, Evas_Object *obj EINA_UNUSED,
void *event_info)
@@ -1576,6 +1578,31 @@ _gengrid_focus_item_cb(void *data, Evas_Object *obj 
EINA_UNUSED,
 }
 
 static void
+_gengrid_focus_popup_close_cb(void *data, Evas_Object *obj EINA_UNUSED,
+  void *event_info EINA_UNUSED)
+{
+   evas_object_del(data);
+}
+
+static void
+_gengrid_focus_item_activated_cb(void *data, Evas_Object *obj EINA_UNUSED,
+ void *event_info EINA_UNUSED)
+{
+Evas_Object *popup, *btn;
+
+popup = elm_popup_add(data);
+elm_object_text_set(popup, "This Popup must have the focus");
+
+btn = elm_button_add(popup);
+elm_object_text_set(btn, "Close");
+elm_object_part_content_set(popup, "button1", btn);
+evas_object_smart_callback_add(btn, "clicked",
+   _gengrid_focus_popup_close_cb, popup);
+
+evas_object_show(popup);
+}
+
+static void
 _gengrid_focus_key_down_cb(void *data EINA_UNUSED, Evas *e EINA_UNUSED,
Evas_Object *obj EINA_UNUSED, void *event_info)
 {
@@ -1727,9 +1754,10 @@ test_gengrid_focus(void *data EINA_UNUSED,
evas_object_smart_callback_add(gengrid, "item,unfocused", 
_gengrid_focus_item_cb, "item,unfocused");
evas_object_smart_callback_add(gengrid, "selected", _gengrid_focus_item_cb, 
"selected");
evas_object_smart_callback_add(gengrid, "unselected", 
_gengrid_focus_item_cb, "unselected");
-   evas_object_smart_callback_add(gengrid, "activated", 
_gengrid_focus_item_cb, "activated");
evas_object_smart_callback_add(gengrid, "highlighted", 
_gengrid_focus_item_cb, "highlighted");
evas_object_smart_callback_add(gengrid, "unhighlighted", 
_gengrid_focus_item_cb, "unhighlighted");
+   evas_object_smart_callback_add(gengrid, "activated", 
_gengrid_focus_item_cb, "activated");
+   evas_object_smart_callback_add(gengrid, "activated", 
_gengrid_focus_item_activated_cb, win);
evas_object_event_callback_add(gengrid, EVAS_CALLBACK_KEY_DOWN, 
_gengrid_focus_key_down_cb, NULL);
 
gengrid2 = elm_gengrid_add(in_bx);
@@ -1745,9 +1773,10 @@ test_gengrid_focus(void *data EINA_UNUSED,
evas_object_smart_callback_add(gengrid2, "item,unfocused", 
_gengrid_focus_item_cb, "item,unfocused");
evas_object_smart_callback_add(gengrid2, "selected", 
_gengrid_focus_item_cb, "selected");
evas_object_smart_callback_add(gengrid2, "unselected", 
_gengrid_focus_item_cb, "unselected");
-   evas_object_smart_callback_add(gengrid2, "activated", 
_gengrid_focus_item_cb, "activated");
evas_object_smart_callback_add(gengrid2, "highlighted", 
_gengrid_focus_item_cb, "highlighted");
evas_object_smart_callback_add(gengrid2, "unhighlighted", 
_gengrid_focus_item_cb, "unhighlighted");
+   evas_object_smart_callback_add(gengrid2, "activated", 
_gengrid_focus_item_cb, "activated");
+   evas_object_smart_callback_add(gengrid2, "activated", 
_gengrid_focus_item_activated_cb, win);
evas_object_event_callback_add(gengrid2, EVAS_CALLBACK_KEY_DOWN, 
_gengrid_focus_key_down_cb, NULL);
 
btn = elm_button_add(bx);

-- 

[EGIT] [core/elementary] master 01/01: Reveal the same focus bug of previous commit also in genlist.

[Dave Andreoli]

davemds pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=15e9f8071da393aee4bd83313a73f0fff3ff7eab

commit 15e9f8071da393aee4bd83313a73f0fff3ff7eab
Author: Dave Andreoli 
Date:   Sun Jan 24 15:44:48 2016 +0100

Reveal the same focus bug of previous commit also in genlist.

See previous commit for instructions on how to reproduce in "Genlist Focus" 
test.
---
 src/bin/test_genlist.c | 20 
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/src/bin/test_genlist.c b/src/bin/test_genlist.c
index 9dcebc1..2813c42 100644
--- a/src/bin/test_genlist.c
+++ b/src/bin/test_genlist.c
@@ -4214,9 +4214,11 @@ gl_focus_top_items_text_get(void *data, Evas_Object *obj 
EINA_UNUSED,
if (!strcmp(data, "do_nothing"))
  return strdup("Genlist Item");
else if (!strcmp(data, "popup_sel"))
- return strdup("Create a popup on Select");
+ return strdup("Create a popup on Select (popup parent is gl)");
else if (!strcmp(data, "popup_mouse_down"))
- return strdup("Create a popup on Mouse Down");
+ return strdup("Create a popup on Mouse Down (popup parent is gl)");
+   else if (!strcmp(data, "popup_activate"))
+ return strdup("Create a popup on Activate (popup parent is win)");
else if (!strcmp(data, "clear_on_focus"))
  return strdup("Genlist Clear on Focus");
else
@@ -4400,9 +4402,17 @@ _gl_focus_item_unfocus_cb(void *data EINA_UNUSED, 
Evas_Object *obj EINA_UNUSED,
 }
 
 static void
-_gl_focus_item_cb(void *data, Evas_Object *obj EINA_UNUSED, void *event_info)
+_gl_focus_item_cb(void *data, Evas_Object *obj, void *event_info)
 {
-   printf("%s: %p\n", (char *)data, event_info);
+   Elm_Object_Item *it = event_info;
+
+   printf("%s: %p\n", (char *)data, it);
+
+   if (!strcmp((char *)data, "activated") &&
+   !strcmp((char *)elm_object_item_data_get(it), "popup_activate"))
+ {
+ _gl_focus_sel_popup_create(elm_object_top_widget_get(obj));
+ }
 }
 
 static void
@@ -4896,6 +4906,8 @@ test_genlist_focus(void *data EINA_UNUSED,
_gl_focus_0_item_sel_cb, NULL);
elm_genlist_item_append(gl, itc, "popup_mouse_down", NULL, 
ELM_GENLIST_ITEM_NONE,
NULL, NULL);
+   elm_genlist_item_append(gl, itc, "popup_activate", NULL, 
ELM_GENLIST_ITEM_NONE,
+   NULL, NULL);
 
it = elm_genlist_item_append(gl, itc, "clear_on_focus", NULL, 
ELM_GENLIST_ITEM_NONE,
 NULL, NULL);

-- 

[EGIT] [tools/enventor] master 01/01: about - use entry_file_set() instead of direct file accessing.

[Hermet Park]

hermet pushed a commit to branch master.

http://git.enlightenment.org/tools/enventor.git/commit/?id=c79a0aa4e5f2be3e1c092e88471ac289726e2cc8

commit c79a0aa4e5f2be3e1c092e88471ac289726e2cc8
Author: Hermet Park 
Date:   Mon Jan 25 15:56:20 2016 +0900

about - use entry_file_set() instead of direct file accessing.

This changes enventor makes much simpler to maintaining code.
Additionally, the about file should have been markup format.
Previously, it used to use markup partially so its format was ambigious.
---
 data/about/ABOUT | 178 +++
 src/bin/menu.c   |  38 +---
 2 files changed, 91 insertions(+), 125 deletions(-)

diff --git a/data/about/ABOUT b/data/about/ABOUT
index 3475339..10e0d79 100644
--- a/data/about/ABOUT
+++ b/data/about/ABOUT
@@ -1,89 +1,89 @@

[EGIT] [core/elementary] master 01/01: elm_test: Show popup error when Plug can't connect

[Jean-Philippe ANDRÉ]

jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=2ea0df8aa9177c9d8974288fe718f85f41748c59

commit 2ea0df8aa9177c9d8974288fe718f85f41748c59
Author: Jean-Philippe Andre 
Date:   Fri Jan 22 17:13:35 2016 +0900

elm_test: Show popup error when Plug can't connect
---
 src/bin/test_win_plug.c | 32 ++--
 1 file changed, 30 insertions(+), 2 deletions(-)

diff --git a/src/bin/test_win_plug.c b/src/bin/test_win_plug.c
index 3557dc9..dd5d5d3 100644
--- a/src/bin/test_win_plug.c
+++ b/src/bin/test_win_plug.c
@@ -143,8 +143,36 @@ create_handles(Evas_Object *obj)
  }
 }
 
+static Eina_Bool
+_notify_end(void *data EINA_UNUSED, Eo *obj, const Eo_Event_Description *desc 
EINA_UNUSED, void *event_info EINA_UNUSED)
+{
+   eo_del(obj);
+   return EINA_FALSE;
+}
+
+static inline void
+_notify_error(Evas_Object *parent, const char *msg)
+{
+   Evas_Object *notif, *txt;
+
+   printf("%s\n", msg);
+
+   notif = elm_notify_add(parent);
+   evas_object_size_hint_weight_set(notif, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
+   elm_notify_align_set(notif, 0.5, 1.0);
+   elm_notify_timeout_set(notif, 3.0);
+   eo_do(notif, eo_event_callback_add(ELM_NOTIFY_EVENT_DISMISSED, _notify_end, 
NULL));
+
+   txt = elm_label_add(notif);
+   elm_object_text_set(txt, msg);
+   elm_object_content_set(notif, txt);
+
+   evas_object_show(txt);
+   evas_object_show(notif);
+}
+
 void
-test_win_plug(void *data EINA_UNUSED, Evas_Object *obj EINA_UNUSED, void 
*event_info EINA_UNUSED)
+test_win_plug(void *data, Evas_Object *obj EINA_UNUSED, void *event_info 
EINA_UNUSED)
 {
Evas_Object *win, *bg, *plug;
char buf[PATH_MAX];
@@ -165,7 +193,7 @@ test_win_plug(void *data EINA_UNUSED, Evas_Object *obj 
EINA_UNUSED, void *event_
evas_object_event_callback_add(plug, EVAS_CALLBACK_DEL, _timer_del, NULL);
if (!elm_plug_connect(plug, "ello", 0, EINA_FALSE))
  {
-printf("Cannot connect plug\n");
+_notify_error(data, "Unable to connect to the Window Socket!");
 return;
  }
 

-- 

[EGIT] [core/efl] master 01/01: ecore_evas_extn: Add safety checks, fixing a crash in elm_test

[Jean-Philippe ANDRÉ]

jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=4d4e6fd4b12545de9e0c9ade58566cd8f2802861

commit 4d4e6fd4b12545de9e0c9ade58566cd8f2802861
Author: Jean-Philippe Andre 
Date:   Mon Jan 25 15:58:16 2016 +0900

ecore_evas_extn: Add safety checks, fixing a crash in elm_test

See T2835 (my crash was different from the one reported).

The buffer may be initialized after the first render_pre, due to
whatever timing issue. Check in elm_test "Window Socket" and then
open several "Window Plug".

@fix
---
 src/modules/ecore_evas/engines/extn/ecore_evas_extn_buf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/modules/ecore_evas/engines/extn/ecore_evas_extn_buf.c 
b/src/modules/ecore_evas/engines/extn/ecore_evas_extn_buf.c
index 28ffcc3..8f28654 100644
--- a/src/modules/ecore_evas/engines/extn/ecore_evas_extn_buf.c
+++ b/src/modules/ecore_evas/engines/extn/ecore_evas_extn_buf.c
@@ -118,6 +118,7 @@ _extnbuf_data_get(Extnbuf *b, int *w, int *h, int *stride)
 void *
 _extnbuf_lock(Extnbuf *b, int *w, int *h, int *stride)
 {
+   if (!b) return NULL;
if (!b->have_lock)
  {
 if (b->lockfd >= 0)
@@ -136,7 +137,7 @@ _extnbuf_lock(Extnbuf *b, int *w, int *h, int *stride)
 void
 _extnbuf_unlock(Extnbuf *b)
 {
-   if (!b->have_lock) return;
+   if (!b || !b->have_lock) return;
if (b->lockfd >= 0)
  {
 if (lockf(b->lockfd, F_ULOCK, 0) < 0)

-- 

[EGIT] [core/elementary] master 02/02: Genlist: do not select the item two times in case of a double click.

[Dave Andreoli]

davemds pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=d92869633ffeca83acd3f3389368bd60d1e43854

commit d92869633ffeca83acd3f3389368bd60d1e43854
Author: Dave Andreoli 
Date:   Sun Jan 24 16:44:57 2016 +0100

Genlist: do not select the item two times in case of a double click.

In the case of a genlist set as ELM_OBJECT_SELECT_MODE_ALWAYS the 
"selected" cb was called 2 times. This @fix that by skipping the selection code 
in case the click is not the first one (EVAS_BUTTON_NONE).

Also merge the conditions of two consecutive "if" in a single statement.
---
 src/lib/elm_genlist.c | 9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c
index 572e734..2f57dea 100644
--- a/src/lib/elm_genlist.c
+++ b/src/lib/elm_genlist.c
@@ -4881,12 +4881,13 @@ _item_mouse_up_cb(void *data,
   }
  }
 
-   if (_is_no_select(it) ||
+   if ((ev->flags != EVAS_BUTTON_NONE) ||
+   (ev->event_flags & EVAS_EVENT_FLAG_ON_HOLD) ||
+   !it->base->still_in ||
+   _is_no_select(it) ||
(eo_do_ret(EO_OBJ(it), tmp, elm_wdg_item_disabled_get(
  return;
 
-   if (ev->event_flags & EVAS_EVENT_FLAG_ON_HOLD || !it->base->still_in) 
return;
-
evas_object_ref(sd->obj);
 
if (sd->multi &&
@@ -4928,7 +4929,7 @@ _item_mouse_up_cb(void *data,
 if (_item_select(it)) goto deleted;
  }
 
-   if ((ev->flags == EVAS_BUTTON_NONE) && (sd->focused_item != EO_OBJ(it)))
+   if (sd->focused_item != EO_OBJ(it))
  elm_object_item_focus_set(EO_OBJ(it), EINA_TRUE);
 
 deleted:

-- 

[EGIT] [core/elementary] master 01/02: Genlist/grid: do not set again the focus on double/triple click

[Dave Andreoli]

davemds pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=359bec5756d38a14158e6b2c64f86aaba2cfcd28

commit 359bec5756d38a14158e6b2c64f86aaba2cfcd28
Author: Dave Andreoli 
Date:   Sun Jan 24 16:11:13 2016 +0100

Genlist/grid: do not set again the focus on double/triple click

Focus is already setted on first mouse-up, no need to set again in double 
and triple click up events

@Fix the issue reported in previous commits
---
 src/lib/elm_gengrid.c | 2 +-
 src/lib/elm_genlist.c | 2 +-
 src/lib/elm_widget.c  | 6 --
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/lib/elm_gengrid.c b/src/lib/elm_gengrid.c
index 02b1294..81b1ce5 100644
--- a/src/lib/elm_gengrid.c
+++ b/src/lib/elm_gengrid.c
@@ -1099,7 +1099,7 @@ _item_mouse_up_cb(void *data,
 return;
  }
 
-   if (sd->focused_item != eo_it)
+   if ((ev->flags == EVAS_BUTTON_NONE) && (sd->focused_item != eo_it))
  elm_object_item_focus_set(eo_it, EINA_TRUE);
 
if (sd->multi &&
diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c
index de720cf..572e734 100644
--- a/src/lib/elm_genlist.c
+++ b/src/lib/elm_genlist.c
@@ -4928,7 +4928,7 @@ _item_mouse_up_cb(void *data,
 if (_item_select(it)) goto deleted;
  }
 
-   if (sd->focused_item != EO_OBJ(it))
+   if ((ev->flags == EVAS_BUTTON_NONE) && (sd->focused_item != EO_OBJ(it)))
  elm_object_item_focus_set(EO_OBJ(it), EINA_TRUE);
 
 deleted:
diff --git a/src/lib/elm_widget.c b/src/lib/elm_widget.c
index b779994..efcbc88 100644
--- a/src/lib/elm_widget.c
+++ b/src/lib/elm_widget.c
@@ -331,10 +331,12 @@ static void
 _obj_mouse_up(void *data,
   Evas *e EINA_UNUSED,
   Evas_Object *obj,
-  void *event_info EINA_UNUSED)
+  void *event_info)
 {
ELM_WIDGET_DATA_GET(data, sd);
-   if (sd->still_in &&
+   Evas_Event_Mouse_Up *ev = event_info;
+
+   if (sd->still_in && (ev->flags == EVAS_BUTTON_NONE) &&
(sd->focus_move_policy == ELM_FOCUS_MOVE_POLICY_CLICK))
  elm_widget_focus_mouse_up_handle(obj);
 

-- 

[EGIT] [editors/vim-configs] master 01/01: syntax/eo: add [[ ... ]] comments

[Jean Guyomarc'h]

jayji pushed a commit to branch master.

http://git.enlightenment.org/editors/vim-configs.git/commit/?id=92059086f48bb361aa4966d46ca2870774ab7a0a

commit 92059086f48bb361aa4966d46ca2870774ab7a0a
Author: Jean Guyomarc'h 
Date:   Sun Jan 24 22:51:35 2016 +0100

syntax/eo: add [[ ... ]] comments
---
 syntax/eo.vim | 1 +
 1 file changed, 1 insertion(+)

diff --git a/syntax/eo.vim b/syntax/eo.vim
index 0d5a3c5..387d22f 100644
--- a/syntax/eo.vim
+++ b/syntax/eo.vim
@@ -38,6 +38,7 @@ syn regioneoTypeParen start='<' end='>' transparent
 syn region eoBlock start="{" end="}" transparent fold
 
 syn region eo_comment start="\/\*" end="\*\/" contains=@eoCommentGroup
+syn region eo_comment start="\[\[" end="\]\]" contains=@eoCommentGroup
 
 " Numbers
 "integer number, or floating point number without a dot and with "f".

-- 

[EGIT] [core/efl] master 01/01: Ethumb: make the emotion plugin correctly use the edje frame if requested.

[Dave Andreoli]

davemds pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=cca830832a9b68757eb83da77aac0294761623b3

commit cca830832a9b68757eb83da77aac0294761623b3
Author: Dave Andreoli 
Date:   Sun Jan 24 22:58:24 2016 +0100

Ethumb: make the emotion plugin correctly use the edje frame if requested.

The emotion plugin was lacking the ability to use the edje frame as 
expected,
this patch add this ability, so now video thumbnail works like the normal 
ones.

This commit is a bit of a new feature, but I consider this a @fix as now
the ethumb_frame_set() API works as expected, also the implementation
is so simple that I think it can go in without any problems.
---
 src/modules/ethumb/emotion/emotion.c | 44 ++--
 1 file changed, 42 insertions(+), 2 deletions(-)

diff --git a/src/modules/ethumb/emotion/emotion.c 
b/src/modules/ethumb/emotion/emotion.c
index 2247318..ee2cdfe 100644
--- a/src/modules/ethumb/emotion/emotion.c
+++ b/src/modules/ethumb/emotion/emotion.c
@@ -41,6 +41,7 @@ struct _emotion_plugin
Eina_Bool first;
Eet_File *ef;
Evas_Object *video;
+   Evas_Object *edje_frame;
Ethumb *e;
int w, h;
 };
@@ -66,8 +67,16 @@ _resize_movie(struct _emotion_plugin *_plugin)
 
ethumb_plugin_image_resize(e, _plugin->w, _plugin->h);
 
-   evas_object_resize(_plugin->video, fw, fh);
-   evas_object_move(_plugin->video, fx, fy);
+   if (_plugin->edje_frame)
+ {
+evas_object_resize(_plugin->edje_frame, fw, fh);
+evas_object_move(_plugin->edje_frame, fx, fy);
+ }
+   else
+ {
+evas_object_resize(_plugin->video, fw, fh);
+evas_object_move(_plugin->video, fx, fy);
+ }
emotion_object_audio_mute_set(_plugin->video, 1);
 }
 
@@ -199,6 +208,7 @@ _finish_thumb_obj(void *data)
 {
struct _emotion_plugin *_plugin = data;
evas_object_del(_plugin->video);
+   if (_plugin->edje_frame) evas_object_del(_plugin->edje_frame);
free(_plugin);
 }
 
@@ -260,7 +270,9 @@ _frame_grab_single(void *data)
EMOTION_OBJECT_EVENT_FRAME_RESIZE,  _frame_resized_cb, _plugin));
 
emotion_object_play_set(_plugin->video, 0);
+
evas_object_del(_plugin->video);
+   if (_plugin->edje_frame) evas_object_del(_plugin->edje_frame);
free(_plugin);
 
ethumb_finished_callback_call(e, 1);
@@ -368,6 +380,7 @@ _thumb_generate(Ethumb *e)
Ethumb_Thumb_Format f;
double dv;
struct _emotion_plugin *_plugin = calloc(1, sizeof(struct _emotion_plugin));
+   const char *ffile, *fgroup, *fswallow;
 
o = emotion_object_add(ethumb_evas_get(e));
r = emotion_object_init(o, NULL);
@@ -413,6 +426,32 @@ _thumb_generate(Ethumb *e)
emotion_object_play_set(o, 1);
evas_object_show(o);
 
+   ethumb_frame_get(e, , , );
+   if (ffile && fgroup && fswallow)
+ {
+Evas_Object *ed = edje_object_add(ethumb_evas_get(e));
+if (!ed)
+  {
+ ERR("could not create edje frame object.");
+ return _plugin;
+  }
+if (!edje_object_file_set(ed, ffile, fgroup))
+  {
+ ERR("could not load frame theme.");
+ evas_object_del(ed);
+ return _plugin;
+  }
+edje_object_part_swallow(ed, fswallow, o);
+if (!edje_object_part_swallow_get(ed, fswallow))
+  {
+ ERR("could not swallow video to edje frame.");
+ evas_object_del(ed);
+ return _plugin;
+  }
+evas_object_show(ed);
+_plugin->edje_frame = ed;
+ }
+
return _plugin;
 }
 
@@ -423,6 +462,7 @@ _thumb_cancel(Ethumb *e EINA_UNUSED, void *data)
 
if (_plugin->ef) eet_close(_plugin->ef);
evas_object_del(_plugin->video);
+   if (_plugin->edje_frame) evas_object_del(_plugin->edje_frame);
free(_plugin);
 }
 

--