hermet pushed a commit to branch elementary-1.15.
http://git.enlightenment.org/core/elementary.git/commit/?id=de2ba979f7064ceccec4f65e6e99022594514e4c
commit de2ba979f7064ceccec4f65e6e99022594514e4c
Author: Shilpa Singh <shilpa.si...@samsung.com>
Date: Thu Oct 1 19:03:29 2015 +0900
elc_multibuttonentry: Memory leak fix.
Summary:
If item filters are appended and multibuttonentry is deleted, the
filter list is not freed causing leak
Signed-Off By: Kumar Navneet <k.navn...@samsung.com>
Signed-Off By: Shilpa Singh <shilpa.si...@samsung.com>
Test Plan:
append item filters and when multibuttonentry is deleted leak is
observed, run valgrind in this scenario.
Reviewers: Hermet, cedric, CHAN
Subscribers: navnbeet
Differential Revision: https://phab.enlightenment.org/D3118
---
src/lib/elc_multibuttonentry.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/lib/elc_multibuttonentry.c b/src/lib/elc_multibuttonentry.c
index fd608b1..f27ee33 100644
--- a/src/lib/elc_multibuttonentry.c
+++ b/src/lib/elc_multibuttonentry.c
@@ -1533,6 +1533,7 @@ EOLIAN static void
_elm_multibuttonentry_evas_object_smart_del(Eo *obj, Elm_Multibuttonentry_Data
*sd)
{
Elm_Object_Item *eo_item;
+ Elm_Multibuttonentry_Item_Filter *_item_filter = NULL;
EINA_LIST_FREE(sd->items, eo_item)
eo_del(eo_item);
@@ -1549,6 +1550,9 @@ _elm_multibuttonentry_evas_object_smart_del(Eo *obj,
Elm_Multibuttonentry_Data *
evas_object_del(sd->end);
ecore_timer_del(sd->longpress_timer);
+ EINA_LIST_FREE(sd->filter_list, _item_filter)
+ _filter_free(_item_filter);
+
eo_do_super(obj, MY_CLASS, evas_obj_smart_del());
}
--
