rimmed pushed a commit to branch master.
http://git.enlightenment.org/tools/eflete.git/commit/?id=c81b87ce550732dda71538cec29ae45ebe764d7c
commit c81b87ce550732dda71538cec29ae45ebe764d7c
Author: Andrii Kroitor <an.kroi...@samsung.com>
Date: Thu Dec 24 14:20:54 2015 +0200
refactor: add missing 'static' qualifiers
---
src/bin/ui/editors/colorclass_manager.c | 2 +-
src/bin/ui/editors/image_editor.c | 4 +-
src/bin/ui/editors/sound_editor.c | 2 +-
src/bin/ui/editors/style_editor.c | 4 +-
src/bin/ui/live_view/elementary/live_gengrid.c | 2 +-
src/bin/ui/live_view/elementary/live_genlist.c | 2 +-
src/bin/ui/live_view/elementary/live_naviframe.c | 6 +--
src/bin/ui/live_view/live_view_prop.c | 2 +-
src/bin/ui/popup.c | 2 +-
src/bin/ui/project_export.c | 4 +-
src/bin/ui/property_group.c | 10 ++---
src/bin/ui/shortcuts/shortcuts.c | 54 ++++++++++++------------
src/bin/ui/splash.c | 2 +-
src/bin/ui/tab_home_import_edc.c | 4 +-
src/bin/ui/tab_home_import_edj.c | 2 +-
src/bin/ui/tab_home_info.c | 2 +-
src/bin/ui/tab_home_new.c | 2 +-
src/bin/ui/tab_home_open.c | 2 +-
src/bin/ui/tabs.c | 2 +-
src/bin/ui/workspace/groupedit_calc.c | 2 +-
src/bin/ui/workspace/highlight.c | 2 +-
src/bin/ui/workspace/workspace.c | 2 +-
22 files changed, 58 insertions(+), 58 deletions(-)
diff --git a/src/bin/ui/editors/colorclass_manager.c
b/src/bin/ui/editors/colorclass_manager.c
index 63e2f2a..74278ab 100644
--- a/src/bin/ui/editors/colorclass_manager.c
+++ b/src/bin/ui/editors/colorclass_manager.c
@@ -461,7 +461,7 @@ _colorclass_main_layout_create(Colorclasses_Manager *edit)
elm_object_disabled_set(btn_apply, EINA_TRUE);
}
-Eina_Bool
+static Eina_Bool
_colorclass_manager_init(Colorclasses_Manager *edit)
{
Eina_List *l = NULL;
diff --git a/src/bin/ui/editors/image_editor.c
b/src/bin/ui/editors/image_editor.c
index ac236cc..42f6522 100644
--- a/src/bin/ui/editors/image_editor.c
+++ b/src/bin/ui/editors/image_editor.c
@@ -246,7 +246,7 @@ _image_editor_gengrid_item_data_create(Evas_Object
*edje_edit_obj,
return it;
}
-Eina_Bool
+static Eina_Bool
_on_image_done(void *data,
Evas_Object *obj __UNUSED__,
void *event_info)
@@ -454,7 +454,7 @@ _image_editor_search_field_create(Evas_Object *parent)
return entry;
}
-Eina_Bool
+static Eina_Bool
_image_editor_init(Image_Editor *img_edit)
{
Eina_List *l = NULL;
diff --git a/src/bin/ui/editors/sound_editor.c
b/src/bin/ui/editors/sound_editor.c
index 6aeca4e..124b43b 100644
--- a/src/bin/ui/editors/sound_editor.c
+++ b/src/bin/ui/editors/sound_editor.c
@@ -113,7 +113,7 @@ _grid_del(void *data,
free(it);
}
-Eina_Stringshare *
+static Eina_Stringshare *
_sound_format_get(Eina_Stringshare *snd_src)
{
Eina_Stringshare *type;
diff --git a/src/bin/ui/editors/style_editor.c
b/src/bin/ui/editors/style_editor.c
index a23758e..9b6b876 100644
--- a/src/bin/ui/editors/style_editor.c
+++ b/src/bin/ui/editors/style_editor.c
@@ -767,7 +767,7 @@ _on_clicked_double(void *data __UNUSED__,
}
/* Creating the view of the mwin!!! */
-Evas_Object *
+static Evas_Object *
_form_right_side(Style_Editor *style_edit)
{
Elm_Object_Item *glit_style;
@@ -894,7 +894,7 @@ _change_bg_cb(void *data,
elm_object_part_content_set(style_edit->entry_prev, "background", bg);
}
-Evas_Object*
+static Evas_Object*
_add_box_bg(Style_Editor *style_edit)
{
Evas_Object *box_bg, *image_bg, *radio_group, *radio;
diff --git a/src/bin/ui/live_view/elementary/live_gengrid.c
b/src/bin/ui/live_view/elementary/live_gengrid.c
index 65993d9..b6901d0 100644
--- a/src/bin/ui/live_view/elementary/live_gengrid.c
+++ b/src/bin/ui/live_view/elementary/live_gengrid.c
@@ -139,7 +139,7 @@ _gengrid_send_signal(void *data,
/*********** GEN GRID CREATING FUNCTIONS ****************/
-char *
+static char *
_grid_text_get(void *data,
Evas_Object *obj,
const char *part)
diff --git a/src/bin/ui/live_view/elementary/live_genlist.c
b/src/bin/ui/live_view/elementary/live_genlist.c
index 8405395..91d6f14 100644
--- a/src/bin/ui/live_view/elementary/live_genlist.c
+++ b/src/bin/ui/live_view/elementary/live_genlist.c
@@ -138,7 +138,7 @@ _genlist_send_signal(void *data,
}
/*********** GEN LIST CREATING FUNCTIONS ****************/
-char *
+static char *
_glist_text_get(void *data,
Evas_Object *obj,
const char *part)
diff --git a/src/bin/ui/live_view/elementary/live_naviframe.c
b/src/bin/ui/live_view/elementary/live_naviframe.c
index 742ef89..b924398 100644
--- a/src/bin/ui/live_view/elementary/live_naviframe.c
+++ b/src/bin/ui/live_view/elementary/live_naviframe.c
@@ -21,7 +21,7 @@
static const char *item_style_name = NULL;
-void
+static void
_pop_page_cb(void *data, Evas_Object *obj __UNUSED__, void *event_info
__UNUSED__)
{
Evas_Object *nf = data;
@@ -31,7 +31,7 @@ _pop_page_cb(void *data, Evas_Object *obj __UNUSED__, void
*event_info __UNUSED_
elm_naviframe_item_pop(nf);
}
-void
+static void
_next_page_cb(void *data, Evas_Object *obj __UNUSED__, void *event_info
__UNUSED__)
{
Prop_Data *pd = (Prop_Data *)data;
@@ -54,7 +54,7 @@ _next_page_cb(void *data, Evas_Object *obj __UNUSED__, void
*event_info __UNUSED
eina_stringshare_del(find_part);
}
-void
+static void
_prev_page_cb(void *data, Evas_Object *obj __UNUSED__, void *event_info
__UNUSED__)
{
Prop_Data *pd = (Prop_Data *)data;
diff --git a/src/bin/ui/live_view/live_view_prop.c
b/src/bin/ui/live_view/live_view_prop.c
index 324b4e9..6f59c6c 100644
--- a/src/bin/ui/live_view/live_view_prop.c
+++ b/src/bin/ui/live_view/live_view_prop.c
@@ -167,7 +167,7 @@ _default_text_hash_free_cb(void *data)
eina_stringshare_del(data);
}
-Eina_Bool
+static Eina_Bool
_live_view_property_load(Evas_Object *property,
Live_View *live,
Group *group,
diff --git a/src/bin/ui/popup.c b/src/bin/ui/popup.c
index e905fb6..f51df47 100644
--- a/src/bin/ui/popup.c
+++ b/src/bin/ui/popup.c
@@ -452,7 +452,7 @@ _grid_del(void *data,
free(it);
}
-Eina_Bool
+static Eina_Bool
_image_gengrid_init(Helper_Data *helper_data)
{
Eina_List *l = NULL;
diff --git a/src/bin/ui/project_export.c b/src/bin/ui/project_export.c
index 3d69510..26e5d99 100644
--- a/src/bin/ui/project_export.c
+++ b/src/bin/ui/project_export.c
@@ -39,7 +39,7 @@ _export_develop_setup(void *data, Splash_Status status
__UNUSED__)
return true;
}
-Eina_Bool
+static Eina_Bool
_export_dev(void *data __UNUSED__,
Evas_Object *obj, /* this is fileselector from popup */
void *event_info)
@@ -91,7 +91,7 @@ _export_source_code_setup(void *data, Splash_Status status
__UNUSED__)
return true;
}
-Eina_Bool
+static Eina_Bool
_export_source_code(void *data __UNUSED__,
Evas_Object *obj __UNUSED__, /* this is fileselector from
popup */
void *event_info)
diff --git a/src/bin/ui/property_group.c b/src/bin/ui/property_group.c
index a20fe1a..cf168f3 100644
--- a/src/bin/ui/property_group.c
+++ b/src/bin/ui/property_group.c
@@ -2851,7 +2851,7 @@ ui_property_state_textblock_unset(Evas_Object *property)
#define pd_image pd->attributes.state_image
-Eina_Bool
+static Eina_Bool
_on_image_editor_done(void *data,
Evas_Object *obj __UNUSED__,
void *event_info)
@@ -2939,7 +2939,7 @@ _del_tween_image(void *data,
history_change_add(pd->group->history, change);
}
-Eina_Bool
+static Eina_Bool
_on_image_editor_tween_done(void *data,
Evas_Object *obj __UNUSED__,
void *event_info)
@@ -3075,8 +3075,8 @@ _tween_image_moved(Evas_Object *data,
//project_changed(false);
}
-Evas_Object *
-prop_item_state_image_tween_add(Evas_Object *box, Group_Prop_Data *pd)
+static Evas_Object *
+_prop_item_state_image_tween_add(Evas_Object *box, Group_Prop_Data *pd)
{
Evas_Object *tween_frame, *tween_list, *item, *button, *icon;
Eina_List *images_list, *l;
@@ -3326,7 +3326,7 @@ ui_property_state_image_set(Evas_Object *property)
item = prop_state_image_border_fill_add(box, pd);
elm_box_pack_end(box, item);
- pd_image.tween = prop_item_state_image_tween_add(box, pd);
+ pd_image.tween = _prop_item_state_image_tween_add(box, pd);
elm_box_pack_end(box, pd_image.tween);
elm_box_pack_end(prop_box, image_frame);
diff --git a/src/bin/ui/shortcuts/shortcuts.c b/src/bin/ui/shortcuts/shortcuts.c
index 561f390..53a8fde 100644
--- a/src/bin/ui/shortcuts/shortcuts.c
+++ b/src/bin/ui/shortcuts/shortcuts.c
@@ -153,7 +153,7 @@ _random_name_generate(char *part_name, unsigned int length)
project_changed(true);
#define PART_ADD(TYPE, FUNC) \
-Eina_Bool \
+static Eina_Bool \
_##FUNC##_part_add_cb(void) \
{ \
PART_FUNCTIONALITY(TYPE, NULL) \
@@ -256,7 +256,7 @@ _item_delete_cb(void)
return true;
}
-Eina_Bool
+static Eina_Bool
_separate_mode_change_cb(void)
{
Evas_Object *workspace = tabs_current_workspace_get();
@@ -276,7 +276,7 @@ _separate_mode_change_cb(void)
}
TODO("Please remake this shortcut since there are no TABS anymore")
-Eina_Bool
+static Eina_Bool
_new_style_create_cb(void)
{
/*
@@ -315,10 +315,10 @@ _new_style_create_cb(void)
}
TODO("Please remake this shortcut since there are no TABS anymore")
-Eina_Bool
+/*
+static Eina_Bool
_style_delete_cb(void)
{
-/*
SKIP_IN_ENVENTOR_MODE
Elm_Object_Item *glit = NULL;
Style *_style = NULL;
@@ -346,11 +346,11 @@ _style_delete_cb(void)
if (_style->__type != WIDGET)
evas_object_smart_callback_call(ap.block.left_top, "wl,style,del",
NULL);
}
-*/
return true;
}
+*/
-Eina_Bool
+static Eina_Bool
_new_theme_cb(void)
{
tabs_menu_tab_open(TAB_HOME_NEW_PROJECT);
@@ -368,28 +368,28 @@ _open_edc_cb(void)
}
*/
-Eina_Bool
+static Eina_Bool
_open_project_cb(void)
{
tabs_menu_tab_open(TAB_HOME_OPEN_PROJECT);
return true;
}
-Eina_Bool
+static Eina_Bool
_import_edj_cb(void)
{
tabs_menu_tab_open(TAB_HOME_IMPORT_EDJ);
return true;
}
-Eina_Bool
+static Eina_Bool
_save_cb(void)
{
project_save();
return true;
}
-Eina_Bool
+static Eina_Bool
_save_as_cb(void)
{
if (!ap.project) return false;
@@ -397,7 +397,7 @@ _save_as_cb(void)
return true;
}
-Eina_Bool
+static Eina_Bool
_export_cb(void)
{
if (!ap.project) return false;
@@ -406,7 +406,7 @@ _export_cb(void)
}
TODO("Remove? Or modify since we don't have EWE_TABS anymore?")
-Eina_Bool
+static Eina_Bool
_visual_tab_cb(void)
{
/*
@@ -421,7 +421,7 @@ _visual_tab_cb(void)
}
TODO("Remove? Or modify since we don't have EWE_TABS anymore?")
-Eina_Bool
+static Eina_Bool
_code_tab_cb(void)
{
/*
@@ -436,14 +436,14 @@ _code_tab_cb(void)
return true;
}
-Eina_Bool
+static Eina_Bool
_quit_cb(void)
{
ui_main_window_del();
return true;
}
/* close currently opened group tab */
-Eina_Bool
+static Eina_Bool
_close_tab_cb(void)
{
if (!ap.project) return false;
@@ -451,7 +451,7 @@ _close_tab_cb(void)
return true;
}
-Eina_Bool
+static Eina_Bool
_style_editor_open_cb(void)
{
if (ap.project)
@@ -459,7 +459,7 @@ _style_editor_open_cb(void)
return true;
}
-Eina_Bool
+static Eina_Bool
_image_editor_open_cb(void)
{
if (ap.project)
@@ -467,7 +467,7 @@ _image_editor_open_cb(void)
return true;
}
-Eina_Bool
+static Eina_Bool
_sound_editor_open_cb(void)
{
if (ap.project)
@@ -475,7 +475,7 @@ _sound_editor_open_cb(void)
return true;
}
-Eina_Bool
+static Eina_Bool
_colorclass_manager_open_cb(void)
{
if (ap.project)
@@ -483,7 +483,7 @@ _colorclass_manager_open_cb(void)
return true;
}
-Eina_Bool
+static Eina_Bool
_animator_open_cb(void)
{
if ((ap.project) && (tabs_current_group_get()))
@@ -491,7 +491,7 @@ _animator_open_cb(void)
return true;
}
-Eina_Bool
+static Eina_Bool
_highlight_align_show_switch_cb(void)
{
assert(ap.project != NULL);
@@ -507,7 +507,7 @@ _highlight_align_show_switch_cb(void)
return true;
}
-Eina_Bool
+static Eina_Bool
_object_area_show_switch_cb(void)
{
Evas_Object *workspace = tabs_current_workspace_get();
@@ -519,7 +519,7 @@ _object_area_show_switch_cb(void)
return true;
}
-Eina_Bool
+static Eina_Bool
_zoom_in_cb(void)
{
Evas_Object *workspace = tabs_current_workspace_get();
@@ -532,7 +532,7 @@ _zoom_in_cb(void)
return true;
}
-Eina_Bool
+static Eina_Bool
_zoom_out_cb(void)
{
Evas_Object *workspace = tabs_current_workspace_get();
@@ -545,7 +545,7 @@ _zoom_out_cb(void)
return true;
}
-Eina_Bool
+static Eina_Bool
_undo_cb(void)
{
SKIP_IN_ENVENTOR_MODE
@@ -556,7 +556,7 @@ _undo_cb(void)
TODO("Implement undo shortcut");
}
-Eina_Bool
+static Eina_Bool
_redo_cb(void)
{
SKIP_IN_ENVENTOR_MODE
diff --git a/src/bin/ui/splash.c b/src/bin/ui/splash.c
index 066d042..c0043e8 100644
--- a/src/bin/ui/splash.c
+++ b/src/bin/ui/splash.c
@@ -31,7 +31,7 @@ struct _Splash_Data
typedef struct _Splash_Data Splash_Data;
-Splash_Data sdata;
+static Splash_Data sdata;
static void
_on_teardown(void *data __UNUSED__,
diff --git a/src/bin/ui/tab_home_import_edc.c b/src/bin/ui/tab_home_import_edc.c
index 74d4df8..6e5ee76 100644
--- a/src/bin/ui/tab_home_import_edc.c
+++ b/src/bin/ui/tab_home_import_edc.c
@@ -54,7 +54,7 @@ struct _Tab_Home_Edc
};
typedef struct _Tab_Home_Edc Tab_Home_Edc;
-Tab_Home_Edc tab_edc;
+static Tab_Home_Edc tab_edc;
static void
_img_dir_add(void *data, Evas_Object *obj, void *event_info);
@@ -346,7 +346,7 @@ _dirs_cleanup(Eina_List *list, Evas_Smart_Cb del_func)
}
}
-Eina_Bool
+static Eina_Bool
_progress_print(void *data, Eina_Stringshare *progress_string)
{
eina_strbuf_append_printf(tab_edc.log, "%s<br>", progress_string);
diff --git a/src/bin/ui/tab_home_import_edj.c b/src/bin/ui/tab_home_import_edj.c
index 63e6d14..d65d6f3 100644
--- a/src/bin/ui/tab_home_import_edj.c
+++ b/src/bin/ui/tab_home_import_edj.c
@@ -38,7 +38,7 @@ struct _Tab_Home_Edj
};
typedef struct _Tab_Home_Edj Tab_Home_Edj;
-Tab_Home_Edj tab_edj;
+static Tab_Home_Edj tab_edj;
static void
_progress_end(void *data, PM_Project_Result result)
diff --git a/src/bin/ui/tab_home_info.c b/src/bin/ui/tab_home_info.c
index 569a617..fc87700 100644
--- a/src/bin/ui/tab_home_info.c
+++ b/src/bin/ui/tab_home_info.c
@@ -29,7 +29,7 @@ struct _Tab_Home_Info
Meta_Data_Controls meta;
};
typedef struct _Tab_Home_Info Tab_Home_Info;
-Tab_Home_Info tab_info;
+static Tab_Home_Info tab_info;
#define PROJECT_INFO \
"<linegap=6>" \
diff --git a/src/bin/ui/tab_home_new.c b/src/bin/ui/tab_home_new.c
index 9725cd1..4f18f92 100644
--- a/src/bin/ui/tab_home_new.c
+++ b/src/bin/ui/tab_home_new.c
@@ -107,7 +107,7 @@ struct _Tab_Home_New
};
typedef struct _Tab_Home_New Tab_Home_New;
-Tab_Home_New tab_new;
+static Tab_Home_New tab_new;
/* CHECK ALL AND NOT ALL */
static void
diff --git a/src/bin/ui/tab_home_open.c b/src/bin/ui/tab_home_open.c
index 6452dcf..6f45cba 100644
--- a/src/bin/ui/tab_home_open.c
+++ b/src/bin/ui/tab_home_open.c
@@ -27,7 +27,7 @@ struct _Tab_Home_Open {
};
typedef struct _Tab_Home_Open Tab_Home_Open;
-Tab_Home_Open tab;
+static Tab_Home_Open tab;
static Eina_Bool
_eflete_filter(const char *path,
diff --git a/src/bin/ui/tabs.c b/src/bin/ui/tabs.c
index b7f949f..34348d3 100644
--- a/src/bin/ui/tabs.c
+++ b/src/bin/ui/tabs.c
@@ -75,7 +75,7 @@ struct _Tabs {
typedef struct _Tabs Tabs;
-Tabs tabs;
+static Tabs tabs;
static void
_content_unset(void)
diff --git a/src/bin/ui/workspace/groupedit_calc.c
b/src/bin/ui/workspace/groupedit_calc.c
index e3a5461..c2f7bf7 100644
--- a/src/bin/ui/workspace/groupedit_calc.c
+++ b/src/bin/ui/workspace/groupedit_calc.c
@@ -542,7 +542,7 @@ _part_calc(Ws_Groupedit_Smart_Data *sd, Groupedit_Part *gp)
}
}
-Eina_Bool
+static Eina_Bool
_part_update(Ws_Groupedit_Smart_Data *sd, Groupedit_Part *gp)
{
Eina_Stringshare *str;
diff --git a/src/bin/ui/workspace/highlight.c b/src/bin/ui/workspace/highlight.c
index 3b37fcd..b320f20 100644
--- a/src/bin/ui/workspace/highlight.c
+++ b/src/bin/ui/workspace/highlight.c
@@ -486,7 +486,7 @@ _handler_mouse_out_cb(void *data,
-Handler *
+static Handler *
_handler_object_add(Evas_Object *parent,
Highlight *highlight,
Handler_Type descr,
diff --git a/src/bin/ui/workspace/workspace.c b/src/bin/ui/workspace/workspace.c
index dc7b3f5..b50b7e2 100644
--- a/src/bin/ui/workspace/workspace.c
+++ b/src/bin/ui/workspace/workspace.c
@@ -574,7 +574,7 @@ _sc_smart_drag_x_cb(void *data ,
}
}
-void
+static void
_sc_smart_move_cb(void *data,
Evas_Object *obj __UNUSED__,
void *event_info __UNUSED__)
--
