[PATCH 04/10] t4018: convert perl pattern tests to the new infrastructure

There is one subtlety: The old test case 'perl pattern gets full line of POD header' does not have its own new test case, but the feature is tested nevertheless by placing the RIGHT tag at the end of the expected hunk header in t4018/perl-skip-sub-in-pod. Signed-off-by: Johannes Sixt

[PATCH 09/10] t4018: test cases showing that the cpp pattern misses many anchor points

Most of the tests show C++ code, but there is also a union definition and a GNU style function definition that are not recognized. Signed-off-by: Johannes Sixt j...@kdbg.org --- t/t4018/cpp-class-constructor | 5 + t/t4018/cpp-class-constructor-mem-init | 6 ++

[PATCH 07/10] t4018: reduce test files for pattern compilation tests

All test cases that need a file with specific text patterns have been converted to utilize texts in the t4018/ directory. The remaining tests in the test script deal only with the validity of the regular expressions. These tests do not depend on the contents of files that 'git diff' is invoked on.

[PATCH 08/10] t4018: test cases for the built-in cpp pattern

A later patch changes the built-in cpp pattern. These test cases demonstrate aspects of the pattern that we do not want to change. Signed-off-by: Johannes Sixt j...@kdbg.org --- t/t4018/cpp-c++-function | 4 t/t4018/cpp-class-definition | 4

[PATCH 06/10] t4018: convert custom pattern test to the new infrastructure

For the test case matches to end of line, extend the pattern by a few wildcards so that the pattern captures the RIGHT token, which is needed for verification, without mentioning it in the pattern. Signed-off-by: Johannes Sixt j...@kdbg.org --- t/t4018-diff-funcname.sh | 40

[PATCH 10/10] userdiff: have 'cpp' hunk header pattern catch more C++ anchor points

The hunk header pattern 'cpp' is intended for C and C++ source code, but it is actually not particularly useful for the latter, and even misses some use-cases for the former. The parts of the pattern have the following flaws: - The first part matches an identifier followed immediately by a colon

Re: [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()

On 03/21/2014 06:09 PM, Junio C Hamano wrote: Eric Sunshine sunsh...@sunshineco.com writes: Sorry, you're right about message[0] case not being a crasher (though the assert() still seems overkill). Assert() often becomes no-op in production build. I think this may be an indication that

Re: [PATCH 03/12] t: drop useless sane_unset GIT_* calls

Jeff King p...@peff.net writes: Several test scripts manually unset GIT_CONFIG and other GIT_* variables. These are generally taken care of for us by test-lib.sh already. Unsetting these is not only useless, but can be confusing to a reader, who may wonder why some tests in a script unset

Re: File extension conflict when working with git and latex

On 03/21/2014 07:32 PM, Junio C Hamano wrote: Matthias Beyer m...@beyermatthias.de writes: I know, I can fix this by fixing the clean task in my Makefile. But maybe someone somewhere on this world doesn't know the git internals as good as me (and, of course, my coworker). Is there _any

Re: [PATCH 04/12] t: stop using GIT_CONFIG to cross repo boundaries

Jeff King p...@peff.net writes: Some tests want to check or set config in another repository. E.g., t1000 creates repositories and makes sure that their core.bare and core.worktree settings are what we expect. We can do this with: GIT_CONFIG=$repo/.git/config git config ... but it

Re: [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()

On Fri, Mar 21, 2014 at 5:13 PM, Michael Haggerty mhag...@alum.mit.edu wrote: On 03/21/2014 06:09 PM, Junio C Hamano wrote: Eric Sunshine sunsh...@sunshineco.com writes: Sorry, you're right about message[0] case not being a crasher (though the assert() still seems overkill). Assert() often

Re: What's cooking in git.git (Mar 2014, #04; Thu, 20)

Junio C Hamano gits...@pobox.com writes: Torsten Bögershausen tbo...@web.de writes: On 03/20/2014 10:09 PM, Junio C Hamano wrote: * ap/remote-hg-skip-null-bookmarks (2014-03-19) 1 commit - remote-hg: do not fail on invalid bookmarks Will merge to 'next'. Hmm, am I the only one who has

Re: [PATCH v3] remote-hg: do not fail on invalid bookmarks

Hi Torsten, On 21.03.2014, at 21:47, Torsten Bögershausen tbo...@web.de wrote: On 2014-03-21 12.36, Max Horn wrote: All tests passed :-), Excellent. thanks from my side. comments inline, some are debatable Thanks for having a close look and for the constructive feedback! Unfortunately, I

Re: [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()

On 03/21/2014 10:33 PM, Eric Sunshine wrote: On Fri, Mar 21, 2014 at 5:13 PM, Michael Haggerty mhag...@alum.mit.edu wrote: On 03/21/2014 06:09 PM, Junio C Hamano wrote: Assert() often becomes no-op in production build. I think this may be an indication that table-driven may not be as good

Re: [PATCH 03/10] t4018: an infrastructure to test hunk headers

Johannes Sixt j...@kdbg.org writes: Add an infrastructure that simplifies adding new tests of the hunk header regular expressions. To add new tests, a file with the syntax to test can be dropped in the directory t4018. The README file explains how a test file must contain; s/how/what/, or

Re: [PATCH 00/10] userdiff: cpp pattern simplification and test framework

Thanks; will replace jk/diff-funcname-cpp-regex with this series. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] remote-hg: do not fail on invalid bookmarks

Max Horn m...@quendi.de writes: Hi Torsten, On 21.03.2014, at 21:47, Torsten Bögershausen tbo...@web.de wrote: On 2014-03-21 12.36, Max Horn wrote: All tests passed :-), Excellent. thanks from my side. comments inline, some are debatable Thanks for having a close look and for the

Re: [PATCH] builtin/apply.c: use iswspace() to detect line-ending-like chars

[Please reply on-list to review comments. Other people may learn from the discussion or have comments of their own.] On Fri, Mar 21, 2014 at 6:00 PM, George Papanikolaou g3orge@gmail.com wrote: On Fri, Mar 21, 2014 at 4:48 AM, Eric Sunshine sunsh...@sunshineco.com wrote: Did you verify

with reuse-delta patches, fetching with bitmaps segfaults due to possibly incomplete bitmap traverse

Hi all, At Facebook we've found that fetch speed is a bottleneck for our Git repos, so we've been looking to deploy bitmaps to speed up fetches. We've been trying out git-next with the top two patches from https://github.com/peff/git/commits/jk/bitmap-reuse-delta, but the following is

<    1   2