[PATCH 18/19] t/t9814-git-p4-rename.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- t/t9814-git-p4-

[PATCH 08/19] git-mergetool.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- git-mergetool.s

[PATCH 05/19] contrib/examples/git-repack.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- contrib/example

[PATCH 19/19] t/test-lib-functions.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- t/test-lib-func

[PATCH 12/19] t/t0026-eol-config.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- t/t0026-eol-con

[PATCH 10/19] git-submodule.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- git-submodule.s

[PATCH 13/19] t/t4102-apply-rename.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- t/t4102-apply-r

[PATCH 17/19] t/t5538-push-shallow.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- t/t5538-push-sh

[PATCH 04/19] contrib/examples/git-merge.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- contrib/example

[PATCH 01/19] check_bindir: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- check_bindir |

[PATCH 07/19] git-bisect.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- git-bisect.sh |

[PATCH 06/19] contrib/examples/git-resolve.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- contrib/example

[PATCH 02/19] contrib/examples/git-clone.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- contrib/example

[PATCH 00/19] convert test -a/-o to && and || patch series

2014-05-20 Thread Elia Pinto
These patch series convert test -a/-o to && and ||. This is the second version. Changes: - Modified commit comment based on Jonathan Nieder suggestions (was "don't use the -a or -o option with the test command") - Modified patch on git-submodule.sh based on Jonathan Nieder suggestions Elia

[PATCH 09/19] git-rebase--interactive.sh: convert test -a/-o to && and ||

2014-05-20 Thread Elia Pinto
The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- git-rebase--int

[PATCH 2/2] remote prune: optimize "dangling symref" check/warning

2014-05-20 Thread Jens Lindström
When 'git remote prune' was used to delete many refs in a repository with many refs, a lot of time was spent checking for (now) dangling symbolic refs pointing to the deleted ref, since warn_dangling_symref() was once per deleted ref to check all other refs in the repository. Avoid this using the

[PATCH 1/2] remote: defer repacking packed-refs when deleting refs

2014-05-20 Thread Jens Lindström
When 'git remote rm' or 'git remote prune' were used in a repository with many refs, and needed to delete many refs, a lot of time was spent deleting those refs since for each deleted ref, repack_without_refs() was called to rewrite packed-refs without just that deleted ref. To avoid this, defer t

[PATCH 0/2] remote: optimize rm/prune ref deletion

2014-05-20 Thread Jens Lindström
At work, we have some shared repositories with far too many refs in them, which causes various issues, performance and otherwise. We plan to move most of the refs out of them, but for that to help users that have already fetched all the refs into their local repositories, those users should want t

Re: [msysGit] Re: [PATCH/RFC] send-pack.c: Allow to disable side-band-64k

2014-05-20 Thread Erik Faye-Lund
On Tue, May 20, 2014 at 10:46 AM, Thomas Braun wrote: > Am 19.05.2014 22:29, schrieb Erik Faye-Lund: >>> [...] >>> Would we need to wrap both ends, shouldn't wrapping only reading be >>> good enough to prevent deadlocking? >>> >>> compat/poll/poll.c already contains a function called IsSocketHand

Re: [msysGit] Re: [PATCH/RFC] send-pack.c: Allow to disable side-band-64k

2014-05-20 Thread Thomas Braun
Am 19.05.2014 22:29, schrieb Erik Faye-Lund: >> [...] >> Would we need to wrap both ends, shouldn't wrapping only reading be >> good enough to prevent deadlocking? >> >> compat/poll/poll.c already contains a function called IsSocketHandle >> that is able to tell if a HANDLE points to a socket or n

Re: [PATCH v5] format-patch --signature-file

2014-05-20 Thread Jeff King
On Tue, May 20, 2014 at 01:00:06AM -0700, Jeremiah Mahler wrote: > Added option that allows a signature file to be used with format-patch > so that signatures with newlines and other special characters can be > easily included. > > $ git format-patch --signature-file ~/.signature -1 > > The co

[PATCH v5] format-patch --signature-file

2014-05-20 Thread Jeremiah Mahler
Added option that allows a signature file to be used with format-patch so that signatures with newlines and other special characters can be easily included. $ git format-patch --signature-file ~/.signature -1 The config variable format.signaturefile is also provided so that it can be added by d

[PATCH v5] format-patch --signature-file

2014-05-20 Thread Jeremiah Mahler
v5 of patch to add format-patch --signature-file option. This revision includes more suggestions from Jeff King and Junio C Hamano: - Use git_config_pathname instead of git_config_string for ~ expansion. - Eliminated head/tail --lines which is not POSIX compliant. Replaced with sed equi

[PATCH v2] rebase -i: test "Nothing to do" case with autostash

2014-05-20 Thread Matthieu Moy
Signed-off-by: Matthieu Moy --- Eric Sunshine writes: > Simpler (replace above two lines): > > test_set_editor "$(pwd)/abort-editor.sh" && Indeed. And I had debug statements left. Hopefully, this after-coffee-v2 will be clear enough and correct ;-). t/t3420-rebase-autostash.sh | 15

Re: [PATCH] rebase -i: test "Nothing to do" case with autostash

2014-05-20 Thread Eric Sunshine
On Tue, May 20, 2014 at 2:55 AM, Matthieu Moy wrote: > Signed-off-by: Matthieu Moy > --- > Ram's patch lacks a test. Here it is. Fails without Ram's patch, and > passes with it. > > Can be squashed into Ram's patch. > > t/t3420-rebase-autostash.sh | 17 + > 1 file changed, 17 ins

<    1   2