Re: [PATCH v2 0/25] prune-safety

2014-10-18 Thread Jeff King
On Thu, Oct 16, 2014 at 05:39:18PM -0400, Jeff King wrote: @@ -301,6 +297,14 @@ static struct commit *handle_commit(struct rev_info *revs, die(bad object %s, sha1_to_hex(tag-tagged-sha1)); } object-flags |= flags; + /* +

[PATCH v5] Handle atexit list internaly for unthreaded builds

2014-10-18 Thread Etienne Buira
Wrap atexit()s calls on unthreaded builds to handle callback list internally. This is needed because on unthreaded builds, asyncs inherits parent's atexit() list, that gets run as soon as the async exit()s (and again at the end of async's parent process). That led to remove temporary files too

Re: [PATCH] git-completion.bash - avoid excruciatingly slow ref completion on Cygwin

2014-10-18 Thread Tay Ray Chuan
On Sat, Oct 11, 2014 at 11:51 PM, Mark Levedahl mleved...@gmail.com wrote: $git checkout tab was taking about 3.5 seconds to respond on one repository having four remotes with about 100 total refs (measured on Cygwin). All of the time was being claimed in git for-each-ref to do its work.

Re: Stop prepending /usr/bin to hooks PATH, or document it very clearly

2014-10-18 Thread Andreas Krey
On Fri, 17 Oct 2014 13:25:42 +, Ciro Santilli wrote: ... The problem is that the `/usr/bin` breaks interpreter version manager systems like RVM, rbenv, virtualenv, etc. since people will write hooks like: #!/usr/bin/env ruby and the `/usr/bin` ruby will get run instead of the

Re: Stop prepending /usr/bin to hooks PATH, or document it very clearly

2014-10-18 Thread Ciro Santilli
On Sat, Oct 18, 2014 at 4:49 PM, Andreas Krey a.k...@gmx.de wrote: On Fri, 17 Oct 2014 13:25:42 +, Ciro Santilli wrote: ... The problem is that the `/usr/bin` breaks interpreter version manager systems like RVM, rbenv, virtualenv, etc. since people will write hooks like:

[PATCH] revision: remove definition of unused 'add_object' function

2014-10-18 Thread Ramsay Jones
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Jeff, I noticed that your 'jk/prune-mtime' branch removes the last caller of the add_object() function; specifically commit 5f78a431a (reachable: use traverse_commit_list instead of custom walk, 15-10-2014). If you need to re-roll

[PATCH] object: make add_object_array_with_mode a static function

2014-10-18 Thread Ramsay Jones
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk --- Hi Jeff, I noticed that your 'jk/prune-mtime' branch also removes the only call to the add_object_array_with_mode() function outside of the object.c file; specifically commit 75ac69fa (traverse_commit_list: support pending blobs/trees

Re: git-svn performance

2014-10-18 Thread Eric Wong
Fabian Schmied fabian.schm...@gmail.com wrote: Hi, I'm currently migrating an SVN repository to Git using git-svn (Git for Windows 1.8.3-preview20130601), and I'm experiencing severe performance problems with git svn fetch. Commits to the SVN trunk are fetched very fast (a few seconds or so

Re: Specifying account profile in MSMTP

2014-10-18 Thread Eric Wong
Robert Dailey rcdailey.li...@gmail.com wrote: Hey guys, I'm using MSMTP to define 2 accounts: Work email and personal email. If I send patches via email through Git at work, I want to use my work SMTP server and account information. Likewise at home for personal projects, I want to use my

Re: [PATCH] revision: remove definition of unused 'add_object' function

2014-10-18 Thread Jeff King
On Sat, Oct 18, 2014 at 10:36:12PM +0100, Ramsay Jones wrote: I noticed that your 'jk/prune-mtime' branch removes the last caller of the add_object() function; specifically commit 5f78a431a (reachable: use traverse_commit_list instead of custom walk, 15-10-2014). Thanks. I usually rely on the

Re: [PATCH] object: make add_object_array_with_mode a static function

2014-10-18 Thread Jeff King
On Sun, Oct 19, 2014 at 12:19:07AM +0100, Ramsay Jones wrote: I noticed that your 'jk/prune-mtime' branch also removes the only call to the add_object_array_with_mode() function outside of the object.c file; specifically commit 75ac69fa (traverse_commit_list: support pending blobs/trees with

Re: git-svn performance

2014-10-18 Thread Eric Wong
Eric Wong normalper...@yhbt.net wrote: Hin-Tak (Cc-ed) reported good improvements with them, but also a large memory increase: This might reduce the pathname and internal hash overheads: 8--- From: Eric Wong normalper...@yhbt.net Date: Sun, 19 Oct

Re: git-svn performance

2014-10-18 Thread Eric Wong
Eric Wong normalper...@yhbt.net wrote: This reduces hash lookups for looking up cache data and will simplify tying data to disk in the next commit. I considered the following, but GDBM might not be readily available on non-POSIX platforms. I think the other problem is the existing caches are

Re: git svn's performance issue and strange pauses, and other thing

2014-10-18 Thread Eric Wong
Hin-Tak Leung ht...@users.sourceforge.net wrote: The new clone has: -- $ ls -ltr .git/svn/.caches/ total 144788 -rw-rw-r--. 1 Hin-Tak Hin-Tak 1166138 Oct 7 13:44 lookup_svn_merge.yaml -rw-rw-r--. 1 Hin-Tak Hin-Tak 72849741 Oct 7 13:48 check_cherry_pick.yaml -rw-rw-r--. 1 Hin-Tak