On Mon, Dec 21, 2015 at 02:06:59AM -0500, Eric Sunshine wrote:
> On Mon, Dec 21, 2015 at 1:19 AM, Jeff King wrote:
> > The main entry point to the pack-revindex code is
> > find_pack_revindex(). This calls revindex_for_pack(), which
> > lazily computes and caches the revindex for the pack.
> >
>
On Mon, Dec 21, 2015 at 1:19 AM, Jeff King wrote:
> The main entry point to the pack-revindex code is
> find_pack_revindex(). This calls revindex_for_pack(), which
> lazily computes and caches the revindex for the pack.
>
> We store the cache in a very simple hash table. It's created
> by init_pac
On Sun, Dec 20, 2015 at 05:31:48PM -0800, Junio C Hamano wrote:
> Actually, we do not even _need_ a sharedness for this ephemeral
> file. The additional "adjust-shared-perm" is merely a workaround
> for the fact the next person cannot write into it when it is left
> behind, and because we do not
A pack_revindex struct has two elements: the revindex
entries themselves, and a pointer to the packed_git. We need
both to do lookups, because only the latter knows things
like the number of objects in the pack.
Now that packed_git contains the pack_revindex struct it's
just as easy to pass around
The main entry point to the pack-revindex code is
find_pack_revindex(). This calls revindex_for_pack(), which
lazily computes and caches the revindex for the pack.
We store the cache in a very simple hash table. It's created
by init_pack_revindex(), which inserts an entry for every
packfile we kno
Jeff King writes:
> So I don't have any real problem with this, but I suspect it's just the
> tip of the iceberg. We might want something like:
>
> FILE *fopen_shared(const char *path, const char *mode)
> {
> FILE *ret = fopen(path, mode);
> if (!ret)
> return NULL;
I've been looking over the git source tree to see if there is some place where
I can
contribute. It appears that there are some suggestions at the bottom of
the userguide. Does anyone have other places that they would like
worked on first? If not I will start with one of the suggestions.
On Fri, Dec 18, 2015 at 8:35 AM, Cameron Esfahani wrote:
> I have git project checked out at ~/llvm. Inside of there, inside of a
> “tools” directory, I have another project checked out as “lldb”:
>
> ~/llvm/tools/lldb
>
> I wrote an alias which would help me update all my projects:
>
>
From: Lars Schneider
diff to v2:
* remove workaround tests as suggested by Peff [1]
* fix chain breakage introduced in 275cd18
* add hints to the user if a submodule checkout fails while using the
depth argument [2]
Thanks,
Lars
[1] http://article.gmane.org/gmane.comp.version-control.git/2812
From: Lars Schneider
"git clone --recursive --depth 1 --single-branch " clones the
submodules successfully. However, it does not obey "--depth 1" for
submodule cloning.
Signed-off-by: Lars Schneider
---
t/t7412-submodule-recursive.sh | 52 ++
1 file chan
From: Lars Schneider
---
t/t7406-submodule-update.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh
index dda3929..b5bd976 100755
--- a/t/t7406-submodule-update.sh
+++ b/t/t7406-submodule-update.sh
@@ -758,7 +758,7 @@
From: Lars Schneider
A submodule checkout might fail due missing hashes caused by a shallow
fetch operation triggered with the "--depth" argument. Make the user
aware of this with an extended die message.
Signed-off-by: Lars Schneider
---
git-submodule.sh| 4
t/t7406-submodul
On 2015-12-20 15.21, Johannes Schindelin wrote:
> Hi Peff,
>
> On Sun, 20 Dec 2015, Jeff King wrote:
>
>> On Sat, Dec 19, 2015 at 07:21:59PM +0100, Johannes Schindelin wrote:
>>
>>> It was pointed out by Yaroslav Halchenko that the file containing the
>>> commit message had the wrong permissions
From: Lars Schneider
If tests are executed in verbose mode then the retry logic clutters the
test output. Suppress that clutter.
Signed-off-by: Lars Schneider
---
t/lib-git-p4.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/lib-git-p4.sh b/t/lib-git-p4.sh
index 30bf7ae
From: Lars Schneider
Hi,
these patches extend "git-p4: add trap to kill p4d on test exit" (dfe90e8)
and therefore should be applied on master.
Thanks,
Lars
Lars Schneider (2):
git-p4: kill p4d watchdog on cleanup
git-p4: suppress non test relevant output
t/lib-git-p4.sh | 3 ++-
1 file c
From: Lars Schneider
If failing tests are executed with the "immediate" flag then "kill_p4d"
is not called and consequently the watchdog process, which is supposed
to detect a hanging p4d, is not killed. Kill the watchdog always in the
"on exit" cleanup trap.
Signed-off-by: Lars Schneider
---
I'm not sure what version the `%>` / `<|` / etc padding showed up in,
but they're truly excellent for building beautiful one-line `git log`
output.
This may be a long-shot, but, unfortunately, these new formats sort of
fall flat in the presence of `git log --graph`: The ‘pad until column’
feature,
From: Lars Schneider
Detect if a P4 changelists only changes the creation or modification
date of its files. Ignore these kind of changed files on import to avoid
empty Git commits. This would happen because Git does not track these
properties.
Signed-off-by: Lars Schneider
---
git-p4.py
From: Lars Schneider
Hi,
this patch improves "git-p4: add option to keep empty commits" (4ae048e)
and therefore should be applied on master.
Thanks,
Lars
Lars Schneider (1):
git-p4: ignore P4 changelists that only touch files
git-p4.py| 54 ++
Hi Peff,
On Sun, 20 Dec 2015, Jeff King wrote:
> On Sat, Dec 19, 2015 at 07:21:59PM +0100, Johannes Schindelin wrote:
>
> > It was pointed out by Yaroslav Halchenko that the file containing the
> > commit message had the wrong permissions in a shared setting.
> >
> > Let's fix that.
> >
> > Si
20 matches
Mail list logo
