On Fri, Oct 21, 2016 at 05:00:29AM -0400, Jeff King wrote:
> On Fri, Oct 21, 2016 at 04:50:13PM +1100, Duncan Roe wrote:
>
> > For example, if .git/config has this alias (the sleep is to leave time to
> > examine output from ps, &c.):
> >
> > [alias]
> > tryme = "!echo $PWD;sleep 600"
> >
> > [
On Fri, Oct 21, 2016 at 3:40 AM, Dennis Kaarsemaker
wrote:
> On Thu, 2016-10-20 at 08:31 -0400, Jeff King wrote:
>
>> I'm also not entirely convinced that the test suite being a shell script
>> is the main culprit for its slowness. We run git a lot of times, and
>> that's inherent in testing it. I
On Thu, Oct 20, 2016 at 11:40 PM, René Scharfe wrote:
> Am 20.10.2016 um 13:02 schrieb Duy Nguyen:
>> On Wed, Oct 19, 2016 at 4:18 PM, Johannes Schindelin
>> wrote:
>>> Hi Junio,
>>>
>>> I know you are a fan of testing things thoroughly in the test suite, but I
>>> have to say that it is getting
Because we run the tests via "prove", the output from
"--verbose" may interfere with our TAP output. Using
"--verbose-log" solves this while letting us retain our
on-disk log.
Signed-off-by: Jeff King
---
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.travis.yml
The "--verbose" option redirects output from arbitrary
test commands to stdout. This is useful for examining the
output manually, like:
./t5547-push-quarantine.sh -v | less
But it also means that the output is intermingled with the
TAP directives, which can confuse a TAP parser like "prove".
Th
We are careful in test_done to handle a results directory
with a space in it, but the "--tee" code path does not.
Doing:
export TEST_OUTPUT_DIRECTORY='/tmp/path with spaces'
./t000-init.sh --tee
results in errors. Let's consistently double-quote our path
variables so that this works.
Signed-
On Fri, Oct 21, 2016 at 04:43:48AM -0400, Jeff King wrote:
> The obvious fix would be to send "--verbose" output to stderr, but I
> suspect that would end up annoying for people who do:
>
> ./t5547-push-quarantine.sh -v | less
>
> to read long output. Probably we need some option like "--log"
parse_mailboxes should probably eventually be completely equivalent to
Mail::Address, and if this happens we can drop the Mail::Address
dependency. Add a comment in the code reminding the current state of the
code, and point to the corresponding failing test to help future
contributors to get it ri
e3fdbcc8e1 (parse_mailboxes: accept extra text after <...> address,
2016-10-13) improved our in-house address parser and made it closer to
Mail::Address. As a consequence, some tests comparing it to
Mail::Address now pass, but e3fdbcc8e1 forgot to update the test.
Signed-off-by: Matthieu Moy
---
On Fri, Oct 21, 2016 at 04:50:13PM +1100, Duncan Roe wrote:
> For example, if .git/config has this alias (the sleep is to leave time to
> examine output from ps, &c.):
>
> [alias]
> tryme = "!echo $PWD;sleep 600"
>
> [...]
> 16:42:06$ ps axf|grep -A2 trym[e]
> 2599 pts/4S+ 0:00
On Fri, Oct 21, 2016 at 04:20:35AM -0400, Jeff King wrote:
> Yes, but I do not see how it can trigger this:
>
> > > Parse errors: Tests out of sequence. Found (2) but expected (3)
> > > Tests out of sequence. Found (3) but expected (4)
> > > Tests out of sequen
On Fri, Oct 21, 2016 at 07:27:40AM +0200, Johannes Sixt wrote:
> Am 20.10.2016 um 23:38 schrieb Jeff King:
> > test_cmp () {
> > # optimize for common "they are the same" case
> > # without any subshells or subprograms
>
> We do this already on Windows; it's the functi
On Thu, Oct 20, 2016 at 11:10:39PM -0700, Stefan Beller wrote:
> > on TravisCI I see these weird "Tests out of sequence" errors with prove
> > and they seem to not go away. I assume the reason that they not go away
> > is that the ".prove" file is carried over from on build to another (but I
> >
101 - 113 of 113 matches
Mail list logo
