[PATCH] Documenation: fmt-merge-msg: fix markup in example

2016-10-28 Thread Stefan Christ
The example was not rendered as verbatim text. Fix it. Signed-off-by: Stefan Christ --- Documentation/git-fmt-merge-msg.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/git-fmt-merge-msg.txt b/Documentation/git-fmt-merge-msg.txt

Re: Expanding Includes in .gitignore

2016-10-28 Thread Aaron Pelly
On 28/10/16 15:54, Junio C Hamano wrote: > Jeff King writes: > >> However, as I said elsewhere, I'm not convinced this feature is all that >> helpful for in-repository .gitignore files, and I think it does >> introduce compatibility complications. People with older git will not >>

Re: [PATCH] attr: convert to new threadsafe API

2016-10-28 Thread Johannes Schindelin
Hi Stefan, On Thu, 27 Oct 2016, Stefan Beller wrote: > * use attr_start on Windows to dynamically initialize the Single Big Attr > Mutex I would have preferred that call in common-main.c, but whatevs... Thanks you for fixing the bug, Dscho

Re: [PATCH] valgrind: support test helpers

2016-10-28 Thread Johannes Schindelin
Hi, On Fri, 28 Oct 2016, René Scharfe wrote: > Tests run with --valgrind call git commands through a wrapper script > that invokes valgrind on them. This script (valgrind.sh) is in turn > invoked through symlinks created for each command in t/valgrind/bin/. > > Since e6e7530d (test helpers:

Re: feature request

2016-10-28 Thread Johannes Schindelin
Hi, On Thu, 27 Oct 2016, David Lang wrote: > On Thu, 27 Oct 2016, John Rood wrote: > > > Thanks, I think changing the default for windows is a good idea. > > notepad doesn't work well with unix line endings, wordpad handles the files > much more cleanly. That is why we have a `notepad` helper

Re: Expanding Includes in .gitignore

2016-10-28 Thread Jeff King
On Fri, Oct 28, 2016 at 11:17:26AM +1300, Aaron Pelly wrote: > On 28/10/16 10:55, Aaron Pelly wrote: > > 2) I fetch a repo with a hostile ignore file. It includes files from > > $GIT_DIR/test-data/ssl/private or some such. Change. Don't pay > > attention. Commit. Push. Problems if my test data

Re: [PATCH v3 2/3] sha1_file: open window into packfiles with O_CLOEXEC

2016-10-28 Thread Jeff King
On Thu, Oct 27, 2016 at 03:38:59PM -0700, Linus Torvalds wrote: > On Thu, Oct 27, 2016 at 3:24 AM, Jeff King wrote: > > > > +cc Linus as the original author of 144bde78e9 in case there is > > something subtle I'm missing, but this really just seems like it's > > an outdated

Re: Drastic jump in the time required for the test suite

2016-10-28 Thread Duy Nguyen
On Fri, Oct 28, 2016 at 3:41 AM, Eric Wong wrote: > Johannes Schindelin wrote: >> I know you are a fan of testing things thoroughly in the test suite, but I >> have to say that it is getting out of hand, in particular due to our >> over-use of shell

Re: [PATCH] compat: Allow static initializer for pthreads on Windows

2016-10-28 Thread Jacob Keller
On Thu, Oct 27, 2016 at 10:55 PM, Johannes Sixt wrote: > One point is that the DCLP idiom must be implemented correctly. There are > solutions, of course, and when the initialization is over, we have a > miniscule overhead at each pthread_mutex_lock call. > Right, this I

Re: [PATCH v15 01/27] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

2016-10-28 Thread Matthieu Moy
Junio C Hamano writes: > Cc'ed those who touched either "git-bisect.sh" or "builtin/bisect-helper.c" > in our relatively recent past. > > Does any of you (and others on the list) have time and inclination > to review this series? Unfortunately, I have essentially

<    1   2