On Sun, Jul 30, 2017 at 12:23 AM, Prathamesh Chavan wrote:
> +static void print_status(struct status_cb *info, char state, const char
> *path,
> +const struct object_id *oid, const char *displaypath)
> +{
> + if (info->quiet)
> +
On Sun, Jul 30, 2017 at 12:23 AM, Prathamesh Chavan wrote:
> +static int module_summary(int argc, const char **argv, const char *prefix)
> +{
> + struct summary_cb info = SUMMARY_CB_INIT;
> + int cached = 0;
> + char *diff_cmd = "diff-index";
> + int
It was observed that the variable '$displaypath' was accessible but
undocumented. Hence, document it.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
In this new version, the
This aims to make git-submodule foreach a builtin. This is the very
first step taken in this direction. Hence, 'foreach' is ported to
submodule--helper, and submodule--helper is called from git-submodule.sh.
The code is split up to have one function to obtain all the list of
submodules. This
The submodule subcommand 'summary' is ported in the process of
making git-submodule a builtin. The function cmd_summary() from
git-submodule.sh is ported to functions module_summary(),
compute_summary_module_list(), prepare_submodule_summary() and
print_submodule_summary().
The first function
As using a variable '$path' may be harmful to users due to
capitalization issues, see 64394e3ae9 (git-submodule.sh: Don't
use $path variable in eval_gettext string, 2012-04-17). Adjust
the documentation to advocate for using $sm_path, which contains
the same value. We still make the 'path'
It does not contain the topmost superproject as the author assumed,
but the direct superproject, such that $toplevel/$sm_path is the
actual absolute path of the submodule.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by:
When running 'git submodule foreach' from a subdirectory of your
repository, nested submodules get a bogus value for $sm_path:
For a submodule 'sub' that contains a nested submodule 'nested',
running 'git -C dir submodule foreach echo $path' would report
path='../nested' for the nested submodule.
The same mechanism is used even for porting this submodule
subcommand, as used in the ported subcommands till now.
The function cmd_deinit in split up after porting into three
functions: module_deinit(), for_each_submodule_list() and
deinit_submodule().
Mentored-by: Christian Couder
This aims to make git-submodule 'status' a built-in. Hence, the function
cmd_status() is ported from shell to C. This is done by introducing
three functions: module_status(), submodule_status() and print_status().
The function module_status() acts as the front-end of the subcommand.
It parses
Introduce function get_submodule_displaypath() to replace the code
occurring in submodule_init() for generating displaypath of the
submodule with a call to it.
This new function will also be used in other parts of the system
in later patches.
Mentored-by: Christian Couder
Introduce function for_each_submodule_list() and
replace a loop in module_init() with a call to it.
The new function will also be used in other parts of the
system in later patches.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Function set_name_rev() is ported from git-submodule to the
submodule--helper builtin. The function get_name_rev() generates the
value of the revision name as required, and the function
print_name_rev() handles the formating and printing of the obtained
revision name.
Mentored-by: Christian
Thank you Brandon Williams for reviewing the previous
patch series.
Also, I'm sorry for repling late to your reviews. The main reason was
to give sufficient time to prepare the next version of each patch as
suggested.
The changes made in each patch are enlisted in the patch
Change the scope of function count_lines for allowing the function
to be reused in other parts of the code as well.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
diff.c | 2 +-
Port the submodule subcommand 'sync' from shell to C using the same
mechanism as that used for porting submodule subcommand 'status'.
Hence, here the function cmd_sync() is ported from shell to C.
This is done by introducing three functions: module_sync(),
sync_submodule() and
>From Mrs.Muna Hariri
Dearest One I am Mrs.Muna Hariri I am 51years Old Woman from (Paris)
France, I married to Mr. Ali Hariri who worked with our (Paris)
France Embassy here for ten years before he died in the year 2006. We
were married for Nine years without a child. And He died after a brief
Please Whoever this email meets i need your co-operation
and to introduce myself i am Mr Richard Water and i work with
an intermediary bank by name Exodus bank Group , i discovered
from my bank data assessment as the bank auditor general
that a deceased customer left in one of his accounts 580
On Fri, Jul 28, 2017 at 03:14:49PM -0700, Junio C Hamano wrote:
> Stefan Beller writes:
>
> > The first test marked relies on hard coded sha1:
> >
> > # We need to create two object whose sha1s start with 17
> > # since this is what git gc counts. As it happens,
Jonathan Tan writes:
> Thanks for all your comments.
>
> This is now built off "next" to include Lars's changes.
Developing on 'next' to ask for comments is OK, but try to minimize
the dependencies; otherwise you are setting yourself to be taken
hostage by many
Kaartic Sivaraam writes:
> On Fri, 2017-07-28 at 20:53 -0700, Junio C Hamano wrote:
>> Kaartic Sivaraam writes:
>>
>> > Though the message seems to be most fitting one, I'm a little reluctant
>> > to use it as it "might" create a
Jonathan Tan writes:
> Teach fsck to not treat missing objects indirectly pointed to by refs as
> an error when extensions.lazyobject is set.
I forgot to mention a potential flaw in this approach in my previous
message.
If you are a pure sightseer, then this is
Good day dear, i hope this mail meets you well? my name is Jack, from the U.S.
I know this may seem inappropriate so i ask for your forgiveness but i wish to
get to know you better, if I may be so bold. I consider myself an easy-going
man, adventurous, honest and fun loving person but I am
From: "Ben Peart"
Sent: Tuesday, July 25, 2017 4:10 PM
On 7/21/2017 4:33 PM, Jonathan Tan wrote:
On Fri, 21 Jul 2017 12:24:52 -0400
Ben Peart wrote:
Today we have 3.5 million objects * 30 bytes per entry = 105 MB of
promises. Given the average
From: "Jonathan Nieder"
Sent: Monday, July 17, 2017 7:03 PM
Hi Philip,
Philip Oakley wrote:
From: "Jonathan Tan"
These patches are part of a set of patches implementing partial clone,
as you can see here:
The error message shown when a flag is found when expecting a
filename wasn't clear as it didn't communicate what was wrong
using the 'suitable' words in *all* cases.
$ git ls-files
README.md
test-file
Correct case,
$ git rev-parse README.md --flags
On Fri, 2017-07-28 at 20:53 -0700, Junio C Hamano wrote:
> Kaartic Sivaraam writes:
>
> > Though the message seems to be most fitting one, I'm a little reluctant
> > to use it as it "might" create a wrong picture on the minds of the user
> > making them think this
When using filters, the commit list shows not only commits matching
the filter criteria, but also boundary commits. When going through a
list of say, all commits changing the variable `foo`, often half of
the displayed commits are boundary commits. In this case the boundary
commits are of little
Compliment of the day,
I am Mr.Kere Casmire I Have a Business Proposal of $5.3 million For You.
I am aware of the unsafe nature of the internet,
and was compelled to use this medium due to the nature of this project.
I have access to very vital information that can be used to transfer
this huge
29 matches
Mail list logo