Re: [PATCH v3] run-command: add hint when a hook is ignored

Jeff King writes: > The problem is that I was bisecting an unrelated change in old code, and > I built a commit which predates f98f8cbac0 (Ship sample hooks with .sample > suffix, 2008-06-24). That wrote a bare "update" file into templates/blt > (without the ".sample" suffix).

Re: [PATCH v3 1/1] convert_to_git(): checksafe becomes int conv_flags

On 2018-01-05 20:00, Lars Schneider wrote: > >> On 01 Jan 2018, at 22:59, tbo...@web.de wrote: >> >> From: Torsten Bögershausen >> >> When calling convert_to_git(), the checksafe parameter has been used to >> check if commit would give a non-roundtrip conversion of EOL. >> >> When

Re: [PATCH 3/4] clone: factor out dir_exists() helper

Jeff King writes: > On Thu, Jan 04, 2018 at 06:54:12PM -0500, Jeff King wrote: > >> > If we really want to be anal, perhaps a new helper path_exists() >> > that cares only about existence of paths (i.e. the implementation of >> > these two helpers they currently have), together

Re: [PATCH] git-archive: accept --owner and --group like GNU tar

René Scharfe writes: >> One practical problem is that users who do this >> >> $ git archive HEAD Documentation/ | tar tf - >> >> would be expecting (at least) two different things, depending on the >> situation they are in. >> >> So at least you'd need an

Re: [PATCH v4 7/7] wildmatch test: create & test files on disk in addition to in-memory

On Fri, Jan 05 2018, Johannes Schindelin jotted: > I spent the last 3.5 hours chasing down a bug in your patch series that > seems to be Windows specific, so please forgive me if the following might > leak a bit of my frustration into the open... Thanks for looking into this. > On Thu, 4 Jan

Re: [PATCH v3 1/1] convert_to_git(): checksafe becomes int conv_flags

> On 01 Jan 2018, at 22:59, tbo...@web.de wrote: > > From: Torsten Bögershausen > > When calling convert_to_git(), the checksafe parameter has been used to > check if commit would give a non-roundtrip conversion of EOL. > > When checksafe was introduced, 3 values had been in

Re: [PATCH v2 3/3] send-email: add test for Linux's get_maintainer.pl

On Fri, Jan 5, 2018 at 1:36 PM, Matthieu Moy wrote: > From: Alex Bennée > > We had a regression that broke Linux's get_maintainer.pl. Using > Mail::Address to parse email addresses fixed it, but let's protect > against future regressions. > >

Re: Bug report: git clone with dest

Done: https://github.com/git-for-windows/git/pull/1421 I added credit to Jeff in the PR's description. Note that I tried compiling master, but failed due to a reason unrelated to this patch: builtin/checkout.c:24:10: fatal error: fscache.h: No such file or directory Maybe I wasn't building it

Re: [PATCH v2 2/2] Windows: stop supplying BLK_SHA1=YesPlease by default

Ævar Arnfjörð Bjarmason writes: >> So I would like to ask to skip this patch for now, and take Jeff >> Hostetler's patch as part of the MSVC patches later, once they have been >> matured in Git for Windows? > > Sounds good to me. Junio, could you please drop this one and just

Re: [PATCH 4/4] clone: do not clean up directories we didn't create

Jeff King writes: > Oops. The second one should be "wt" (since the idea was to flip the > logic from the previous). Like so: > > diff --git a/t/t5600-clone-fail-cleanup.sh b/t/t5600-clone-fail-cleanup.sh > index 5cd94d5558..4a1a912e03 100755 > --- a/t/t5600-clone-fail-cleanup.sh >

prepare-commit-msg hook no longer run for cherry-pick?

Hi, I had prepare-commit-msg hook that would scrub "Patchwork-ID: " tags form commit messages and would update input mailing list patchwork to mark corresponding patches as "accepted" when I cherry pick form WIP/review queue into branches that I publish, but that recently stopped working if I

[PATCH v2 2/3] Remove now useless email-address parsing code

We now use Mail::Address unconditionaly, hence parse_mailboxes is now dead code. Remove it and its tests. Signed-off-by: Matthieu Moy --- perl/Git.pm | 71 t/t9000-addresses.sh | 27

[PATCH v2 3/3] send-email: add test for Linux's get_maintainer.pl

From: Alex Bennée We had a regression that broke Linux's get_maintainer.pl. Using Mail::Address to parse email addresses fixed it, but let's protect against future regressions. Patch-edited-by: Matthieu Moy Signed-off-by: Alex Bennée

[PATCH v2 1/3] send-email: add and use a local copy of Mail::Address

We used to have two versions of the email parsing code. Our parse_mailboxes (in Git.pm), and Mail::Address which we used if installed. Unfortunately, both versions have different sets of bugs, and changing the behavior of git depending on whether Mail::Address is installed was a bad idea. A first

Re: [PATCH v3 0/5] Add --no-ahead-behind to status

On 1/4/2018 6:06 PM, Jeff King wrote: On Wed, Jan 03, 2018 at 09:47:28PM +, Jeff Hostetler wrote: Config values of true and false control non-porcelain formats for compatibility reasons as previously discussed. In the last commit I added a new value of 2 for the config setting to allow

Re: [PATCH v4 7/7] wildmatch test: create & test files on disk in addition to in-memory

Hi Ævar, I spent the last 3.5 hours chasing down a bug in your patch series that seems to be Windows specific, so please forgive me if the following might leak a bit of my frustration into the open... On Thu, 4 Jan 2018, Ævar Arnfjörð Bjarmason wrote: > t/t3070-wildmatch.sh | 301 >

Re: [PATCH v3 2/5] status: add --[no-]ahead-behind to status and commit for V2 format.

On 1/4/2018 5:05 PM, Junio C Hamano wrote: Jeff Hostetler writes: + sti = stat_tracking_info(branch, _ahead, _behind, +, s->ahead_behind_flags); if (base) { base =

Re: [PATCH 5/5] convert: add support for 'checkout-encoding' attribute

Hi, On Sun, 31 Dec 2017, tbo...@web.de wrote: > diff --git a/t/t0028-checkout-encoding.sh b/t/t0028-checkout-encoding.sh > new file mode 100755 > index 00..1a329ab933 > --- /dev/null > +++ b/t/t0028-checkout-encoding.sh > @@ -0,0 +1,197 @@ > +#!/bin/sh > + >

Re: [PATCH v5 13/34] directory rename detection: tests for handling overwriting untracked files

On Thu, Jan 4, 2018 at 10:10 PM, Elijah Newren wrote: > On Wed, Jan 3, 2018 at 5:52 PM, SZEDER Gábor wrote: > >>> + test $(git rev-parse :0:y/b) = $(git rev-parse O:z/b) && >> >> There is a test helper for that :) >> >> test_cmp_rev :0:y/b

Re: [RFC PATCH 1/2] add a local copy of Mail::Address from CPAN

On Thu, Jan 04 2018, Matthieu Moy jotted: > I looked at the perl/Git/Error.pm wrapper, and ended up writting a > different, much simpler version. I'm not sure the same approach would > apply to Error.pm, but my straightforward version does the job for > Mail/Address.pm. Yeah, yours is much

Re: [PATCH] git-archive: accept --owner and --group like GNU tar

Am 04.01.2018 um 19:22 schrieb Junio C Hamano: > René Scharfe writes: > >> I don't know if it's a good idea, but perhaps we don't even need a new >> option. We could change how pathspecs of untracked files are handled: >> Instead of aborting we could include them in the archive.

RE

my name is Mrs. Alice Walton, a business woman an America Citizen and the heiress to the fortune of Walmart stores, born October 7, 1949. I have a mission for you worth $100,000,000.00(Hundred Million United State Dollars) which I intend using for CHARITY

Re: [PATCH] send-email: add test for Linux's get_maintainer.pl

Alex Bennée writes: > I think you need to apply Eric's suggestions from: > > From: Eric Sunshine > Date: Sat, 18 Nov 2017 21:54:46 -0500 > Message-ID: > Indeed. I'm

Re: GSoC 2018 Org applications. Deadline = January 23, 2018 at 18:00 (CET)

Hi, On Fri, 5 Jan 2018, Matthieu Moy wrote: > If we go for it, we need: > > * Admins > > * Potential mentors Count me in as a potential mentor. > * List of microproject and project ideas > (https://git.github.io/SoC-2017-Ideas/ and > https://git.github.io/SoC-2017-Microprojects/ are good

Re: [PATCH] send-email: add test for Linux's get_maintainer.pl

Matthieu Moy writes: > From: Alex Bennée > > We had a regression that broke Linux's get_maintainer.pl. Using > Mail::Address to parse email addresses fixed it, but let's protect > against future regressions. > > Patch-edited-by: Matthieu Moy

Re: [PATCH v2 3/3] travis: run tests with GIT_TEST_SPLIT_INDEX

> On 04 Jan 2018, at 21:13, Thomas Gummerer wrote: > > On 12/18, Lars Schneider wrote: >> >>> On 17 Dec 2017, at 23:51, Thomas Gummerer wrote: >>> >>> Split index mode only has a few dedicated tests, but as the index is >>> involved in nearly every

Re: Bug report: git clone with dest

Hi Isaac, On Thu, 4 Jan 2018, Isaac Shabtay wrote: > I cloned git's codebase, applied the four patches on master, built and > tested on Ubuntu Trusty. (After verifying that master indeed exhibits > this behaviour on Linux as well. Just checking). > Seems to work fine. > I also looked at the

[PATCH] send-email: add test for Linux's get_maintainer.pl

From: Alex Bennée We had a regression that broke Linux's get_maintainer.pl. Using Mail::Address to parse email addresses fixed it, but let's protect against future regressions. Patch-edited-by: Matthieu Moy Signed-off-by: Alex Bennée

Re: [RFC PATCH 2/2] Remove now useless email-address parsing code

Alex Bennée writes: > Matthieu Moy writes: > >> We now use Mail::Address unconditionaly, hence parse_mailboxes is now >> dead code. Remove it and its tests. >> >> Signed-off-by: Matthieu Moy >> --- >> perl/Git.pm |

[PATCH v3 3/7] perf/aggregate: implement codespeed JSON output

Codespeed (https://github.com/tobami/codespeed/) is an open source project that can be used to track how some software performs over time. It stores performance test results in a database and can show nice graphs and charts on a web interface. As it can be interesting to use Codespeed to see how

[PATCH v3 2/7] perf/aggregate: refactor printing results

As we want to implement another kind of output than the current output for the perf test results, let's refactor the existing code that outputs the results in its own print_default_results() function. Signed-off-by: Christian Couder --- t/perf/aggregate.perl | 96

[PATCH v3 5/7] perf/run: learn about perf.codespeedOutput

Let's make it possible to set in a config file the output format (regular or codespeed) of the perf tests. Signed-off-by: Christian Couder --- t/perf/run | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/t/perf/run b/t/perf/run index

[PATCH v3 0/7] Codespeed perf results

This patch series is built on top of cc/perf-run-config which recently graduated to master. It makes it possible to send perf results to a Codespeed server. See https://github.com/tobami/codespeed/ and web sites like http://speed.pypy.org/ which are using Codespeed. The end goal would be to have

[PATCH v3 1/7] perf/aggregate: fix checking ENV{GIT_PERF_SUBSECTION}

The way we check ENV{GIT_PERF_SUBSECTION} could trigger comparison between undef and "" that may be flagged by use of strict & warnings. Let's fix that. Signed-off-by: Christian Couder --- t/perf/aggregate.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v3 7/7] perf/run: read GIT_PERF_REPO_NAME from perf.repoName

The GIT_PERF_REPO_NAME env variable is used in the `aggregate.perl` script to set the 'environment' field in the JSON Codespeed output. Let's make it easy to set this variable by setting it in a config file. Signed-off-by: Christian Couder --- t/perf/run | 3 +++ 1

<    1   2