On Sun, Mar 25, 2018 at 9:49 AM, Thomas Gummerer wrote:
> Currently 'git worktree add ' creates a new branch named after the
> basename of the path by default. If a branch with that name already
> exists, the command refuses to do anything, unless the '--force' option
> is given.
>
> However we c
On Sun, Mar 25, 2018 at 9:49 AM, Thomas Gummerer wrote:
> Factor out a dwim_branch function, which takes care of the dwim'ery in
> 'git worktree add '. It's not too much code currently, but we're
> adding a new kind of dwim in a subsequent patch, at which point it makes
> more sense to have it as
On Sun, Mar 25, 2018 at 9:49 AM, Thomas Gummerer wrote:
> The 'force_new_branch' flag in 'struct add_opts' is only used inside the
> add function, where we already have the same information stored in the
> 'new_branch_force' variable. Avoid that unnecessary duplication.
When I was reviewing your
On Sun, Mar 25, 2018 at 9:49 AM, Thomas Gummerer wrote:
> Currently there is no indication in the "git worktree add" output that
> a new branch was created. This would be especially useful information
> in the case where the dwim of "git worktree add " kicks in, as the
> user didn't explicitly as
On Sun, Mar 25, 2018 at 9:49 AM, Thomas Gummerer wrote:
> Thanks Eric for the review of the previous round and Duy and Junio for
> additional comments.
> This round should address all of Eric's comments from the previous round.
Thanks, it appears to cover my review comments from the previous
roun
101 - 105 of 105 matches
Mail list logo
