Re: [PATCH] fetch: replace string-list used as a look-up table with a hashmap

2018-09-26 Thread Jeff King
On Wed, Sep 26, 2018 at 03:59:08PM -0700, Stefan Beller wrote: > > +struct refname_hash_entry { > > + struct hashmap_entry ent; /* must be the first member */ > > $ git grep "struct hashmap_entry" reveals that we have another > convention that we follow but not document, which is to stress

[PATCH v2] git.txt: mention mailing list archive

2018-09-26 Thread Martin Ågren
In the "Reporting Bugs" section of git(1), we refer to the mailing list, but we do not give any hint about where the archives might be found. Of course, any web search engine can be used to try to hunt down whether an issue is already known. But we can do better by mentioning the archive at

Re: [PATCH] fetch: replace string-list used as a look-up table with a hashmap

2018-09-26 Thread Jeff King
On Wed, Sep 26, 2018 at 02:28:28PM -0700, Junio C Hamano wrote: > In find_non_local_tags() helper function (used to implement the > "follow tags"), we use string_list_has_string() on two string lists > as a way to see if a refname has already been processed, etc. > > All this code predates more

Re: [PATCH] doc: clarify gitcredentials path component matching

2018-09-26 Thread Jeff King
On Wed, Sep 26, 2018 at 10:23:11PM +, Zych, David M wrote: > The gitcredentials documentation implied that the config file's > "pattern" URL might include a path component, but did not explain that > it must match exactly (potentially leaving readers with the false hope > that it would

Re: Triggering "BUG: wt-status.c:476: multiple renames on the same target? how?"

2018-09-26 Thread Elijah Newren
On Wed, Sep 26, 2018, 2:27 PM Ævar Arnfjörð Bjarmason wrote: > > On Wed, Sep 26 2018, Andrea Stacchiotti wrote: > > > I'm very sorry, I indeed forgot the `diff.renames=copies`. > > > > The following script can reproduce the bug even with a blank config: Thanks for the bug report and the simple

URGENT RESPONSE PLEASE.

2018-09-26 Thread Sean Kim.
Hello my dear. Did you receive my email message to you? Please, get back to me ASAP as the matter is becoming late. Expecting your urgent response. Sean.

[PATCH v2 4/4] archive: allow archive over HTTP(S) with proto v2

2018-09-26 Thread Josh Steadmon
Signed-off-by: Josh Steadmon --- builtin/archive.c | 12 +++- http-backend.c | 13 - transport-helper.c | 7 --- 3 files changed, 27 insertions(+), 5 deletions(-) diff --git a/builtin/archive.c b/builtin/archive.c index f91d222677..78a259518d 100644 ---

[PATCH v2 3/4] archive: implement protocol v2 archive command

2018-09-26 Thread Josh Steadmon
This adds a new archive command for protocol v2. The command expects arguments in the form "argument X" which are passed unmodified to git-upload-archive--writer. This command works over the file://, Git, and SSH transports. HTTP support will be added in a separate patch. NEEDSWORK: this is not

[PATCH v2 1/4] archive: follow test standards around assertions

2018-09-26 Thread Josh Steadmon
Move assertions outside of the check_tar function so that all top-level code is wrapped in a test_expect_* assertion. Signed-off-by: Josh Steadmon --- t/t5000-tar-tree.sh | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/t/t5000-tar-tree.sh

[PATCH v2 2/4] archive: use packet_reader for communications

2018-09-26 Thread Josh Steadmon
Using packet_reader will simplify version detection and capability handling, which will make implementation of protocol v2 support in git-archive easier. This refactoring does not change the behavior of "git archive". Signed-off-by: Josh Steadmon --- builtin/archive.c | 23

[PATCH v2 0/4] Add proto v2 archive command with HTTP support

2018-09-26 Thread Josh Steadmon
This is the second version of my series to add a new protocol v2 command for archiving, with support for HTTP(S). NEEDSWORK: a server built with this series is not backwards-compatible with clients that set GIT_PROTOCOL=version=2 or configure protocol.version=2. The old client will

Reminder,

2018-09-26 Thread Juliet Muhammad
Hello Please i still await your response regarding my previous email.

Reminder,

2018-09-26 Thread Juliet Muhammad
Hello Please i still await your response regarding my previous email.

Reminder,

2018-09-26 Thread Juliet Muhammad
Hello Please i still await your response regarding my previous email.

Reminder,

2018-09-26 Thread Juliet Muhammad
Hello Please i still await your response regarding my previous email.

Reminder,

2018-09-26 Thread Juliet Muhammad
Hello Please i still await your response regarding my previous email.

Reminder,

2018-09-26 Thread Juliet Muhammad
Hello Please i still await your response regarding my previous email.

Reminder,

2018-09-26 Thread Juliet Muhammad
Hello Please i still await your response regarding my previous email.

Reminder,

2018-09-26 Thread Juliet Muhammad
Hello Please i still await your response regarding my previous email.

Reminder,

2018-09-26 Thread Juliet Muhammad
Hello Please i still await your response regarding my previous email.

Re: Fixing constant preference prompts during tests

2018-09-26 Thread Tacitus Aedifex
On Wed, Sep 26, 2018 at 02:48:49PM -0700, Junio C Hamano wrote: We do not want your choice of gpg.program or what kind of trust you have personally recorded in your ~/.gnupg/ affect how gpg invoked inside our tests work. This makes sense to me now. I get what you are saying. The gpg binary

Re: On shipping more of our technical docs as manpages

2018-09-26 Thread Stefan Beller
On Wed, Sep 26, 2018 at 1:44 PM Ævar Arnfjörð Bjarmason wrote: > > And if we were going to generate something external, would it make more > > sense to write in a structured format like doxygen? I am not a big fan > > of it myself, but at least from there you can generate a more richly > >

Re: [PATCH] fetch: replace string-list used as a look-up table with a hashmap

2018-09-26 Thread Stefan Beller
On Wed, Sep 26, 2018 at 2:28 PM Junio C Hamano wrote: > > +struct refname_hash_entry { > + struct hashmap_entry ent; /* must be the first member */ $ git grep "struct hashmap_entry" reveals that we have another convention that we follow but not document, which is to stress the importance

[PATCH] doc: clarify gitcredentials path component matching

2018-09-26 Thread Zych, David M
The gitcredentials documentation implied that the config file's "pattern" URL might include a path component, but did not explain that it must match exactly (potentially leaving readers with the false hope that it would support a more flexible prefix match). Signed-off-by: David Zych ---

Re: [PATCH v4 4/9] submodule: move global changed_submodule_names into fetch submodule struct

2018-09-26 Thread Junio C Hamano
Stefan Beller writes: > The `changed_submodule_names` are only used for fetching, so let's make it > part of the struct that is passed around for fetching submodules. > > Signed-off-by: Stefan Beller > --- > submodule.c | 42 +++--- > 1 file changed, 23

Re: [PATCH v4 2/9] submodule.c: fix indentation

2018-09-26 Thread Junio C Hamano
Stefan Beller writes: > The submodule subsystem is really bad at staying within 80 characters. > Fix it while we are here. > > Signed-off-by: Stefan Beller > --- Makes sense. > submodule.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/submodule.c

Re: [PATCH v4 1/9] sha1-array: provide oid_array_filter

2018-09-26 Thread Junio C Hamano
Stefan Beller writes: > Helped-by: Junio C Hamano > Signed-off-by: Stefan Beller > --- > Documentation/technical/api-oid-array.txt | 5 + > sha1-array.c | 17 + > sha1-array.h | 3 +++ > 3 files changed, 25

Re: [PATCH v4 3/9] submodule.c: sort changed_submodule_names before searching it

2018-09-26 Thread Junio C Hamano
Stefan Beller writes: > We can string_list_insert() to maintain sorted-ness of the > list as we find new items, or we can string_list_append() to > build an unsorted list and sort it at the end just once. > > To pick which one is more appropriate, we notice the fact > that we discover new items

Re: [PATCH v6 0/7] speed up index load through parallelization

2018-09-26 Thread Junio C Hamano
Ben Peart writes: > Base Ref: master > Web-Diff: https://github.com/benpeart/git/commit/a0300882d4 > Checkout: git fetch https://github.com/benpeart/git read-index-multithread-v6 > && git checkout a0300882d4 > > > This iteration brings back the Index Entry Offset Table (IEOT) extension > which

Re: Fixing constant preference prompts during tests

2018-09-26 Thread Junio C Hamano
Tacitus Aedifex writes: > It may be a little more complicated than this because looking at the > tests it seems like they set up their own dummy user with dummy keys > and use gpg directly. Yes, that is """the test framework (t/test-lib.sh, t/lib-gpg.sh, etc.) tries to run our tests in a

Re: GPG signing is bent on WIndows

2018-09-26 Thread Tacitus Aedifex
On Wed, Sep 26, 2018 at 04:05:02PM -0400, Jeffrey Walton wrote: I got to look at it today. On Windows: $ cat ~/.gnupg/gpg-agent.conf pinentry-program /usr/local/MacGPG2/libexec/pinentry-mac.app/Contents/MacOS/pinentry-mac Do you have this app on your system? That path looks like one for a mac

Re: On shipping more of our technical docs as manpages

2018-09-26 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > So in terms of implementation I'm a big fan of the perl.git approach of > having these docs as comments before the function implementation in the > *.c file. > > It means you can't avoid seeing it or updating it when source > spelunking, and it leaves header

Re: Fixing constant preference prompts during tests

2018-09-26 Thread Tacitus Aedifex
On Wed, Sep 26, 2018 at 10:15:06AM -0700, Junio C Hamano wrote: Nobody raised this so far as far as I recall; thanks for the first one to do so, as it is a sign that you are doing something unusual (e.g. have newer or different version of GPG than most other people) and others will hit by the

[PATCH] fetch: replace string-list used as a look-up table with a hashmap

2018-09-26 Thread Junio C Hamano
In find_non_local_tags() helper function (used to implement the "follow tags"), we use string_list_has_string() on two string lists as a way to see if a refname has already been processed, etc. All this code predates more modern in-core lookup API like hashmap; replace them with two hashmaps and

Re: [PATCH 1/8] sha1-array: provide oid_array_filter

2018-09-26 Thread Stefan Beller
> > (I am not seriously proposing unbalanced comments, but for > > longer documenting comments we may want to consider, > > omitting the asterisk?) > > If this is not a serious proposal, then I'll stop wasting > everybody's time. I proposed two things, one of which I was not serious about. The

Re: [PATCH 1/1] read-cache: update index format default to v4

2018-09-26 Thread Matthias Sohn
On Tue, Sep 25, 2018 at 8:01 PM Stefan Beller wrote: > > On Tue, Sep 25, 2018 at 7:30 AM Derrick Stolee wrote: > > > > On 9/25/2018 3:06 AM, Patrick Steinhardt wrote: > > > On Mon, Sep 24, 2018 at 11:32:23PM +0200, SZEDER Gábor wrote: > > >> On Mon, Sep 24, 2018 at 02:15:30PM -0700, Derrick

Re: Triggering "BUG: wt-status.c:476: multiple renames on the same target? how?"

2018-09-26 Thread Andrea Stacchiotti
I'm very sorry, I indeed forgot the `diff.renames=copies`. The following script can reproduce the bug even with a blank config: - # Make a test repo git init testrepo cd testrepo git config user.name A git config user.email B git config diff.renames copies # Add a file

Re: Triggering "BUG: wt-status.c:476: multiple renames on the same target? how?"

2018-09-26 Thread Ævar Arnfjörð Bjarmason
On Wed, Sep 26 2018, Andrea Stacchiotti wrote: > Dear maintainer(s), > > the following script, when executed with git 2.19 triggers the bug in > the subject line. > The problem seems to be the interaction between add -N and rename detection. > > The git binary used is the one currently packaged

Subtree bugs

2018-09-26 Thread Strain, Roger L.
I emailed the group yesterday regarding a possible error in the subtree script. I've continued debugging and since have been able to reproduce the problem. In fact, there are two failure cases which may expose three different problems. To demonstrate, the following commands create two repos

Re: [PATCH 1/8] sha1-array: provide oid_array_filter

2018-09-26 Thread Jeff King
On Wed, Sep 26, 2018 at 01:19:20PM -0700, Junio C Hamano wrote: > > /** > > Would we be open to consider another commenting style? > > No. You still cannot write */ in that comment section, for example, > so you cannot do "plain text" still---that is not a great trade off > to deviate

On shipping more of our technical docs as manpages

2018-09-26 Thread Ævar Arnfjörð Bjarmason
[Changing subject because this stopped being about Stefan's patches a while ago] On Wed, Sep 26 2018, Jeff King wrote: > On Wed, Sep 26, 2018 at 08:43:14PM +0200, Ævar Arnfjörð Bjarmason wrote: > >> While we're on that subject, I'd much prefer if these technical docs and >> other asciidoc-ish

Triggering "BUG: wt-status.c:476: multiple renames on the same target? how?"

2018-09-26 Thread Andrea Stacchiotti
Dear maintainer(s), the following script, when executed with git 2.19 triggers the bug in the subject line. The problem seems to be the interaction between add -N and rename detection. The git binary used is the one currently packaged in Debian unstable. I have searched the list for the bug

Re: [PATCH 1/8] sha1-array: provide oid_array_filter

2018-09-26 Thread Junio C Hamano
Stefan Beller writes: >> I agree on both counts. I just like to read these in plain text >> while I am coding for Git (or reviewing patches coded for Git). >> >> The reason why I have mild preference to D/technical/ over in-header >> doc is only because I find even these asterisks at the

GPG signing is bent on WIndows

2018-09-26 Thread Jeffrey Walton
Several weeks ago I updated to the latest Git for Windows (when prompted by the version check). At the time I noticed: $ git commit -S -am "Fix unset MAKE variable in test scripts" gpg: signing failed: No pinentry gpg: signing failed: No pinentry error: gpg failed to sign the data fatal: failed

Re: [PATCH 1/8] sha1-array: provide oid_array_filter

2018-09-26 Thread Stefan Beller
> I agree on both counts. I just like to read these in plain text > while I am coding for Git (or reviewing patches coded for Git). > > The reason why I have mild preference to D/technical/ over in-header > doc is only because I find even these asterisks at the left-side-end > distracting; it is

[PATCH v6 7/7] read-cache: load cache entries on worker threads

2018-09-26 Thread Ben Peart
This patch helps address the CPU cost of loading the index by utilizing the Index Entry Offset Table (IEOT) to divide loading and conversion of the cache entries across multiple threads in parallel. I used p0002-read-cache.sh to generate some performance data: Test w/100,000 files reduced the

[PATCH v6 6/7] ieot: add Index Entry Offset Table (IEOT) extension

2018-09-26 Thread Ben Peart
This patch enables addressing the CPU cost of loading the index by adding additional data to the index that will allow us to efficiently multi- thread the loading and conversion of cache entries. It accomplishes this by adding an (optional) index extension that is a table of offsets to blocks of

[PATCH v6 5/7] read-cache: load cache extensions on a worker thread

2018-09-26 Thread Ben Peart
This patch helps address the CPU cost of loading the index by loading the cache extensions on a worker thread in parallel with loading the cache entries. In some cases, loading the extensions takes longer than loading the cache entries so this patch utilizes the new EOIE to start the thread to

[PATCH v6 4/7] config: add new index.threads config setting

2018-09-26 Thread Ben Peart
Add support for a new index.threads config setting which will be used to control the threading code in do_read_index(). A value of 0 will tell the index code to automatically determine the correct number of threads to use. A value of 1 will make the code single threaded. A value greater than 1

[PATCH v6 2/7] read-cache: clean up casting and byte decoding

2018-09-26 Thread Ben Peart
This patch does a clean up pass to minimize the casting required to work with the memory mapped index (mmap). It also makes the decoding of network byte order more consistent by using get_be32() where possible. Signed-off-by: Ben Peart --- read-cache.c | 23 +++ 1 file

[PATCH v6 1/7] read-cache.c: optimize reading index format v4

2018-09-26 Thread Ben Peart
From: Nguyễn Thái Ngọc Duy Index format v4 requires some more computation to assemble a path based on a previous one. The current code is not very efficient because - it doubles memory copy, we assemble the final path in a temporary first before putting it back to a cache_entry -

[PATCH v6 3/7] eoie: add End of Index Entry (EOIE) extension

2018-09-26 Thread Ben Peart
The End of Index Entry (EOIE) is used to locate the end of the variable length index entries and the beginning of the extensions. Code can take advantage of this to quickly locate the index extensions without having to parse through all of the index entries. Because it must be able to be loaded

[PATCH v6 0/7] speed up index load through parallelization

2018-09-26 Thread Ben Peart
Base Ref: master Web-Diff: https://github.com/benpeart/git/commit/a0300882d4 Checkout: git fetch https://github.com/benpeart/git read-index-multithread-v6 && git checkout a0300882d4 This iteration brings back the Index Entry Offset Table (IEOT) extension which enables us to multi-thread the

Re: [PATCH 1/8] sha1-array: provide oid_array_filter

2018-09-26 Thread Junio C Hamano
Jeff King writes: > Now I'll admit it seems like make-work to me because I would not plan to > ever look at the formatted output myself. But I guess I don't understand > the audience for this formatted output. These are APIs internal to Git > itself. We would not generally want to install

Re: [PATCH 1/8] sha1-array: provide oid_array_filter

2018-09-26 Thread Stefan Beller
On Wed, Sep 26, 2018 at 11:58 AM Jeff King wrote: > Now I'll admit it seems like make-work to me because I would not plan to > ever look at the formatted output myself. But I guess I don't understand > the audience for this formatted output. I have been watching from the side lines so far, as I

Re: [PATCH] help: allow redirecting to help for aliased command

2018-09-26 Thread Junio C Hamano
Jeff King writes: >> When you have "[alias] cp = cherry-pick -n", "git cp --help" should >> not do "git help cherry-pick". Only a single word that exactly >> matches a git command should get this treatment. > > I'm not sure I agree. A plausible scenario (under the rules I gave > above) is: > >

Re: t7005-editor.sh failure

2018-09-26 Thread Andrei Rybak
On 2018-09-26 21:16, Junio C Hamano wrote: > While at it, update the way to creatd these scripts to use the s/creatd/create/ Or rewording as "... update the way these scripts are created ..." > write_script wrapper, so that we do not have to worry about writing > the she-bang line and making

Re: [PATCH] t7005-editor: quote filename to fix whitespace-issue

2018-09-26 Thread Jeff King
On Wed, Sep 26, 2018 at 06:14:11PM +0200, Martin Ågren wrote: > diff --git a/t/t7005-editor.sh b/t/t7005-editor.sh > index b2ca77b338..5fcf281dfb 100755 > --- a/t/t7005-editor.sh > +++ b/t/t7005-editor.sh > @@ -112,7 +112,7 @@ do > done > > test_expect_success 'editor with a space' ' > -

Re: t7005-editor.sh failure

2018-09-26 Thread Junio C Hamano
Junio C Hamano writes: > SZEDER Gábor writes: > >> Having said all that, I didn't omit the quotes in 4362da078e with the >> above in mind; in fact I tend to use quotes even when they are >> unnecessary (e.g. in variable assignments: var="$1"), because unquoted >> variables and command

Re: [PATCH v3 1/7] prio-queue: add 'peek' operation

2018-09-26 Thread Derrick Stolee
On 9/21/2018 1:39 PM, Derrick Stolee via GitGitGadget wrote: From: Derrick Stolee When consuming a priority queue, it can be convenient to inspect the next object that will be dequeued without actually dequeueing it. Our existing library did not have such a 'peek' operation, so add it as

Re: Git Test Coverage Report (Tuesday, Sept 25)

2018-09-26 Thread Elijah Newren
On Tue, Sep 25, 2018 at 11:44 AM Derrick Stolee wrote: > c3b9bc94b9b (Elijah Newren 2018-09-05 10:03:07 -0700 > 181)options.filter = xstrdup(value); I blame Duy; he was the one who wanted me to look for and remove stray semicolons in additional places[1]. ;-) All joking aside,

Re: [PATCH 1/8] sha1-array: provide oid_array_filter

2018-09-26 Thread Jeff King
On Wed, Sep 26, 2018 at 08:43:14PM +0200, Ævar Arnfjörð Bjarmason wrote: > While we're on that subject, I'd much prefer if these technical docs and > other asciidoc-ish stuff we would be manpages build as part of our > normal "make doc" target. So e.g. this one would be readable via > something

Re: Git Test Coverage Report (Tuesday, Sept 25)

2018-09-26 Thread Derrick Stolee
On 9/26/2018 2:43 PM, Thomas Gummerer wrote: On 09/26, Derrick Stolee wrote: This is a bit tricky to do, but I will investigate. For some things, the values can conflict with each other (GIT_TEST_SPLIT_INDEX doesn't play nicely with other index options, I think). Just commenting on this point.

Re: [PATCH] help: allow redirecting to help for aliased command

2018-09-26 Thread Jeff King
On Wed, Sep 26, 2018 at 08:16:36AM -0700, Junio C Hamano wrote: > > This introduces a help.followAlias config option that transparently > > redirects to (the first word of) the alias text (provided of course it > > is not a shell command), similar to the option for autocorrect of > > misspelled

Re: Git Test Coverage Report (Tuesday, Sept 25)

2018-09-26 Thread Derrick Stolee
On 9/26/2018 1:59 PM, Junio C Hamano wrote: Derrick Stolee writes: In an effort to ensure new code is reasonably covered by the test suite, we now have contrib/coverage-diff.sh to combine the gcov output from 'make coverage-test ; make coverage-report' with the output from 'git diff A B' to

Re: [PATCH 1/8] sha1-array: provide oid_array_filter

2018-09-26 Thread Ævar Arnfjörð Bjarmason
On Wed, Sep 26 2018, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> On Wed, Sep 26 2018, Junio C Hamano wrote: >> >>> Jeff King writes: Yes, please. I think it prevents exactly this sort of confusion. :) >>> >>> CodingGuidelines or SubmittingPatches update, perhaps?

Re: Git Test Coverage Report (Tuesday, Sept 25)

2018-09-26 Thread Thomas Gummerer
On 09/26, Derrick Stolee wrote: > This is a bit tricky to do, but I will investigate. For some things, the > values can conflict with each other (GIT_TEST_SPLIT_INDEX doesn't play > nicely with other index options, I think). Just commenting on this point. I think all the index options should be

Re: [PATCH v2 2/3] transport.c: introduce core.alternateRefsCommand

2018-09-26 Thread Jeff King
On Wed, Sep 26, 2018 at 06:39:56AM -0700, Taylor Blau wrote: > > A perl tangent if you're interested: > [...] > > To be clear, we ought to leave this function as: > > extract_haves () { > depacketize | perl -lne '/^(\S+) \.have/ and print $1' > } Yes, I agree. You cannot do the "$@"

Re: [PATCH v9 00/21] Convert "git stash" to C builtin

2018-09-26 Thread Junio C Hamano
Paul-Sebastian Ungureanu writes: > Hello, > > This is a new iteration of `git stash`, based on the last review I got. > This new iteration brings mostly code styling fix issues in order to make > the code more readable. There is also a new patch "strbuf.c: add > `strbuf_join_argv()`". By making

Re: [PATCH 1/8] sha1-array: provide oid_array_filter

2018-09-26 Thread Jeff King
On Wed, Sep 26, 2018 at 11:27:53AM -0700, Junio C Hamano wrote: > >> diff --git a/Documentation/CodingGuidelines > >> b/Documentation/CodingGuidelines > >> index 48aa4edfbd..b54684e807 100644 > >> --- a/Documentation/CodingGuidelines > >> +++ b/Documentation/CodingGuidelines > >> @@ -358,7

Re: [PATCH 1/8] sha1-array: provide oid_array_filter

2018-09-26 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On Wed, Sep 26 2018, Junio C Hamano wrote: > >> Jeff King writes: >>> >>> Yes, please. I think it prevents exactly this sort of confusion. :) >> >> CodingGuidelines or SubmittingPatches update, perhaps? >> >> Documentation/CodingGuidelines | 6 +- >> 1

Re: [PATCH] worktree: add per-worktree config files

2018-09-26 Thread Ævar Arnfjörð Bjarmason
On Sun, Sep 23 2018, Nguyễn Thái Ngọc Duy wrote: > +extensions.worktreeConfig:: > + If set, by default "git config" reads from both "config" and > + "config.worktree" file in that order. How does this interact with config that's now only used if it's in .git/config? E.g. you can't set

Re: [PATCH] help: allow redirecting to help for aliased command

2018-09-26 Thread Junio C Hamano
Taylor Blau writes: > This pause (though I'm a little surprised by it when reviewing the > code), I think strikes a good balance between the two, i.e., that you > can get help for whatever it is aliased to, and see what that alias is. And I need to react to it within subsecond with ^C when I

Re: t7005-editor.sh failure

2018-09-26 Thread Junio C Hamano
SZEDER Gábor writes: > Having said all that, I didn't omit the quotes in 4362da078e with the > above in mind; in fact I tend to use quotes even when they are > unnecessary (e.g. in variable assignments: var="$1"), because unquoted > variables and command substitutions freak me out before I can

Re: [PATCH] t7005-editor: quote filename to fix whitespace-issue

2018-09-26 Thread Taylor Blau
On Wed, Sep 26, 2018 at 06:14:11PM +0200, Martin Ågren wrote: > From: Alexander Pyhalov > > Commit 4362da078e (t7005-editor: get rid of the SPACES_IN_FILENAMES > prereq, 2018-05-14) removed code for detecting whether spaces in > filenames work. Since we rely on spaces throughout the test suite >

Re: [PATCH] help: allow redirecting to help for aliased command

2018-09-26 Thread Taylor Blau
On Wed, Sep 26, 2018 at 08:16:36AM -0700, Junio C Hamano wrote: > Rasmus Villemoes writes: > > > I often use 'git --help' as a quick way to get the documentation > > for a command. However, I've also trained my muscle memory to use my > > aliases (cp=cherry-pick, co=checkout etc.), which means

Re: [PATCH v4 9/9] Documentation/config: add odb..promisorRemote

2018-09-26 Thread Junio C Hamano
Jeff King writes: >> I do not think "sources that are not git repositories" is all that >> interesting, unless they can also serve as the source for ext:: >> remote helper. And if they can serve "git fetch ext::...", I think >> they can be treated just like a normal Git repository by the >>

Re: [PATCH] help: allow redirecting to help for aliased command

2018-09-26 Thread Taylor Blau
On Wed, Sep 26, 2018 at 08:30:32AM -0700, Junio C Hamano wrote: > Taylor Blau writes: > > >> +help.followAlias:: > >> + When requesting help for an alias, git prints a line of the > >> + form "'' is aliased to ''". If this option is > >> + set to a positive integer, git proceeds to show the

Re: Git Test Coverage Report (Tuesday, Sept 25)

2018-09-26 Thread Junio C Hamano
Derrick Stolee writes: > In an effort to ensure new code is reasonably covered by the test > suite, we now have contrib/coverage-diff.sh to combine the gcov output > from 'make coverage-test ; make coverage-report' with the output from > 'git diff A B' to discover _new_ lines of code that are

Re: [PATCH 1/8] sha1-array: provide oid_array_filter

2018-09-26 Thread Ævar Arnfjörð Bjarmason
On Wed, Sep 26 2018, Junio C Hamano wrote: > Jeff King writes: > >> On Tue, Sep 25, 2018 at 12:26:44PM -0700, Stefan Beller wrote: >> >>> On Sat, Sep 22, 2018 at 5:58 AM Ævar Arnfjörð Bjarmason >>> wrote: >>> > >>> > >>> > On Fri, Sep 21 2018, Stefan Beller wrote: >>> > >>> > > +/* >>> > > +

Re: [PATCH] worktree: add per-worktree config files

2018-09-26 Thread Junio C Hamano
Duy Nguyen writes: > I believe the main selling point of multiple worktrees is sharing > refs. You could easily avoid expensive clones with --local, but > synchronizing between different clones is not very convenient. Other > than that, different worktrees tend to behave like separate clones.

Re: [PATCH] git help: promote 'git help -av'

2018-09-26 Thread Junio C Hamano
Duy Nguyen writes: > Here's the patch that adds that external commands and aliases > sections. I feel that external commands section is definitely good to > have even if we don't replace "help -a". Aliases are more > subjective... I didn't apply this (so I didn't try running it), but a quick

Re: [PATCH] git help: promote 'git help -av'

2018-09-26 Thread Junio C Hamano
Duy Nguyen writes: > -v was recently added just for the new "help -a" in May 2018. I think > it's ok to get rid of it. Memory muscles probably take a couple more > months to kick in. If it is not hurting, keeping it lets people say "--no-verbose" to get a less verbose output to help those who

Re: [PATCH 1/8] sha1-array: provide oid_array_filter

2018-09-26 Thread Junio C Hamano
Jeff King writes: > On Tue, Sep 25, 2018 at 12:26:44PM -0700, Stefan Beller wrote: > >> On Sat, Sep 22, 2018 at 5:58 AM Ævar Arnfjörð Bjarmason >> wrote: >> > >> > >> > On Fri, Sep 21 2018, Stefan Beller wrote: >> > >> > > +/* >> > > + * Apply want to each entry in array, retaining only the

Re: Fixing constant preference prompts during tests

2018-09-26 Thread Junio C Hamano
Tacitus Aedifex writes: > I keep getting prompted for my algorithm preferences while running all > of the git test suite: > > Set preference list to: > Cipher: AES256, AES192, AES, 3DES > Digest: SHA512, SHA384, SHA256, SHA224, SHA1 > Compression: Uncompressed > Features: MDC,

Re: git fetch behaves weirdely when run in a worktree

2018-09-26 Thread Junio C Hamano
Duy Nguyen writes: > On Wed, Sep 26, 2018 at 05:24:14PM +0200, Duy Nguyen wrote: >> On Wed, Sep 26, 2018 at 6:46 AM Kaartic Sivaraam >> wrote: >> > This is the most interesting part of the issue. I **did not** run >> >'git fetch ...' in between those cat commands. I was surprised by >> >how the

Fixing constant preference prompts during tests

2018-09-26 Thread Tacitus Aedifex
I keep getting prompted for my algorithm preferences while running all of the git test suite: Set preference list to: Cipher: AES256, AES192, AES, 3DES Digest: SHA512, SHA384, SHA256, SHA224, SHA1 Compression: Uncompressed Features: MDC, Keyserver no-modify What is the best way

Re: [PATCH] git help: promote 'git help -av'

2018-09-26 Thread Duy Nguyen
On Tue, Sep 25, 2018 at 10:54 PM Jeff King wrote: > Mentioning aliases seems reasonable to me. The definitions of some of > mine are pretty nasty bits of shell, but I guess that people either > don't have any ugly aliases, or are comfortable enough with them that > they won't be scared away. :)

[PATCH] t7005-editor: quote filename to fix whitespace-issue

2018-09-26 Thread Martin Ågren
From: Alexander Pyhalov Commit 4362da078e (t7005-editor: get rid of the SPACES_IN_FILENAMES prereq, 2018-05-14) removed code for detecting whether spaces in filenames work. Since we rely on spaces throughout the test suite ("trash directory.t1234-foo"), testing whether we can use the filename "e

Re: git fetch behaves weirdely when run in a worktree

2018-09-26 Thread Duy Nguyen
On Wed, Sep 26, 2018 at 05:24:14PM +0200, Duy Nguyen wrote: > On Wed, Sep 26, 2018 at 6:46 AM Kaartic Sivaraam > wrote: > > This is the most interesting part of the issue. I **did not** run > >'git fetch ...' in between those cat commands. I was surprised by > >how the contents of FETCH_HEAD are

Re: [PATCH] worktree: add per-worktree config files

2018-09-26 Thread Duy Nguyen
On Tue, Sep 25, 2018 at 11:26 PM Junio C Hamano wrote: > Warning: devil's advocate mode on. Oh good. I need to a good dose of sanity anyway. > Done in either way, this will confuse the users. What is the reason > why people are led to think it is a good idea to use multiple > worktrees, even

Re: [PATCH] help: allow redirecting to help for aliased command

2018-09-26 Thread Junio C Hamano
Taylor Blau writes: >> +help.followAlias:: >> +When requesting help for an alias, git prints a line of the >> +form "'' is aliased to ''". If this option is >> +set to a positive integer, git proceeds to show the help for > > With regard to "set to a positive integer", I'm not sure

Re: git fetch behaves weirdely when run in a worktree

2018-09-26 Thread Duy Nguyen
On Wed, Sep 26, 2018 at 6:46 AM Kaartic Sivaraam wrote: > This is the most interesting part of the issue. I **did not** run 'git fetch > ...' in between those cat commands. I was surprised by how the contents of > FETCH_HEAD are changing without me spawning any git processes that might >

Re: [PATCH] help: allow redirecting to help for aliased command

2018-09-26 Thread Duy Nguyen
On Wed, Sep 26, 2018 at 4:42 PM Taylor Blau wrote: > > + > > + /* > > + * We use split_cmdline() to get the first word of the > > + * alias, to ensure that we use the same rules as when > > + * the alias is actually used. split_cmdline() > > +

Re: [PATCH] help: allow redirecting to help for aliased command

2018-09-26 Thread Duy Nguyen
On Wed, Sep 26, 2018 at 12:29 PM Rasmus Villemoes wrote: > > I often use 'git --help' as a quick way to get the documentation > for a command. However, I've also trained my muscle memory to use my > aliases (cp=cherry-pick, co=checkout etc.), which means that I often end > up doing > > git cp

Re: [PATCH] help: allow redirecting to help for aliased command

2018-09-26 Thread Junio C Hamano
Rasmus Villemoes writes: > I often use 'git --help' as a quick way to get the documentation > for a command. However, I've also trained my muscle memory to use my > aliases (cp=cherry-pick, co=checkout etc.), which means that I often end > up doing > > git cp --help > > to which git correctly

Re: [PATCH] help: allow redirecting to help for aliased command

2018-09-26 Thread Taylor Blau
On Wed, Sep 26, 2018 at 12:26:36PM +0200, Rasmus Villemoes wrote: > I often use 'git --help' as a quick way to get the documentation > for a command. However, I've also trained my muscle memory to use my > aliases (cp=cherry-pick, co=checkout etc.), which means that I often end > up doing > >

Re: [PATCH] git.txt: mention mailing list archive

2018-09-26 Thread Taylor Blau
On Wed, Sep 26, 2018 at 10:05:29AM +0200, Martin Ågren wrote: > On Thu, 20 Sep 2018 at 21:07, Junio C Hamano wrote: > > > > Martin Ågren writes: > > > > > In the "Reporting Bugs" section of git(1), we refer to the mailing list, > > > but we do not give any hint about where the archives might be

Re: [PATCH v4 9/9] Documentation/config: add odb..promisorRemote

2018-09-26 Thread Taylor Blau
On Wed, Sep 26, 2018 at 12:12:22AM -0400, Jeff King wrote: > On Tue, Sep 25, 2018 at 03:31:36PM -0700, Junio C Hamano wrote: > > > Christian Couder writes: > > > > > The main issue that this patch series tries to solve is that > > > extensions.partialclone config option limits the partial clone

Re: [PATCH v2 2/3] transport.c: introduce core.alternateRefsCommand

2018-09-26 Thread Taylor Blau
On Tue, Sep 25, 2018 at 11:33:37PM -0400, Jeff King wrote: > On Tue, Sep 25, 2018 at 06:09:35PM -0700, Taylor Blau wrote: > > > > So I think this is fine (modulo that the grep and sed can be combined). > > > Yet another option would be to simply strip away everything except the > > > object id

  1   2   >