Re: Git Evolve

2018-09-30 Thread Stefan Xenos
> If we lose the Change-Id: footer without adding any new cruft in the > commit object header, that would be a great success. It would > be a failure if we end up touching the object header. Yes, I was thinking along the same lines. If obsolescence graph is stored as part of the commit header,

Re: [PATCH v9 09/21] stash: convert branch to builtin

2018-09-30 Thread Thomas Gummerer
On 09/26, Paul-Sebastian Ungureanu wrote: > From: Joel Teichroeb > > Add stash branch to the helper and delete the apply_to_branch > function from the shell script. > > Checkout does not currently provide a function for checking out > a branch as cmd_checkout does a large amount of sanity

Re: [PATCH v9 07/21] stash: convert apply to builtin

2018-09-30 Thread Thomas Gummerer
On 09/26, Paul-Sebastian Ungureanu wrote: > From: Joel Teichroeb > > Add a builtin helper for performing stash commands. Converting > all at once proved hard to review, so starting with just apply > lets conversion get started without the other commands being > finished. > > The helper is being

Re: [PATCH v9 04/21] stash: update test cases conform to coding guidelines

2018-09-30 Thread Thomas Gummerer
> Subject: stash: update test cases conform to coding guidelines s/stash/t3903/ s/conform/to &/ Alternatively the subject could also be "t3903: modernize style", which would be a bit shorter, and still convey the same information to a reader of 'git log --oneline'. On 09/26, Paul-Sebastian

Re: [Outreachy] Introduce myself

2018-09-30 Thread Christian Couder
Hi Ananya, On Sun, Sep 30, 2018 at 5:53 PM Ananya Krishna Maram wrote: > > Hi Git Community, Christian and Johannes, > > My initial Outreachy got accepted. Great! Welcome to the Git community! [...] > Having done a lot of assignment in C and > bash scripting and keen interest to learn about

Re: [PATCH v9 02/21] strbuf.c: add `strbuf_join_argv()`

2018-09-30 Thread Thomas Gummerer
On 09/26, Paul-Sebastian Ungureanu wrote: > Implement `strbuf_join_argv()` to join arguments > into a strbuf. > > Signed-off-by: Paul-Sebastian Ungureanu > --- > strbuf.c | 15 +++ > strbuf.h | 7 +++ > 2 files changed, 22 insertions(+) > > diff --git a/strbuf.c b/strbuf.c >

[Outreachy] Introduce myself

2018-09-30 Thread Ananya Krishna Maram
Hi Git Community, Christian and Johannes, My initial Outreachy got accepted. My name is Ananya Krishna(her), I am from south India. I completed my under-graduation. Due to some problems, I decided to stay back at home. And currently I would like to dedicate myself to learn from open communities.

Re: [PATCH v3 0/6] Fix the racy split index problem

2018-09-30 Thread SZEDER Gábor
Junio, On Fri, Sep 28, 2018 at 06:24:53PM +0200, SZEDER Gábor wrote: > Interdiff: > diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh > index c8acbc50d0..f053bf83eb 100755 > --- a/t/t1700-split-index.sh > +++ b/t/t1700-split-index.sh > @@ -6,6 +6,9 @@ test_description='split index

[PATCH v3 1/1] roll wt_status_state into wt_status and populate in the collect phase

2018-09-30 Thread Stephen P. Smith
Status variables were initialized in the collect phase and some variables were later freed in the print functions. A "struct wt_status" used to be sufficient for the output phase to work. It was designed to be filled in the collect phase and consumed in the output phase, but over time some

[PATCH v3 0/1] wt-status-state-cleanup

2018-09-30 Thread Stephen P. Smith
Junio suggested a cleanup patch, jc/wt-status-state-cleanup, which is the basis for this patch. This patch uses ss/wt-status-committable. Update to fix a spelling error in the commet message Stephen P. Smith (1): roll wt_status_state into wt_status and populate in the collect phase

Re: [PATCH v2 1/2] t1300: extract and use test_cmp_config()

2018-09-30 Thread SZEDER Gábor
On Sat, Sep 29, 2018 at 05:30:04PM +0200, Nguyễn Thái Ngọc Duy wrote: > In many config-related tests it's common to check if a config variable > has expected value and we want to print the differences when the test > fails. Doing it the normal way is three lines of shell code. Let's add > a

Re: [PATCH v2 2/2] worktree: add per-worktree config files

2018-09-30 Thread Duy Nguyen
On Sun, Sep 30, 2018 at 9:24 AM Eric Sunshine wrote: > > On Sun, Sep 30, 2018 at 3:16 AM Duy Nguyen wrote: > > On Sun, Sep 30, 2018 at 6:33 AM Eric Sunshine > > wrote: > > > > diff --git a/builtin/config.c b/builtin/config.c > > > > @@ -645,7 +649,20 @@ int cmd_config(int argc, const char

Re: [PATCH v2 2/2] worktree: add per-worktree config files

2018-09-30 Thread Eric Sunshine
On Sun, Sep 30, 2018 at 3:16 AM Duy Nguyen wrote: > On Sun, Sep 30, 2018 at 6:33 AM Eric Sunshine wrote: > > > diff --git a/builtin/config.c b/builtin/config.c > > > @@ -645,7 +649,20 @@ int cmd_config(int argc, const char **argv, const > > > char *prefix) > > > + else if

Re: [PATCH v2 2/2] worktree: add per-worktree config files

2018-09-30 Thread Duy Nguyen
On Sun, Sep 30, 2018 at 6:33 AM Eric Sunshine wrote: > > diff --git a/builtin/config.c b/builtin/config.c > > @@ -645,7 +649,20 @@ int cmd_config(int argc, const char **argv, const char > > *prefix) > > + else if (use_worktree_config) { > > + struct worktree **worktrees =