[PATCH v2 2/8] t4012: Unquote git command fragment in test title

The command fragments are quoted nowhere else in title texts of this file, thus make this one consistent with all other titles. Signed-off-by: Alexander Strasser Signed-off-by: Junio C Hamano --- t/t4012-diff-binary.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t4012

[PATCH v2 8/8] t4012: Use test_must_fail instead of if-else

Make the code less bulky and easier to read. Also do not overlook failures like e.g. git failing because of unexpected signals. Signed-off-by: Alexander Strasser --- t/t4012-diff-binary.sh | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/t/t4012-diff

[PATCH v2 7/8] t4012: use 'printf' instead of 'dd' to generate a binary file

machinery recognizes it as binary, use printf to generate it. Signed-off-by: Johannes Sixt Signed-off-by: Junio C Hamano Signed-off-by: Alexander Strasser --- t/t4012-diff-binary.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh ind

[PATCH v2 6/8] t4012: Re-indent test snippets

Most one-level indents were 1 HT (horizontal tab) followed by 1 SP. Remove the SP. Signed-off-by: Alexander Strasser Signed-off-by: Junio C Hamano --- t/t4012-diff-binary.sh | 68 +- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a

[PATCH v2 5/8] t4012: Make --shortstat test more robust

The --shortstat test depends on the same scenario as the --stat test. Use the part of the same expected result for the --stat test to avoid duplicating it manually. Signed-off-by: Alexander Strasser Signed-off-by: Junio C Hamano --- t/t4012-diff-binary.sh | 4 ++-- 1 file changed, 2 insertions

[PATCH v2 4/8] t4012: Break up pipe into serial redirections

Do not hide possible git errors by masking its process exit status. Signed-off-by: Alexander Strasser Signed-off-by: Junio C Hamano --- t/t4012-diff-binary.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh index 60c2f6c

[PATCH v2 3/8] t4012: Actually quote the sed script

the single quotes around the sed arguments would have also been possible. Signed-off-by: Alexander Strasser Signed-off-by: Junio C Hamano --- t/t4012-diff-binary.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh index

[PATCH v2 1/8] t4012: modernize style for quoting

This quoting style is used by all newly added test code. Signed-off-by: Alexander Strasser Signed-off-by: Junio C Hamano --- t/t4012-diff-binary.sh | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff

[PATCH v2 0/8] Cleaning up t4012

e included too. Alexander Strasser (7): t4012: modernize style for quoting t4012: Unquote git command fragment in test title t4012: Actually quote the sed script t4012: Break up pipe into serial redirections t4012: Make --shortstat test more robust t4012: Re-indent test snippets

Re: What's cooking in git.git (Jul 2012, #04; Fri, 13)

Hi, Junio C Hamano wrote: > Here are the topics that have been cooking. Commits prefixed with '-' are > only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. [...] > [New Topics] > > * as/t4012-style-updates (2012-07-12) 7 commits > - t4012: use 'printf' instead of 'dd'

Re: [PATCH 3/6] t4012: Actually quote the sed script

Hi Zbigniew, Zbigniew Jędrzejewski-Szmek wrote: > On 07/12/2012 12:12 AM, Alexander Strasser wrote: [...] > I have some spelling corrections (minor, but since you intend to re-roll > anyway, I'll post them), and one more thing which could be corrected > (below). > >

Re: [PATCH 7/6?] t4012: use 'printf' instead of 'dd' to generate a binary file

Hi, Johannes Sixt wrote: > From: Johannes Sixt > > For some reason, 'echo X | dd bs=1k seek=1' creates a file with 2050 bytes > on Windows instead of the expected 1026 bytes, so that a test fails. Since > the actual contents of the file are irrelevant as long as there is at > least one zero byt

Re: [PATCH 6/6] t4012: Make --shortstat more robust

Hi, seems I managed to omit a word in the short log message: t4012: Make --shortstat *test* more robust Junio C Hamano wrote: > Alexander Strasser writes: > > > The --shortstat test depends on the same scenario as the --stat > > test. Use the part of the same expected res

[PATCH 6/6] t4012: Make --shortstat more robust

The --shortstat test depends on the same scenario as the --stat test. Use the part of the same expected result for the --stat test to avoid duplicating it manually. Signed-off-by: Alexander Strasser --- t/t4012-diff-binary.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 4/6] t4012: Break up pipe into serial redirections

Do not hide possible git errors by masquerading its process exit status. Signed-off-by: Alexander Strasser --- t/t4012-diff-binary.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh index 60c2f6c..daf8234 100755 --- a/t/t4012

[PATCH 5/6] t4012: Re-indent test snippets

Most one-level indents were 1 HT (horizontal tab) followed by 1 SP. Remove the SP. Signed-off-by: Alexander Strasser --- t/t4012-diff-binary.sh | 68 +- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/t/t4012-diff-binary.sh b/t

[PATCH 3/6] t4012: Actually quote the sed script

dropping the single quotes around the sed arguments would have also been possible. Signed-off-by: Alexander Strasser --- t/t4012-diff-binary.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh index 3c54269..60c2f6c 100755

[PATCH 2/6] t4012: Unquote git command fragment in test title

The command fragments are quoted nowhere else in title texts of this file, thus make this one consistent with all other titles. Signed-off-by: Alexander Strasser --- t/t4012-diff-binary.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff

[PATCH 1/6] t4012: Use different style for quoting

This quoting style is used by all newly added test code. Signed-off-by: Alexander Strasser --- t/t4012-diff-binary.sh | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh index 6cebb39..2a8b68e

[PATCH 0/6] Cleaning up t4012

it easier to review/manage my changes for myself with a finer commit granularity). The patches can still be squashed together after review if this is preferred. Also thanks again to Zbigniew who pointed out most of the addressed issues. Alexander Strasser (6): t4012: Use different style for