Re: [PATCH] sequencer: require trailing NL in footers

2017-04-26 Thread Brian Norris
On Tue, Apr 25, 2017 at 03:30:56PM -0700, Brian Norris wrote: > On Tue, Apr 25, 2017 at 02:56:53PM -0700, Stefan Beller wrote: > > In that case: Is it needed to hint at how this bug occurred in the wild? > > (A different Git implementation, which may be fixed now?) > >

Re: [PATCH] sequencer: require trailing NL in footers

2017-04-25 Thread Brian Norris
On Tue, Apr 25, 2017 at 02:56:53PM -0700, Stefan Beller wrote: > In that case: Is it needed to hint at how this bug occurred in the wild? > (A different Git implementation, which may be fixed now?) I might contact the original author, but it's easy enough to imagine automated 'filter-branch' scrip

[GIT 2.12.2 REGRESSION] git cherry-pick -x

2017-04-21 Thread Brian Norris
Hi all, I haven't tried bisecting precisely, but somewhere along the way git cherry-pick -x regressed between 2.9.3 and 2.12.2. Looking at upstream linux.git, I can do: git fetch git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next git cherry-pick -x 7b309aef0463340d3ad5449d1f605d1

Re: [PATCH v2 3/3] http: expand http.cookieFile as a path

2016-05-04 Thread Brian Norris
On Wed, May 04, 2016 at 03:30:51PM -0400, Jeff King wrote: > On Wed, May 04, 2016 at 11:42:15AM -0700, Brian Norris wrote: > > > diff --git a/Documentation/config.txt b/Documentation/config.txt > > index e655b9729a7d..4c3cd7621ad0 100644 > > --- a/Documentation/config.txt

[PATCH] config: consistently format $variables in monospaced font

2016-05-04 Thread Brian Norris
We don't consistently use `backticks` for formatting shell variables. This patch improves the consistency on shell variables (and a few nearby mentions of "gpg" commands), though it still doesn't straighten out the use of "quotes." Signed-off-by: Brian Norris ---

[PATCH v2 1/3] config: describe 'pathname' value type

2016-05-04 Thread Brian Norris
`, `core.excludesFile`, and `commit.template` variables to clarify that the variables are of this type. Signed-off-by: Junio C Hamano Signed-off-by: Brian Norris --- v2: new Documentation/config.txt | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/Documentation

[PATCH v2 2/3] Documentation: config: improve word ordering for http.cookieFile

2016-05-04 Thread Brian Norris
Signed-off-by: Brian Norris --- v2: no change Documentation/config.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/config.txt b/Documentation/config.txt index 7264abf7f85e..e655b9729a7d 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt

[PATCH v2 3/3] http: expand http.cookieFile as a path

2016-05-04 Thread Brian Norris
This should handle .gitconfig files that specify things like: [http] cookieFile = "~/.gitcookies" Signed-off-by: Brian Norris --- v2: rework documentation now that 'pathname' is documented centrally Documentation/config.txt | 3 ++- http.c | 2 +-

Re: [PATCH 2/2] http: expand http.cookieFile as a path

2016-04-29 Thread Brian Norris
On Fri, Apr 29, 2016 at 10:12:12AM -0400, Jeff King wrote: > On Fri, Apr 29, 2016 at 12:23:57AM -0600, Brian Norris wrote: > > > This should handle .gitconfig files that specify things like: > > > > [http] > > cookieFile = "~/.gitcookies" > >

[PATCH 2/2] http: expand http.cookieFile as a path

2016-04-28 Thread Brian Norris
This should handle .gitconfig files that specify things like: [http] cookieFile = "~/.gitcookies" Signed-off-by: Brian Norris --- Documentation/config.txt | 3 +++ http.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/co

[PATCH 1/2] Documentation: config: improve word ordering for http.cookieFile

2016-04-28 Thread Brian Norris
Signed-off-by: Brian Norris --- Documentation/config.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/config.txt b/Documentation/config.txt index 42d2b50477b2..a775ad885a76 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -1660,7

Re: [BUG] git-log: tracking deleted file in a repository with multiple "initial commit" histories

2016-02-18 Thread Brian Norris
On Tue, Feb 16, 2016 at 05:29:42PM -0500, Jeff King wrote: > On Tue, Feb 16, 2016 at 01:24:29PM -0800, Brian Norris wrote: > > > On Tue, Feb 16, 2016 at 03:45:57PM -0500, Jeff King wrote: > > > See the section on History Simplification in git-log. But basically, > > &g

Re: [BUG] git-log: tracking deleted file in a repository with multiple "initial commit" histories

2016-02-16 Thread Brian Norris
On Tue, Feb 16, 2016 at 03:45:57PM -0500, Jeff King wrote: > See the section on History Simplification in git-log. But basically, > when you specify a pathspec, git does not traverse side branches that > had no effect on the given pathspec. Thanks for the pointer. Is this done primarily for perfor

[BUG] git-log: tracking deleted file in a repository with multiple "initial commit" histories

2016-02-16 Thread Brian Norris
Hi, I'm not sure if this is a known behavior or a new bug report. I at least couldn't find anyone mentioning this exact problem. I'm using a git repository that has multiple "inital commits" (i.e., a few different directory trees were imported via svn-to-git as different branches) whose histories

Re: [PATCH] send-email: fix uninitialized var warning for $smtp_auth

2015-09-18 Thread Brian Norris
On Fri, Sep 18, 2015 at 06:47:20PM -0400, Eric Sunshine wrote: > Makes sense (again). Thanks for the explanation. No problem. Thanks for the review. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http:

Re: [PATCH] send-email: fix uninitialized var warning for $smtp_auth

2015-09-18 Thread Brian Norris
On Fri, Sep 18, 2015 at 06:25:24PM -0400, Eric Sunshine wrote: > On Fri, Sep 18, 2015 at 03:12:50PM -0700, Brian Norris wrote: > > --- a/git-send-email.perl > > +++ b/git-send-email.perl > > @@ -1136,7 +1136,7 @@ sub smtp_auth_maybe { > > > > # Che

[PATCH] send-email: fix uninitialized var warning for $smtp_auth

2015-09-18 Thread Brian Norris
On the latest version of git-send-email, I see this error just before running SMTP auth (I didn't provide any --smtp-auth= parameter): Use of uninitialized value $smtp_auth in pattern match (m//) at /usr/local/google/home/briannorris/git/git/git-send-email.perl line 1139. Signed-off-by:

git-fetch: default globally to --no-tags

2014-11-18 Thread Brian Norris
Hi, I have one main concern, and I can envision a few ways that git could solve it. I also see that there has been some previous discussion on reltaed topics over the years, but as far as I can tell, nothing has actually been implemented to address my concern. --- My concern --- When I fetch fro