[PATCH 12/40] rev-list: support termination at promisor objects

From: Jonathan Tan Teach rev-list to support termination of an object traversal at any object from a promisor remote (whether one that the local repo also has, or one that the local repo knows about because it has another promisor object that references it). This will

[PATCH 08/40] index-pack: refactor writing of .keep files

From: Jonathan Tan In a subsequent commit, index-pack will be taught to write ".promisor" files which are similar to the ".keep" files it knows how to write. Refactor the writing of ".keep" files, so that the implementation of writing ".promisor" files becomes easier.

[PATCH 32/40] odb-helper: add init_object_process()

This adds the infrastructure to launch and use long running sub-processes as external odb helpers. For now only the 'init' and 'get_direct' capabilities are supported with sub-processes. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- external-odb.c | 46 +++--- odb-he

[PATCH 29/40] Add t0420 to test transfer to HTTP external odb

This tests that an apache web server can be used as an external object database and store files in their native format instead of converting them to a Git object. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0420-transfer-http-e-odb.sh

[PATCH 18/40] t0400: add 'put_raw_obj' instruction to odb-helper script

odb-helper script works well. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0400-external-odb.sh | 24 1 file changed, 24 insertions(+) diff --git a/t/t0400-external-odb.sh b/t/t0400-external-odb.sh index 977fea852d..4ccca1e965 100755 --- a/t

[PATCH 27/40] odb-helper: add odb_helper_get_raw_object()

The existing odb_helper_get_object() is renamed odb_helper_get_git_object() and a new odb_helper_get_raw_object() is introduced to deal with external objects that are not in Git format. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- odb-helper.c

[PATCH 21/40] t0400: add test for external odb write support

Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0400-external-odb.sh | 8 1 file changed, 8 insertions(+) diff --git a/t/t0400-external-odb.sh b/t/t0400-external-odb.sh index 4ccca1e965..f924de870f 100755 --- a/t/t0400-external-odb.sh +++ b/t/t0400-external-

Re: [PATCH] diff-tree: obey the color.ui configuration

On Sat, Dec 30, 2017 at 7:15 PM, Jeff King wrote: > On Sat, Dec 30, 2017 at 04:04:50PM +0100, Ævar Arnfjörð Bjarmason wrote: > >> > I do like the idea of using "show", though. We know the point is to show >> > the output to the user, so we don't mind at all if the behavior or >> >

Re: [PATCH v2 0/7] Codespeed perf results

On Tue, Dec 26, 2017 at 10:59 PM, Christian Couder <christian.cou...@gmail.com> wrote: > Changes since previous version > ~~ > > - Fixed the way the 'executable' field sent to Codespeed is set in > `perf/aggregate.perl` in patch 3/7. We

[PATCH v2 0/7] Codespeed perf results

ssions about the cc/perf-run-config patch series: v1: https://public-inbox.org/git/20170713065050.19215-1-chrisc...@tuxfamily.org/ v2: https://public-inbox.org/git/cap8ufd2j-ufh+9awz91gtz-jusq7euoexmguro59vpf29jx...@mail.gmail.com/ Christian Couder (7): perf/aggregate: fix checking ENV{GIT_PERF_SU

[PATCH v2 6/7] perf/run: learn to send output to codespeed server

in Codespeed. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/run | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/t/perf/run b/t/perf/run index 4e62d6bb3f..ef56396546 100755 --- a/t/perf/run +++ b/t/perf/run @@ -148,10 +148,20 @@ run_subs

[PATCH v2 7/7] perf/run: read GIT_TEST_REPO_NAME from perf.repoName

The GIT_PERF_REPO_NAME env variable is used in the `aggregate.perl` script to set the 'environment' field in the JSON Codespeed output. Let's make it easy to set this variable by setting it in a config file. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/run | 3

[PATCH v2 1/7] perf/aggregate: fix checking ENV{GIT_PERF_SUBSECTION}

Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/aggregate.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl index e401208488..769d418708 100755 --- a/t/perf/aggregate.perl +++ b/t/perf/aggregat

[PATCH v2 3/7] perf/aggregate: implement codespeed JSON output

performance evolves over time and releases, let's implement a Codespeed output in "perf/aggregate.perl". Helped-by: Eric Sunshine <sunsh...@sunshineco.com> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/pe

[PATCH v2 4/7] perf/run: add conf_opts argument to get_var_from_env_or_config()

value argument to be unset if it is not passed, and this is simpler if it is the last argument. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/run | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/t/perf/run b/t/perf/run index 43e4

[PATCH v2 2/7] perf/aggregate: refactor printing results

As we want to implement another kind of output than the current output for the perf test results, let's refactor the existing code that outputs the results in its own print_default_results() function. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/aggregate.per

[PATCH v2 5/7] perf/run: learn about perf.codespeedOutput

Let's make it possible to set in a config file the output format (regular or codespeed) of the perf tests. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/run | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/t/perf/run b/t/perf/run index 214d

[ANNOUNCE] Git Rev News edition 34

Hi everyone, The 34th edition of Git Rev News is now published: https://git.github.io/rev_news/2017/12/20/edition-34/ Thanks a lot to all the contributors and helpers! Enjoy, Christian, Jakub and Markus.

Draft of Git Rev News edition 34

Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-34.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub

Re: [PATCH v7] fixup: rev-list-options text

On Thu, Dec 14, 2017 at 10:19 PM, Jeff Hostetler wrote: > --- a/Documentation/rev-list-options.txt > +++ b/Documentation/rev-list-options.txt > @@ -714,9 +714,9 @@ ifdef::git-rev-list[] > + > The form '--filter=blob:none' omits all blobs. > + > -The form

Re: [PATCH 4/8] perf/run: use $default_value instead of $4

On Wed, Dec 13, 2017 at 9:54 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> If you want to be able to use this helper to specify a default value >> of an empty string (which the orignal that used $4 did), then the >> previous hunk must be corrected

Re: [PATCH 4/8] perf/run: use $default_value instead of $4

On Wed, Dec 13, 2017 at 9:40 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> >> --- >> t/perf/run | 4 ++-- >> 1 file changed, 2 in

Re: [PATCH 3/8] perf/aggregate: implement codespeed JSON output

On Wed, Dec 13, 2017 at 9:33 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> my $resultsdir = "test-results"; >> +my $results_section = ""; >> if (exists $E

Re: [PATCH 3/8] perf/aggregate: implement codespeed JSON output

On Wed, Dec 13, 2017 at 7:25 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Wed, Dec 13, 2017 at 10:13 AM, Christian Couder > <christian.cou...@gmail.com> wrote: >> Codespeed (https://github.com/tobami/codespeed/) is an open source >> project that can be u

Re: [PATCH 0/8] Codespeed perf results

On Wed, Dec 13, 2017 at 5:02 PM, Philip Oakley wrote: >> The end goal would be to have such a server always available to track >> how the different git commands perform over time on different kind of >> repos (small, medium, large, ...) with different optimizations on and

[PATCH 6/8] perf/run: learn about perf.codespeedOutput

Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/run | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/t/perf/run b/t/perf/run index 04ea5090f9..4454a2713d 100755 --- a/t/perf/run +++ b/t/perf/run @@ -144,10 +144,15 @@ run_subs

[PATCH 5/8] perf/run: add conf_opts argument to get_var_from_env_or_config()

Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/run | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/t/perf/run b/t/perf/run index bbd703dc4f..04ea5090f9 100755 --- a/t/perf/run +++ b/t/perf/run @@ -106,6 +106,7 @@ get_var_from_env_or_

[PATCH 2/8] perf/aggregate: refactor printing results

Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/aggregate.perl | 96 +++ 1 file changed, 50 insertions(+), 46 deletions(-) diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl index 769d418708..3609cb5dc3 100755 -

[PATCH 1/8] perf/aggregate: fix checking ENV{GIT_PERF_SUBSECTION}

Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/aggregate.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl index e401208488..769d418708 100755 --- a/t/perf/aggregate.perl +++ b/t/perf/aggregat

[PATCH 3/8] perf/aggregate: implement codespeed JSON output

performance evolves over time and releases, let's implement a Codespeed output in "perf/aggregate.perl". Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/aggregate.perl | 68 +-- 1 file changed, 66 insertions

[PATCH 7/8] perf/run: learn to send output to codespeed server

Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/run | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/t/perf/run b/t/perf/run index 4454a2713d..7b7011f19b 100755 --- a/t/perf/run +++ b/t/perf/run @@ -148,10 +148,20 @@ run_subs

[PATCH 8/8] perf/run: read GIT_TEST_REPO_NAME from perf.repoName

Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/run | 3 +++ 1 file changed, 3 insertions(+) diff --git a/t/perf/run b/t/perf/run index 7b7011f19b..279c2d41f6 100755 --- a/t/perf/run +++ b/t/perf/run @@ -137,6 +137,9 @@ run_subsection () { get_var_from_env_or_

[PATCH 4/8] perf/run: use $default_value instead of $4

Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/perf/run | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/perf/run b/t/perf/run index 43e4de49ef..bbd703dc4f 100755 --- a/t/perf/run +++ b/t/perf/run @@ -105,7 +105,7 @@ get_var_from_env_or_

[PATCH 0/8] Codespeed perf results

series is available here: https://github.com/chriscool/git/commits/codespeed The cc/perf-run-config patch series was discussed here: v1: https://public-inbox.org/git/20170713065050.19215-1-chrisc...@tuxfamily.org/ v2: https://public-inbox.org/git/cap8ufd2j-ufh+9awz91gtz-jusq7euoexmguro59vpf29j

Re: What's cooking in git.git (Dec 2017, #02; Thu, 7)

On Thu, Dec 7, 2017 at 7:04 PM, Junio C Hamano wrote: > > * jh/object-filtering (2017-12-05) 9 commits > (merged to 'next' on 2017-12-05 at 3a56b51085) > + rev-list: support --no-filter argument > + list-objects-filter-options: support --no-filter > +

Re: [PATCH v6 3/3] rev-list: support --no-filter argument

On Tue, Dec 5, 2017 at 5:50 PM, Jeff Hostetler wrote: > From: Jeff Hostetler > > Teach rev-list to support --no-filter to override a > previous --filter= argument. This is > to be consistent with commands that use OPT_PARSE > macros. > >

Re: [PATCH v3 1/7] git-compat-util: introduce skip_to_optional_arg()

On Sun, Dec 10, 2017 at 3:39 PM, Jeff King <p...@peff.net> wrote: > On Sun, Dec 10, 2017 at 09:31:18AM -0500, Jeff King wrote: > >> On Sat, Dec 09, 2017 at 09:40:07PM +0100, Christian Couder wrote: >> >> > The changes compared to v2 are: >> > >>

[PATCH v3 6/7] diff: add tests for --relative without optional prefix value

From: Jacob Keller We already have tests for --relative, but they currently only test when a prefix has been provided. This fails to test the case where --relative by itself should use the current directory as the prefix. Teach the check_$type functions to take a

[PATCH v3 1/7] git-compat-util: introduce skip_to_optional_arg()

From: Christian Couder <christian.cou...@gmail.com> We often accept both a "--key" option and a "--key=" option. These options currently are parsed using something like: if (!strcmp(arg, "--key")) { /* do something */ } else if (skip_prefix(arg, &q

[PATCH v3 4/7] diff: use skip_to_optional_arg_default()

From: Christian Couder <christian.cou...@gmail.com> Let's simplify diff option parsing using skip_to_optional_arg_default(). Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Junio C Hamano <gits...@pobox.com> --- diff.c | 20

[PATCH v3 5/7] diff: use skip_to_optional_arg_default() in parsing --relative

From: Junio C Hamano Helped-by: Jacob Keller Helped-by: Jeff King Signed-off-by: Junio C Hamano --- diff.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/diff.c b/diff.c index

[PATCH v3 7/7] t4045: reindent to make helpers readable

From: Junio C Hamano Signed-off-by: Junio C Hamano --- t/t4045-diff-relative.sh | 104 +-- 1 file changed, 56 insertions(+), 48 deletions(-) diff --git a/t/t4045-diff-relative.sh b/t/t4045-diff-relative.sh index

[PATCH v3 2/7] index-pack: use skip_to_optional_arg()

From: Christian Couder <christian.cou...@gmail.com> Let's simplify index-pack option parsing using skip_to_optional_arg(). Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Junio C Hamano <gits...@pobox.com> --- builtin/index-pack.c | 11 +++

[PATCH v3 3/7] diff: use skip_to_optional_arg()

From: Christian Couder <christian.cou...@gmail.com> Let's simplify diff option parsing using skip_to_optional_arg(). Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> Signed-off-by: Junio C Hamano <gits...@pobox.com> --- diff.c | 23 +-- 1 file cha

Re: What's cooking in git.git (Dec 2017, #02; Thu, 7)

On Thu, Dec 7, 2017 at 7:04 PM, Junio C Hamano wrote: > * cc/skip-to-optional-val (2017-12-07) 7 commits > - t4045: test 'diff --relative' for real > - t4045: reindent to make helpers readable > - diff: use skip-to-optional-val in parsing --relative > - diff: use

Re: git commit file completion recently broke

On Thu, Dec 7, 2017 at 1:56 AM, Jeff King wrote: > I think we'd do better to just assign NULL when there's "=", so we can > tell the difference between "--relative", "--relative=", and > "--relative=foo" (all of which are distinct). > > I think that's possible with the current

Re: [PATCH 3/3] diff: use skip_to_opt_val()

On Thu, Dec 7, 2017 at 1:18 AM, Jacob Keller wrote: > On Wed, Dec 6, 2017 at 4:16 PM, Jacob Keller wrote: >> >> This causes a regression in the --relative option which prevents it >> from working properly. >> >> If I have a repository with a

[PATCH v2 2/4] index-pack: use skip_to_optional_val()

From: Christian Couder <christian.cou...@gmail.com> Let's simplify index-pack option parsing using skip_to_optional_val(). Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/index-pack.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --g

[PATCH v2 4/4] diff: use skip_to_optional_val_default()

Let's simplify diff option parsing using skip_to_optional_val_default(). Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- diff.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/diff.c b/diff.c index 83509f0658..d234b4f0cb 100644 --- a/

[PATCH v2 1/4] git-compat-util: introduce skip_to_optional_val()

From: Christian Couder <christian.cou...@gmail.com> We often accept both a "--key" option and a "--key=" option. These options currently are parsed using something like: if (!strcmp(arg, "--key")) { /* do something */ } else if (skip_prefix(arg, &q

[PATCH v2 3/4] diff: use skip_to_optional_val()

From: Christian Couder <christian.cou...@gmail.com> Let's simplify diff option parsing using skip_to_optional_val(). Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- diff.c | 29 ++--- 1 file changed, 10 insertions(+), 19 deletions(-) diff --gi

Re: [PATCH 1/3] git-compat-util: introduce skip_to_opt_val()

On Sun, Dec 3, 2017 at 11:48 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> Anyway there is a design choice to be made. Adding a "const char >> *default" argument makes the function more g

Re: [PATCH 1/3] git-compat-util: introduce skip_to_opt_val()

On Sun, Dec 3, 2017 at 7:45 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> From: Christian Couder <christian.cou...@gmail.com> >> >> We often accept both a "--key" option and a "

[PATCH 2/3] index-pack: use skip_to_opt_val()

From: Christian Couder <christian.cou...@gmail.com> Let's simplify index-pack option parsing using skip_to_opt_val(). Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/index-pack.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/b

[PATCH 1/3] git-compat-util: introduce skip_to_opt_val()

From: Christian Couder <christian.cou...@gmail.com> We often accept both a "--key" option and a "--key=" option. These options currently are parsed using something like: if (!strcmp(arg, "--key")) { /* do something */ } else if (skip_prefix(arg, &q

[PATCH 3/3] diff: use skip_to_opt_val()

From: Christian Couder <christian.cou...@gmail.com> Let's simplify diff option parsing using skip_to_opt_val(). Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- diff.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/diff.c b/

[PATCH] list-objects-filter-options: fix 'keword' typo in comment

From: Christian Couder <christian.cou...@gmail.com> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- list-objects-filter-options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c inde

Re: [PATCH v5 07/10] introduce fetch-object: fetch one promisor object

On Tue, Nov 21, 2017 at 10:07 PM, Jeff Hostetler wrote: > From: Jonathan Tan > +void fetch_object(const char *remote_name, const unsigned char *sha1) > +{ > + struct remote *remote; > + struct transport *transport; > + struct

Re: [PATCH v5 08/10] sha1_file: support lazily fetching missing objects

On Tue, Nov 21, 2017 at 10:07 PM, Jeff Hostetler wrote: > From: Jonathan Tan > diff --git a/sha1_file.c b/sha1_file.c > index 10c3a00..fc7718a 100644 > --- a/sha1_file.c > +++ b/sha1_file.c > @@ -29,6 +29,7 @@ > #include "mergesort.h" >

Re: [PATCH v5 10/10] gc: do not repack promisor packfiles

On Tue, Nov 21, 2017 at 10:07 PM, Jeff Hostetler wrote: > From: Jonathan Tan > pack_as_from_promisor () { > HASH=$(git -C repo pack-objects .git/objects/pack/pack) && > >repo/.git/objects/pack/pack-$HASH.promisor > + echo

Re: [PATCH] travis-ci: avoid new tcl/tk build requirement

On Tue, Nov 28, 2017 at 3:37 PM, Todd Zullinger wrote: > A build requirement on tcl/tk was added in 01c54284f1 (Makefile: check > that tcl/tk is installed, 2017-11-20). For building and running the > tests, we don't need tcl/tk installed. Bypass the requirement. > >

Re: [PATCH] Makefile: check that tcl/tk is installed

On Mon, Nov 27, 2017 at 5:35 AM, Jeff King wrote: > On Mon, Nov 27, 2017 at 01:31:13PM +0900, Junio C Hamano wrote: > >> Junio C Hamano writes: >> >> > Perhaps the "else" part of the above should become a bit more >> > careful, something along the lines of... >>

Re: [PATCH] Makefile: check that tcl/tk is installed

On Sun, Nov 26, 2017 at 8:15 PM, Jeff King <p...@peff.net> wrote: > On Tue, Nov 21, 2017 at 12:58:17AM +0100, Christian Couder wrote: > >> > Can you say more about where this comes up? >> >> The original discussion is: >> >> https://public-in

Re: [PATCH] Makefile: check that tcl/tk is installed

On Sun, Nov 26, 2017 at 6:43 PM, Ramsay Jones <ram...@ramsayjones.plus.com> wrote: > > > On 26/11/17 14:00, Christian Couder wrote: >> On Sun, Nov 26, 2017 at 4:53 AM, Junio C Hamano <gits...@pobox.com> wrote: >>> Christian Couder <christian.cou...@gmail.com

Re: [PATCH] Makefile: check that tcl/tk is installed

On Sun, Nov 26, 2017 at 4:53 AM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> On Mon, Nov 20, 2017 at 6:15 PM, Christian Couder >> <christian.cou...@gmail.com> wrote: >>> By default

Re: [PATCH] Makefile: check that tcl/tk is installed

On Mon, Nov 20, 2017 at 6:15 PM, Christian Couder <christian.cou...@gmail.com> wrote: > By default running `make install` in the root directory of the > project will set TCLTK_PATH to `wish` and then go into the "git-gui" > and "gitk-git" sub-directories to build

Re: Bisect marking new commits incorrectly

On Wed, Nov 22, 2017 at 3:39 PM, Adam Dinwoodie wrote: > In trying to do a bisect on the Git repository, I seem to have come > across surprising behavior where the order in which `git bisect` appears > to forget that previous commits were marked as new. Yeah, the algorithm

[ANNOUNCE] Git Rev News edition 33

Hi everyone, The 33rd edition of Git Rev News is now published: https://git.github.io/rev_news/2017/11/22/edition-33/ Thanks a lot to all the contributors and helpers! Enjoy, Christian, Thomas, Jakub and Markus.

Re: [PATCH 1/2] Git/Packet.pm: rename packet_required_key_val_read()

On Wed, Nov 22, 2017 at 7:28 AM, Junio C Hamano wrote: > Jonathan Nieder writes: > This comment doesn't tell me how to use the function. How do I detect whether it successfully read a line? What do the return values represent? What happens

[PATCH 1/2] Git/Packet.pm: rename packet_required_key_val_read()

The function calls itself "required", but it does not die when it sees an unexpected EOF. Let's rename it to "packet_key_val_read()". Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- These 2 patches are a late follow up from: https://public-inbox.org/

[PATCH 2/2] Git/Packet.pm: use 'if' instead of 'unless'

The code is more understandable with 'if' instead of 'unless'. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- perl/Git/Packet.pm | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/perl/Git/Packet.pm b/perl/Git/Packet.pm index 82da

Re: Draft of Git Rev News edition 33

On Tue, Nov 21, 2017 at 2:12 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> On Tue, Nov 21, 2017 at 2:10 AM, Jonathan Nieder <jrnie...@gmail.com> wrote: >>> >>> That said, I believe that t

Re: Draft of Git Rev News edition 33

On Tue, Nov 21, 2017 at 2:10 AM, Jonathan Nieder wrote: > > That said, I believe that the gitattributes(5) manpage does an okay > job of covering this and that that thread came to a clear conclusion: > > >

Re: [PATCH] Makefile: check that tcl/tk is installed

Hi, On Mon, Nov 20, 2017 at 8:19 PM, Jonathan Nieder <jrnie...@gmail.com> wrote: > Hi, > > Christian Couder wrote: > >> By default running `make install` in the root directory of the >> project will set TCLTK_PATH to `wish` and then go into the "git-gui" &g

Re: [PATCH] Makefile: check that tcl/tk is installed

On Fri, Nov 17, 2017 at 6:42 PM, Todd Zullinger <t...@pobox.com> wrote: > Christian Couder wrote: >> >> On Thu, Nov 16, 2017 at 2:35 AM, Junio C Hamano <gits...@pobox.com> wrote: >>> >>> I suspect that this change will hurt those who package Git for

Re: [PATCH] Makefile: check that tcl/tk is installed

On Fri, Nov 17, 2017 at 11:02 PM, Jeff King wrote: > > I'm actually tempted to say that we should not be building the tcl parts > by default. IOW, instead of NO_TCLTK we should have USE_TCLTK. That > would also require an adjustment by package builders, but it would > hopefully be

Re: [PATCH] Makefile: check that tcl/tk is installed

(Sorry I forgot to mark this as v2.) On Mon, Nov 20, 2017 at 6:15 PM, Christian Couder <christian.cou...@gmail.com> wrote: > By default running `make install` in the root directory of the > project will set TCLTK_PATH to `wish` and then go into the "git-gui" > and &

[PATCH] Makefile: check that tcl/tk is installed

mall additional step they will have to make, but it might be a good thing as it will not install what they don't want and it will build a bit faster. For packagers who want to build git-gui and gitk even if Tcl/Tk is not installed, we provide the new BYPASS_TCLTK_CHECK variable. Signed-off-by: Chri

Draft of Git Rev News edition 33

Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-33.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub

Re: [PATCH v16 6/6] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C

On Mon, Nov 20, 2017 at 4:05 AM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> On Fri, Sep 29, 2017 at 8:49 AM, Pranit Bauva <pranit.ba...@gmail.com> wrote: >>> Reimplement `is_expected_rev` & `c

Re: [PATCH v16 6/6] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C

On Fri, Sep 29, 2017 at 8:49 AM, Pranit Bauva wrote: > Reimplement `is_expected_rev` & `check_expected_revs` shell function in > C and add a `--check-expected-revs` subcommand to `git bisect--helper` to > call it from git-bisect.sh . It looks like this patch forgot to add

Re: [PATCH] Makefile: check that tcl/tk is installed

On Thu, Nov 16, 2017 at 2:35 AM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> To improve the current behavior when Tcl/Tk is not installed, >> let's just check that TCLTK_PATH points to somethi

Re: [PATCH v2 1/9] perf/run: add '--config' option to the 'run' script

On Mon, Oct 16, 2017 at 7:25 AM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <chrisc...@tuxfamily.org> writes: > >> It is error prone and tiring to use many long environment >> variables to give parameters to the 'run' script. > > This topic

[PATCH] Makefile: check that tcl/tk is installed

mall additional step they will have to make, but it might be a good thing as it will not install what they don't want and it will build a bit faster. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Makefile | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Makefile b

Re: no mountable file systems

On Mon, Nov 13, 2017 at 10:35 PM, Louis Gruand wrote: > Dear team, when i download Git on Mac it says “no mountable file systems” and > doesnt open after. how can i solve this? When googling "Mac no mountable file systems", it looks like this error is not specific

Re: [PATCH V2] config: add --expiry-date

On Tue, Nov 14, 2017 at 3:04 AM, wrote: > From: Haaris > > Description: > This patch adds a new option to the config command. > > Uses flag --expiry-date as a data-type to covert date-strings to > timestamps when reading from config files (GET). > This flag

Re: NO_MSGFMT

On Sun, Nov 12, 2017 at 12:57 PM, Jeff King wrote: > On Sun, Aug 13, 2017 at 12:58:13AM -0400, Jeff King wrote: > >> On Sat, Aug 12, 2017 at 03:44:17PM +0200, Dominik Mahrer (Teddy) wrote: >> >> > Hi all >> > >> > I'm compiling git from source code on a mashine without msgfmt. This

Re: should "git bisect" support "git bisect next?"

On Sun, Nov 12, 2017 at 2:43 AM, Junio C Hamano wrote: > Theodore Ts'o writes: > >> On Sat, Nov 11, 2017 at 11:38:23PM +0900, Junio C Hamano wrote: >>> >>> Thanks for saving me time to explain why 'next' is still a very >>> important command but the end users do

Re: should "git bisect" support "git bisect next?"

On Sat, Nov 11, 2017 at 12:42 PM, Robert P. J. Day wrote: > > the man page for "git bisect" makes no mention of "git bisect next", > but the script git-bisect.sh does: Yeah the following patch was related:

Re: [PATCH v2] bisect: mention "view" as an alternative to "visualize"

On Sat, Nov 11, 2017 at 11:31 AM, Robert P. J. Day wrote: > Tweak a number of files to mention "view" as an alternative to > "visualize". Good idea. > @@ -196,15 +196,14 @@ of `git bisect good` and `git bisect bad` to mark > commits. > Bisect visualize >

Re: "git bisect" takes exactly one bad commit and one or more good?

On Sat, Nov 11, 2017 at 12:22 PM, Robert P. J. Day wrote: > > more on "git bisect" ... the man page seems to make it clear that > bisection takes *precisely* one "bad" commit, and one *or more* good > commits, is that correct? Yeah, that's true. > seems that way, given

[PATCH v3 8/8] Add Git/Packet.pm from parts of t0021/rot13-filter.pl

And while at it let's simplify t0021/rot13-filter.pl by using Git/Packet.pm. This will make it possible to reuse packet related functions in other test scripts. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- perl/Git/Packet.pm

[PATCH v3 7/8] t0021/rot13-filter: add capability functions

can still require a set of capabilities, and die if one of them is not supported. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0021/rot13-filter.pl | 58 ++--- 1 file changed, 45 insertions(+), 13 deletions(-) diff --git a/t

[PATCH v3 6/8] t0021/rot13-filter: refactor checking final lf

As checking for a lf character at the end of a buffer will be useful in another function, let's refactor this functionality into a small remove_final_lf_or_die() helper function. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0021/rot13-filter.pl | 16

[PATCH v3 5/8] t0021/rot13-filter: add packet_initialize()

Let's refactor the code to initialize communication into its own packet_initialize() function, so that we can reuse this functionality in following patches. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0021/rot13-filter.pl | 26 -- 1 file chang

[PATCH v3 3/8] t0021/rot13-filter: improve 'if .. elsif .. else' style

Before further refactoring the "t0021/rot13-filter.pl" script, let's modernize the style of its 'if .. elsif .. else' clauses to improve its readability by making it more similar to our other perl scripts. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0021/rot1

[PATCH v3 4/8] t0021/rot13-filter: improve error message

If there is no new line at the end of something it receives, the packet_txt_read() function die()s, but it's difficult to debug without much context. Let's give a bit more information when that happens. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0021/rot13-filter.

[PATCH v3 2/8] t0021/rot13-filter: refactor packet reading functions

. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0021/rot13-filter.pl | 43 +++ 1 file changed, 31 insertions(+), 12 deletions(-) diff --git a/t/t0021/rot13-filter.pl b/t/t0021/rot13-filter.pl index 4b2d9087d4..b1909699f4 100644 --- a/t

[PATCH v3 0/8] Create Git/Packet.pm

g branches: https://github.com/chriscool/git/commits/gl-external-odb12 https://github.com/chriscool/git/commits/gl-external-odb22 https://github.com/chriscool/git/commits/gl-external-odb61 https://github.com/chriscool/git/commits/gl-external-odb239 https://github.com/chriscool/git/commits/gl-exte

[PATCH v3 1/8] t0021/rot13-filter: fix list comparison

not what we want. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t0021/rot13-filter.pl | 35 --- 1 file changed, 28 insertions(+), 7 deletions(-) diff --git a/t/t0021/rot13-filter.pl b/t/t0021/rot13-filter.pl index ad685d92f8..4b2d9087d4

<    1   2   3   4   5   6   7   8   9   10   >