0.
Helpers defined using the existing "odb..scriptcommand"
are marked with the 'script_mode' field set to 1.
Implementation of the different capabilities/instructions in
the new (sub-)process mode is left for following commits.
Signed-off-by: Christian Couder
---
exter
This makes it possible to start an apache web server with different
config files.
This will be used in a later patch to pass a config file that makes
apache store external objects.
Signed-off-by: Christian Couder
---
t/lib-httpd.sh | 6 --
1 file changed, 4 insertions(+), 2 deletions
From: Jonathan Tan
Introduce fetch-object, providing the ability to fetch one object from a
promisor remote.
This uses fetch-pack. To do this, the transport mechanism has been
updated with 2 flags, "from-promisor" to indicate that the resulting
pack comes from a promisor remote (and thus should
From: Jonathan Tan
Teach sha1_file to fetch objects from the remote configured in
extensions.partialclone whenever an object is requested but missing.
The fetching of objects can be suppressed through a global variable.
This is used by fsck and index-pack.
However, by default, such fetching is
Objects managed by an external ODB should not be put into
pack files. They should be transfered using other mechanism
that can be specific to the external odb.
Signed-off-by: Christian Couder
---
builtin/pack-objects.c | 4
1 file changed, 4 insertions(+)
diff --git a/builtin/pack
ave the same kind of mechanism to "put" objects
into an external odb, where the odb helper would access blobs it
wants to send to an external odb directly from files, but it
would be strange to call that a fault-in mode too.
Signed-off-by: Christian Couder
---
exte
This cgi will be used to upload objects to, or to delete
objects from, an apache web server.
This way the apache server can work as an external object
database.
Signed-off-by: Christian Couder
---
t/lib-httpd.sh| 1 +
t/lib-httpd/upload.sh | 45
This cgi script can list Git objects that have been uploaded as
files to an apache web server. This script can also retrieve
the content of each of these files.
This will help make apache work as an external object database.
Signed-off-by: Christian Couder
---
t/lib-httpd.sh | 1 +
t/lib
From: Jonathan Tan
Teach rev-list to support termination of an object traversal at any
object from a promisor remote (whether one that the local repo also has,
or one that the local repo knows about because it has another promisor
object that references it).
This will be used subsequently in gc
From: Jonathan Tan
In a subsequent commit, index-pack will be taught to write ".promisor"
files which are similar to the ".keep" files it knows how to write.
Refactor the writing of ".keep" files, so that the implementation of
writing ".promisor" files becomes easier.
Signed-off-by: Jonathan Tan
This adds the infrastructure to launch and use long running
sub-processes as external odb helpers.
For now only the 'init' and 'get_direct' capabilities are
supported with sub-processes.
Signed-off-by: Christian Couder
---
external-odb.c | 46 +++---
This tests that an apache web server can be used as an
external object database and store files in their native
format instead of converting them to a Git object.
Signed-off-by: Christian Couder
---
t/t0420-transfer-http-e-odb.sh | 142 +
1 file changed
a test to check that our odb-helper
script works well.
Signed-off-by: Christian Couder
---
t/t0400-external-odb.sh | 24
1 file changed, 24 insertions(+)
diff --git a/t/t0400-external-odb.sh b/t/t0400-external-odb.sh
index 977fea852d..4ccca1e965 100755
--- a/t/t0400-exte
Signed-off-by: Christian Couder
---
t/t0400-external-odb.sh | 8
1 file changed, 8 insertions(+)
diff --git a/t/t0400-external-odb.sh b/t/t0400-external-odb.sh
index 4ccca1e965..f924de870f 100755
--- a/t/t0400-external-odb.sh
+++ b/t/t0400-external-odb.sh
@@ -69,4 +69,12
The existing odb_helper_get_object() is renamed
odb_helper_get_git_object() and a new odb_helper_get_raw_object()
is introduced to deal with external objects that are not in Git format.
Signed-off-by: Christian Couder
---
odb-helper.c | 113
On Sat, Dec 30, 2017 at 7:15 PM, Jeff King wrote:
> On Sat, Dec 30, 2017 at 04:04:50PM +0100, Ævar Arnfjörð Bjarmason wrote:
>
>> > I do like the idea of using "show", though. We know the point is to show
>> > the output to the user, so we don't mind at all if the behavior or
>> > output of show c
On Tue, Dec 26, 2017 at 10:59 PM, Christian Couder
wrote:
> Changes since previous version
> ~~
>
> - Fixed the way the 'executable' field sent to Codespeed is set in
> `perf/aggregate.perl` in patch 3/7. We now use `uname -s -m` to
&
om/
Discussions about the cc/perf-run-config patch series:
v1: https://public-inbox.org/git/20170713065050.19215-1-chrisc...@tuxfamily.org/
v2:
https://public-inbox.org/git/cap8ufd2j-ufh+9awz91gtz-jusq7euoexmguro59vpf29jx...@mail.gmail.com/
Christian Couder (7):
perf/aggregate: fix checking ENV{G
available in
Codespeed.
Signed-off-by: Christian Couder
---
t/perf/run | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/t/perf/run b/t/perf/run
index 4e62d6bb3f..ef56396546 100755
--- a/t/perf/run
+++ b/t/perf/run
@@ -148,10 +148,20 @@ run_subsection () {
The GIT_PERF_REPO_NAME env variable is used in
the `aggregate.perl` script to set the 'environment'
field in the JSON Codespeed output.
Let's make it easy to set this variable by setting it
in a config file.
Signed-off-by: Christian Couder
---
t/perf/run | 3 +++
1 file change
Signed-off-by: Christian Couder
---
t/perf/aggregate.perl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl
index e401208488..769d418708 100755
--- a/t/perf/aggregate.perl
+++ b/t/perf/aggregate.perl
@@ -70,7 +70,7 @@ if (not @tests
performance
evolves over time and releases, let's implement a Codespeed output
in "perf/aggregate.perl".
Helped-by: Eric Sunshine
Signed-off-by: Christian Couder
---
t/perf/aggregate.perl | 67 +--
1 file changed, 65 insertions(
fault value argument to be unset if it is not
passed, and this is simpler if it is the last argument.
Signed-off-by: Christian Couder
---
t/perf/run | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/t/perf/run b/t/perf/run
index 43e4de49ef..214d658172 100755
--- a/t/per
As we want to implement another kind of output than
the current output for the perf test results, let's
refactor the existing code that outputs the results
in its own print_default_results() function.
Signed-off-by: Christian Couder
---
t/perf/aggregate.perl
Let's make it possible to set in a config file the output
format (regular or codespeed) of the perf tests.
Signed-off-by: Christian Couder
---
t/perf/run | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/t/perf/run b/t/perf/run
index 214d658172..4e62d6bb3f 100755
--
Hi everyone,
The 34th edition of Git Rev News is now published:
https://git.github.io/rev_news/2017/12/20/edition-34/
Thanks a lot to all the contributors and helpers!
Enjoy,
Christian, Jakub and Markus.
Hi,
A draft of a new Git Rev News edition is available here:
https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-34.md
Everyone is welcome to contribute in any section either by editing the
above page on GitHub and sending a pull request, or by commenting on
this GitHub is
On Thu, Dec 14, 2017 at 10:19 PM, Jeff Hostetler wrote:
> --- a/Documentation/rev-list-options.txt
> +++ b/Documentation/rev-list-options.txt
> @@ -714,9 +714,9 @@ ifdef::git-rev-list[]
> +
> The form '--filter=blob:none' omits all blobs.
> +
> -The form '--filter=blob:limit=[kmg]' omits blobs
On Wed, Dec 13, 2017 at 9:54 PM, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> If you want to be able to use this helper to specify a default value
>> of an empty string (which the orignal that used $4 did), then the
>> previous hunk must be corrected so that it does not unconditionally
>>
On Wed, Dec 13, 2017 at 9:40 PM, Junio C Hamano wrote:
> Christian Couder writes:
>
>> Signed-off-by: Christian Couder
>> ---
>> t/perf/run | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/t/perf/run b/t/perf/run
>>
On Wed, Dec 13, 2017 at 9:33 PM, Junio C Hamano wrote:
> Christian Couder writes:
>
>> my $resultsdir = "test-results";
>> +my $results_section = "";
>> if (exists $ENV{GIT_PERF_SUBSECTION} and $ENV{GIT_PERF_SUBSECTION} ne "") {
On Wed, Dec 13, 2017 at 7:25 PM, Eric Sunshine wrote:
> On Wed, Dec 13, 2017 at 10:13 AM, Christian Couder
> wrote:
>> Codespeed (https://github.com/tobami/codespeed/) is an open source
>> project that can be used to track how some software performs over
>> time. It
On Wed, Dec 13, 2017 at 5:02 PM, Philip Oakley wrote:
>> The end goal would be to have such a server always available to track
>> how the different git commands perform over time on different kind of
>> repos (small, medium, large, ...) with different optimizations on and
>> off (split-index, lib
Signed-off-by: Christian Couder
---
t/perf/run | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/t/perf/run b/t/perf/run
index 04ea5090f9..4454a2713d 100755
--- a/t/perf/run
+++ b/t/perf/run
@@ -144,10 +144,15 @@ run_subsection () {
set
Signed-off-by: Christian Couder
---
t/perf/run | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/t/perf/run b/t/perf/run
index bbd703dc4f..04ea5090f9 100755
--- a/t/perf/run
+++ b/t/perf/run
@@ -106,6 +106,7 @@ get_var_from_env_or_config () {
conf_sec=&qu
Signed-off-by: Christian Couder
---
t/perf/aggregate.perl | 96 +++
1 file changed, 50 insertions(+), 46 deletions(-)
diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl
index 769d418708..3609cb5dc3 100755
--- a/t/perf/aggregate.perl
+++ b
Signed-off-by: Christian Couder
---
t/perf/aggregate.perl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl
index e401208488..769d418708 100755
--- a/t/perf/aggregate.perl
+++ b/t/perf/aggregate.perl
@@ -70,7 +70,7 @@ if (not @tests
performance
evolves over time and releases, let's implement a Codespeed output
in "perf/aggregate.perl".
Signed-off-by: Christian Couder
---
t/perf/aggregate.perl | 68 +--
1 file changed, 66 insertions(+), 2 deletions(-)
diff
Signed-off-by: Christian Couder
---
t/perf/run | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/t/perf/run b/t/perf/run
index 4454a2713d..7b7011f19b 100755
--- a/t/perf/run
+++ b/t/perf/run
@@ -148,10 +148,20 @@ run_subsection () {
test
Signed-off-by: Christian Couder
---
t/perf/run | 3 +++
1 file changed, 3 insertions(+)
diff --git a/t/perf/run b/t/perf/run
index 7b7011f19b..279c2d41f6 100755
--- a/t/perf/run
+++ b/t/perf/run
@@ -137,6 +137,9 @@ run_subsection () {
get_var_from_env_or_config "GIT_PERF_MAKE_CO
Signed-off-by: Christian Couder
---
t/perf/run | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/perf/run b/t/perf/run
index 43e4de49ef..bbd703dc4f 100755
--- a/t/perf/run
+++ b/t/perf/run
@@ -105,7 +105,7 @@ get_var_from_env_or_config () {
env_var=&qu
series is available here:
https://github.com/chriscool/git/commits/codespeed
The cc/perf-run-config patch series was discussed here:
v1: https://public-inbox.org/git/20170713065050.19215-1-chrisc...@tuxfamily.org/
v2:
https://public-inbox.org/git/cap8ufd2j-ufh+9awz91gtz-jusq7euoexmguro59vpf29j
On Thu, Dec 7, 2017 at 7:04 PM, Junio C Hamano wrote:
>
> * jh/object-filtering (2017-12-05) 9 commits
> (merged to 'next' on 2017-12-05 at 3a56b51085)
> + rev-list: support --no-filter argument
> + list-objects-filter-options: support --no-filter
> + list-objects-filter-options: fix 'keword'
On Tue, Dec 5, 2017 at 5:50 PM, Jeff Hostetler wrote:
> From: Jeff Hostetler
>
> Teach rev-list to support --no-filter to override a
> previous --filter= argument. This is
> to be consistent with commands that use OPT_PARSE
> macros.
>
> Signed-off-by: Jeff Hostetler
> ---
> Documentation/rev-
On Sun, Dec 10, 2017 at 3:39 PM, Jeff King wrote:
> On Sun, Dec 10, 2017 at 09:31:18AM -0500, Jeff King wrote:
>
>> On Sat, Dec 09, 2017 at 09:40:07PM +0100, Christian Couder wrote:
>>
>> > The changes compared to v2 are:
>> >
>> > - s/_val/_arg/ in
From: Jacob Keller
We already have tests for --relative, but they currently only test when
a prefix has been provided. This fails to test the case where --relative
by itself should use the current directory as the prefix.
Teach the check_$type functions to take a directory argument to indicate
w
From: Christian Couder
We often accept both a "--key" option and a "--key=" option.
These options currently are parsed using something like:
if (!strcmp(arg, "--key")) {
/* do something */
} else if (skip_prefix(arg, "--key=", &arg)) {
From: Christian Couder
Let's simplify diff option parsing using
skip_to_optional_arg_default().
Signed-off-by: Christian Couder
Signed-off-by: Junio C Hamano
---
diff.c | 20
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/diff.c b/diff.c
index 464a5
From: Christian Couder
Let's simplify index-pack option parsing using
skip_to_optional_arg().
Signed-off-by: Christian Couder
Signed-off-by: Junio C Hamano
---
builtin/index-pack.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/builtin/index-pack.c b/bu
From: Christian Couder
Let's simplify diff option parsing using skip_to_optional_arg().
Signed-off-by: Christian Couder
Signed-off-by: Junio C Hamano
---
diff.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/diff.c b/diff.c
index 2ebe2
From: Junio C Hamano
Helped-by: Jacob Keller
Helped-by: Jeff King
Signed-off-by: Junio C Hamano
---
diff.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/diff.c b/diff.c
index 28e1ab168f..3f14cdace6 100644
--- a/diff.c
+++ b/diff.c
@@ -4563,11 +4563,10 @@ int diff_
From: Junio C Hamano
Signed-off-by: Junio C Hamano
---
t/t4045-diff-relative.sh | 104 +--
1 file changed, 56 insertions(+), 48 deletions(-)
diff --git a/t/t4045-diff-relative.sh b/t/t4045-diff-relative.sh
index 7d68a6e2a5..4df55884c4 100755
--- a/t/
On Thu, Dec 7, 2017 at 7:04 PM, Junio C Hamano wrote:
> * cc/skip-to-optional-val (2017-12-07) 7 commits
> - t4045: test 'diff --relative' for real
> - t4045: reindent to make helpers readable
> - diff: use skip-to-optional-val in parsing --relative
> - diff: use skip_to_optional_val_default
On Thu, Dec 7, 2017 at 1:56 AM, Jeff King wrote:
> I think we'd do better to just assign NULL when there's "=", so we can
> tell the difference between "--relative", "--relative=", and
> "--relative=foo" (all of which are distinct).
>
> I think that's possible with the current scheme by doing:
>
On Thu, Dec 7, 2017 at 1:18 AM, Jacob Keller wrote:
> On Wed, Dec 6, 2017 at 4:16 PM, Jacob Keller wrote:
>>
>> This causes a regression in the --relative option which prevents it
>> from working properly.
>>
>> If I have a repository with a modified file in a subdirectory, such as:
>>
>> a/file
From: Christian Couder
Let's simplify index-pack option parsing using
skip_to_optional_val().
Signed-off-by: Christian Couder
---
builtin/index-pack.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/builtin/index-pack.c b/builtin/index-pack.c
index 8ec45
Let's simplify diff option parsing using
skip_to_optional_val_default().
Signed-off-by: Christian Couder
---
diff.c | 20
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/diff.c b/diff.c
index 83509f0658..d234b4f0cb 100644
--- a/diff.c
+++ b/diff.c
@@ -4
From: Christian Couder
We often accept both a "--key" option and a "--key=" option.
These options currently are parsed using something like:
if (!strcmp(arg, "--key")) {
/* do something */
} else if (skip_prefix(arg, "--key=", &arg)) {
From: Christian Couder
Let's simplify diff option parsing using
skip_to_optional_val().
Signed-off-by: Christian Couder
---
diff.c | 29 ++---
1 file changed, 10 insertions(+), 19 deletions(-)
diff --git a/diff.c b/diff.c
index 2ebe2227b4..83509f0658 100644
On Sun, Dec 3, 2017 at 11:48 PM, Junio C Hamano wrote:
> Christian Couder writes:
>
>> Anyway there is a design choice to be made. Adding a "const char
>> *default" argument makes the function more generic,...
>
> I didn't suggest anything of that sort
On Sun, Dec 3, 2017 at 7:45 PM, Junio C Hamano wrote:
> Christian Couder writes:
>
>> From: Christian Couder
>>
>> We often accept both a "--key" option and a "--key=" option.
>>
>> These options currently are parsed using something
From: Christian Couder
Let's simplify index-pack option parsing using skip_to_opt_val().
Signed-off-by: Christian Couder
---
builtin/index-pack.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/builtin/index-pack.c b/builtin/index-pack.c
index 8ec45
From: Christian Couder
We often accept both a "--key" option and a "--key=" option.
These options currently are parsed using something like:
if (!strcmp(arg, "--key")) {
/* do something */
} else if (skip_prefix(arg, "--key=", &arg)) {
From: Christian Couder
Let's simplify diff option parsing using skip_to_opt_val().
Signed-off-by: Christian Couder
---
diff.c | 22 --
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/diff.c b/diff.c
index 2ebe2227b4..067b498187 100644
--- a/diff.c
From: Christian Couder
Signed-off-by: Christian Couder
---
list-objects-filter-options.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c
index 50b98109eb..6729a57dee 100644
--- a/list-objects-filter-options.c
On Tue, Nov 21, 2017 at 10:07 PM, Jeff Hostetler wrote:
> From: Jonathan Tan
> +void fetch_object(const char *remote_name, const unsigned char *sha1)
> +{
> + struct remote *remote;
> + struct transport *transport;
> + struct ref *ref;
> +
> + remote = remote_get(remote_n
On Tue, Nov 21, 2017 at 10:07 PM, Jeff Hostetler wrote:
> From: Jonathan Tan
> diff --git a/sha1_file.c b/sha1_file.c
> index 10c3a00..fc7718a 100644
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -29,6 +29,7 @@
> #include "mergesort.h"
> #include "quote.h"
> #include "packfile.h"
> +#include "
On Tue, Nov 21, 2017 at 10:07 PM, Jeff Hostetler wrote:
> From: Jonathan Tan
> pack_as_from_promisor () {
> HASH=$(git -C repo pack-objects .git/objects/pack/pack) &&
> >repo/.git/objects/pack/pack-$HASH.promisor
> + echo $HASH
> }
Now the exit code of the above function
On Tue, Nov 28, 2017 at 3:37 PM, Todd Zullinger wrote:
> A build requirement on tcl/tk was added in 01c54284f1 (Makefile: check
> that tcl/tk is installed, 2017-11-20). For building and running the
> tests, we don't need tcl/tk installed. Bypass the requirement.
>
> Signed-off-by: Todd Zullinger
On Mon, Nov 27, 2017 at 5:35 AM, Jeff King wrote:
> On Mon, Nov 27, 2017 at 01:31:13PM +0900, Junio C Hamano wrote:
>
>> Junio C Hamano writes:
>>
>> > Perhaps the "else" part of the above should become a bit more
>> > careful, something along the lines of...
>> >
>> > else
>> > M
On Sun, Nov 26, 2017 at 8:15 PM, Jeff King wrote:
> On Tue, Nov 21, 2017 at 12:58:17AM +0100, Christian Couder wrote:
>
>> > Can you say more about where this comes up?
>>
>> The original discussion is:
>>
>> https://public-inbox.org/git/b6b12040-100f-596
On Sun, Nov 26, 2017 at 6:43 PM, Ramsay Jones
wrote:
>
>
> On 26/11/17 14:00, Christian Couder wrote:
>> On Sun, Nov 26, 2017 at 4:53 AM, Junio C Hamano wrote:
>>> Christian Couder writes:
>>>
>>>> On Mon, Nov 20, 2017 at 6:15 PM, Christian Coude
On Sun, Nov 26, 2017 at 4:53 AM, Junio C Hamano wrote:
> Christian Couder writes:
>
>> On Mon, Nov 20, 2017 at 6:15 PM, Christian Couder
>> wrote:
>>> By default running `make install` in the root directory of the
>>> project will set TCLTK_PATH to `wish` an
On Mon, Nov 20, 2017 at 6:15 PM, Christian Couder
wrote:
> By default running `make install` in the root directory of the
> project will set TCLTK_PATH to `wish` and then go into the "git-gui"
> and "gitk-git" sub-directories to build and install these 2
> sub-
On Wed, Nov 22, 2017 at 3:39 PM, Adam Dinwoodie wrote:
> In trying to do a bisect on the Git repository, I seem to have come
> across surprising behavior where the order in which `git bisect` appears
> to forget that previous commits were marked as new.
Yeah, the algorithm uses many "old" commits
Hi everyone,
The 33rd edition of Git Rev News is now published:
https://git.github.io/rev_news/2017/11/22/edition-33/
Thanks a lot to all the contributors and helpers!
Enjoy,
Christian, Thomas, Jakub and Markus.
On Wed, Nov 22, 2017 at 7:28 AM, Junio C Hamano wrote:
> Jonathan Nieder writes:
>
This comment doesn't tell me how to use the function. How do I detect
whether it successfully read a line? What do the return values
represent? What happens if the line it read doesn't match the k
The function calls itself "required", but it does not die when it
sees an unexpected EOF.
Let's rename it to "packet_key_val_read()".
Signed-off-by: Christian Couder
---
These 2 patches are a late follow up from:
https://public-inbox.org/git/cap8ufd2vk4jv7jebx3axd-
The code is more understandable with 'if' instead of 'unless'.
Signed-off-by: Christian Couder
---
perl/Git/Packet.pm | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/perl/Git/Packet.pm b/perl/Git/Packet.pm
index 82da0cf0db..1682403ffc 1
On Tue, Nov 21, 2017 at 2:12 PM, Junio C Hamano wrote:
> Christian Couder writes:
>
>> On Tue, Nov 21, 2017 at 2:10 AM, Jonathan Nieder wrote:
>>>
>>> That said, I believe that the gitattributes(5) manpage does an okay
>>> job of covering this and that
On Tue, Nov 21, 2017 at 2:10 AM, Jonathan Nieder wrote:
>
> That said, I believe that the gitattributes(5) manpage does an okay
> job of covering this and that that thread came to a clear conclusion:
>
>
> https://public-inbox.org/git/20171026203046.fu3z5ngnw7hck...@aiede.mtv.corp.google.com/
>
Hi,
On Mon, Nov 20, 2017 at 8:19 PM, Jonathan Nieder wrote:
> Hi,
>
> Christian Couder wrote:
>
>> By default running `make install` in the root directory of the
>> project will set TCLTK_PATH to `wish` and then go into the "git-gui"
>> and "gitk-git&
On Fri, Nov 17, 2017 at 6:42 PM, Todd Zullinger wrote:
> Christian Couder wrote:
>>
>> On Thu, Nov 16, 2017 at 2:35 AM, Junio C Hamano wrote:
>>>
>>> I suspect that this change will hurt those who package Git for other
>>> people.
>>
>>
>&
On Fri, Nov 17, 2017 at 11:02 PM, Jeff King wrote:
>
> I'm actually tempted to say that we should not be building the tcl parts
> by default. IOW, instead of NO_TCLTK we should have USE_TCLTK. That
> would also require an adjustment by package builders, but it would
> hopefully be a really obvious
(Sorry I forgot to mark this as v2.)
On Mon, Nov 20, 2017 at 6:15 PM, Christian Couder
wrote:
> By default running `make install` in the root directory of the
> project will set TCLTK_PATH to `wish` and then go into the "git-gui"
> and "gitk-git" sub-directories
NO_TCLTK is a small
additional step they will have to make, but it might be a good
thing as it will not install what they don't want and it will
build a bit faster.
For packagers who want to build git-gui and gitk even if Tcl/Tk
is not installed, we provide the new BYPASS_TCLTK_CHECK va
Hi,
A draft of a new Git Rev News edition is available here:
https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-33.md
Everyone is welcome to contribute in any section either by editing the
above page on GitHub and sending a pull request, or by commenting on
this GitHub is
On Mon, Nov 20, 2017 at 4:05 AM, Junio C Hamano wrote:
> Christian Couder writes:
>
>> On Fri, Sep 29, 2017 at 8:49 AM, Pranit Bauva wrote:
>>> Reimplement `is_expected_rev` & `check_expected_revs` shell function in
>>> C and add a `--check-expected-revs` sub
On Fri, Sep 29, 2017 at 8:49 AM, Pranit Bauva wrote:
> Reimplement `is_expected_rev` & `check_expected_revs` shell function in
> C and add a `--check-expected-revs` subcommand to `git bisect--helper` to
> call it from git-bisect.sh .
It looks like this patch forgot to add the `--check-expected-re
On Thu, Nov 16, 2017 at 2:35 AM, Junio C Hamano wrote:
> Christian Couder writes:
>
>> To improve the current behavior when Tcl/Tk is not installed,
>> let's just check that TCLTK_PATH points to something and error
>> out right away if this is not the case.
>>
On Mon, Oct 16, 2017 at 7:25 AM, Junio C Hamano wrote:
> Christian Couder writes:
>
>> It is error prone and tiring to use many long environment
>> variables to give parameters to the 'run' script.
>
> This topic has been sitting in the list archive without
NO_TCLTK is a small
additional step they will have to make, but it might be a good
thing as it will not install what they don't want and it will
build a bit faster.
Signed-off-by: Christian Couder
---
Makefile | 7 +++
1 file changed, 7 insertions(+)
diff --git a/Makefile b/Makefile
i
On Mon, Nov 13, 2017 at 10:35 PM, Louis Gruand
wrote:
> Dear team, when i download Git on Mac it says “no mountable file systems” and
> doesnt open after. how can i solve this?
When googling "Mac no mountable file systems", it looks like this
error is not specific to Git.
Could you check if you
On Tue, Nov 14, 2017 at 3:04 AM, wrote:
> From: Haaris
>
> Description:
> This patch adds a new option to the config command.
>
> Uses flag --expiry-date as a data-type to covert date-strings to
> timestamps when reading from config files (GET).
> This flag is ignored on write (SET) because the
On Sun, Nov 12, 2017 at 12:57 PM, Jeff King wrote:
> On Sun, Aug 13, 2017 at 12:58:13AM -0400, Jeff King wrote:
>
>> On Sat, Aug 12, 2017 at 03:44:17PM +0200, Dominik Mahrer (Teddy) wrote:
>>
>> > Hi all
>> >
>> > I'm compiling git from source code on a mashine without msgfmt. This leads
>> > to c
On Sun, Nov 12, 2017 at 2:43 AM, Junio C Hamano wrote:
> Theodore Ts'o writes:
>
>> On Sat, Nov 11, 2017 at 11:38:23PM +0900, Junio C Hamano wrote:
>>>
>>> Thanks for saving me time to explain why 'next' is still a very
>>> important command but the end users do not actually need to be
>>> strong
On Sat, Nov 11, 2017 at 12:42 PM, Robert P. J. Day
wrote:
>
> the man page for "git bisect" makes no mention of "git bisect next",
> but the script git-bisect.sh does:
Yeah the following patch was related:
https://public-inbox.org/git/1460294354-7031-2-git-send-email-s-be...@gmx.net/
You migh
On Sat, Nov 11, 2017 at 11:31 AM, Robert P. J. Day
wrote:
> Tweak a number of files to mention "view" as an alternative to
> "visualize".
Good idea.
> @@ -196,15 +196,14 @@ of `git bisect good` and `git bisect bad` to mark
> commits.
> Bisect visualize
>
Maybe while at it th
On Sat, Nov 11, 2017 at 12:22 PM, Robert P. J. Day
wrote:
>
> more on "git bisect" ... the man page seems to make it clear that
> bisection takes *precisely* one "bad" commit, and one *or more* good
> commits, is that correct?
Yeah, that's true.
> seems that way, given the ellipses in the
> co
And while at it let's simplify t0021/rot13-filter.pl by
using Git/Packet.pm.
This will make it possible to reuse packet related
functions in other test scripts.
Signed-off-by: Christian Couder
---
perl/Git/Packet.pm | 169
perl/Mak
701 - 800 of 3241 matches
Mail list logo
