Re: Probable bug in file run-command.c function clear_child_for_cleanup

2012-09-11 Thread David Gould
, is it OK for us to expect a patch from you sometime not in distant future (it is an old bug we survived for a long time and nothing ultra-urgent)? -- David Gould, Personal Trainer Register of Kettlebell Professionals INWA Nordic Walking Instructor Optimise Fitness Ltd -- fit

[PATCH] clear_child_for_cleanup must correctly manage children_to_clean

2012-09-11 Thread David Gould
Iterate through children_to_clean using 'next' fields but with an extra level of indirection. This allows us to update the chain when we remove a child and saves us managing several variables around the loop mechanism. --- run-command.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCHv2] fix broken list iteration in clear_child_for_cleanup

2012-09-11 Thread David Gould
us to update the chain when we remove a child and saves us managing several variables around the loop mechanism. Signed-off-by: David Gould da...@optimisefitness.com Acked-by: Jeff King p...@peff.net --- PATCHv2 updates PATCH only in the commit message: Peff suggested both a helpful subject

Probable bug in file run-command.c function clear_child_for_cleanup

2012-09-09 Thread David Gould
-- David Gould, Personal Trainer Register of Kettlebell Professionals INWA Nordic Walking Instructor Optimise Fitness Ltd -- fit for life 01264 720709 www.optimisefitness.com -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord