Re: [PATCH] pathspec: die on empty strings as pathspec

mod=[+-]x stages correctly' executes. On Sat, Jun 10, 2017 at 1:54 AM, Junio C Hamano wrote: > > Emily Xie writes: > > > diff --git a/t/t3700-add.sh b/t/t3700-add.sh > > index f3a4b4a..40a0d2b 100755 > > --- a/t/t3700-add.sh > > +++ b/t/t3700-add.sh >

[PATCH] pathspec: die on empty strings as pathspec

This patch is step 2. It removes the warning and throws an error instead. Signed-off-by: Emily Xie Reported-by: David Turner --- pathspec.c | 10 -- t/t3600-rm.sh | 5 ++--- t/t3700-add.sh | 5 ++--- 3 files changed, 8 insertions(+), 12 deletions(-) diff --git a/pathspec.c b/path

Re: [PATCH] pathspec: warn on empty strings as pathspec

I suppose I got ahead of myself there. :-) Thanks for the clarification on the process. On Thu, Jun 23, 2016 at 2:17 AM, Junio C Hamano wrote: > Emily Xie writes: > >> Awesome. Thanks, Junio---this is exciting! > > No, thank _you_. > >> As for step 2: do you have

Re: [PATCH] pathspec: warn on empty strings as pathspec

Awesome. Thanks, Junio---this is exciting! As for step 2: do you have a good sense on the timing? Around how long should I wait to submit the patch for it? Otherwise, let me know if there is anything else that I need to do! - Emily -- To unsubscribe from this list: send the line "unsubscribe git

[PATCH] pathspec: warn on empty strings as pathspec

nd (2) asks the user to use "." if their intent was to match all. For step two, a follow-up patch several release cycles later will remove the warnings and throw an error instead. This patch is the first step. Signed-off-by: Emily Xie Reported-by: David Turner Mentored-by: Michail Denc

[PATCH] pathspec: warn on empty strings as pathspec

tually implement the change by throwing an error instead. Signed-off-by: Emily Xie Reported-by: David Turner Mentored-by: Michail Denchev Thanks-to: Sarah Sharp and James Sharp --- pathspec.c | 6 +- t/t3600-rm.sh | 6 +- t/t3700-add.sh | 4 3 files changed, 14 insert

Re: [PATCH] pathspec: prevent empty strings as pathspecs

Thanks for the quick responses on this patch! In response to Junio: > "At least you would need two-step process to introduce a change like > this to warn the people whose tools and workflows you are breaking. > That is, (1) in one release, you add code to only detect the case > you will be changi

[PATCH] pathspec: prevent empty strings as pathspecs

rking tree and index. This patch prevents such cases by throwing an error message whenever an empty string is detected as a pathspec. Signed-off-by: Emily Xie Reported-by: David Turner Mentored-by: Michail Denchev Thanks-to: Sarah Sharp and James Sharp --- pathspec.c | 6 +- t/t360