[PATCH v6] Add the option to force sign annotated tags

2016-03-22 Thread Laurent Arnoud
The `tag.forcesignannotated` config option allows to sign annotated tags automatically. `--annotate` command line option disable configuration `tag.forcesignannotated`. Signed-off-by: Laurent Arnoud --- Documentation/config.txt | 5 + builtin/tag.c| 20 ++-- t

Re: [PATCH v5] Add the option to force sign annotated tags

2016-03-22 Thread Laurent Arnoud
On Tue, Mar 22, 2016 at 12:48:50PM -0700, Junio C Hamano wrote: > Laurent Arnoud writes: > > > The `tag.forcesignannotated` config option allows to sign > > annotated tags automatically. > > It looks like it does a lot more than that to me, though. > > > @@

[PATCH v5] Add the option to force sign annotated tags

2016-03-22 Thread Laurent Arnoud
The `tag.forcesignannotated` config option allows to sign annotated tags automatically. `--annotate` command line option disable configuration `tag.forcesignannotated`. Signed-off-by: Laurent Arnoud --- Documentation/config.txt | 5 + builtin/tag.c| 22

[PATCH v4] Add the tag.gpgsign option to sign annotated tags

2016-03-21 Thread Laurent Arnoud
The `tag.gpgsign` config option allows to sign annotated tags automatically. `--annotate` command line option disable configuration `tag.gpgsign`. Signed-off-by: Laurent Arnoud --- Documentation/config.txt | 5 + builtin/tag.c| 20 +++- t/t7004-tag.sh

Re: [PATCH v2] Add the tag.gpgsign option to sign all created tags

2016-03-21 Thread Laurent Arnoud
On Mon, Mar 21, 2016 at 12:43:45PM -0700, Junio C Hamano wrote: > > You know that when you have sign configuration enabled globally annotate is > > implicite, so its difficult to join both world. > > Sorry, I am not sure what you mean by that. It is unclear what two > worlds you are referring to.

[PATCH v3] Add the tag.gpgsign option to sign annotated tags

2016-03-21 Thread Laurent Arnoud
The `tag.gpgsign` config option allows to sign all annotated tags automatically. Support `--no-sign` option to countermand configuration `tag.gpgsign`. Signed-off-by: Laurent Arnoud Reviewed-by: Jeff King --- Documentation/config.txt | 5 + Documentation/git-tag.txt | 6 +- builtin

Re: [PATCH v2] Add the tag.gpgsign option to sign all created tags

2016-03-21 Thread Laurent Arnoud
On Sun, Mar 20, 2016 at 10:50:48PM -0700, Junio C Hamano wrote: > > The `tag.gpgsign` config option allows to sign all > > commits automatically. > > I presume that you meant "all annotated tags" here. But I am not > sure it this is sensible. Yes its a mistake. > > Support `--no-sign` option to

Re: [PATCH] Add the tag.gpgsign option to sign all created tags

2016-03-20 Thread Laurent Arnoud
On Sun, Mar 20, 2016 at 12:52:17PM -0400, Jeff King wrote: > That behavior makes more sense to me, but I don't think it's what your > patch does (v1 or v2). Perhaps it would make sense to add some tests, > both to verify that it is behaving as expected, and to protect that > behavior from future ch

[PATCH v2] Add the tag.gpgsign option to sign all created tags

2016-03-20 Thread Laurent Arnoud
The `tag.gpgsign` config option allows to sign all commits automatically. Support `--no-sign` option to countermand configuration `tag.gpgsign`. Signed-off-by: Laurent Arnoud Reviewed-by: Jeff King --- Documentation/config.txt | 3 +++ Documentation/git-tag.txt | 4 builtin/tag.c

Re: [PATCH] Add the tag.gpgsign option to sign all created tags

2016-03-20 Thread Laurent Arnoud
Hi Jeff, On Sun, Mar 20, 2016 at 12:29:12AM -0400, Jeff King wrote: > We have commit.gpgsign, so this makes some sense. Would you want to sign > _all_ tags created with "git tag", including lightweight tags, or only > those that would already create a tag object (i.e., annotated tags)? Yes those

[PATCH] Add the tag.gpgsign option to sign all created tags

2016-03-19 Thread Laurent Arnoud
The tag.gpgsign config option allows to sign all commits automatically. Signed-off-by: Laurent Arnoud --- Documentation/config.txt | 3 +++ builtin/tag.c| 19 --- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/Documentation/config.txt b