Re: [PATCH 1/2] ident: check for useConfigOnly before auto-detection of name/email

2016-03-31 Thread Marios Titas
On Thu, Mar 31, 2016 at 10:40:03AM -0400, Jeff King wrote: On Wed, Mar 30, 2016 at 10:29:42PM +0300, Marios Titas wrote: If user.useConfigOnly is set, it does not make sense to try to auto-detect the name and/or the email. So it's better to do the useConfigOnly checks first. It might be

Re: [PATCH 2/2] ident: make the useConfigOnly error messages more informative

2016-03-30 Thread Marios Titas
On Wed, Mar 30, 2016 at 03:27:05PM -0700, Junio C Hamano wrote: Marios Titas writes: - && !(ident_config_given & IDENT_NAME_GIVEN)) - die("user.useConfigOnly set but no name given"); + &

[PATCH 2/2] ident: make the useConfigOnly error messages more informative

2016-03-30 Thread Marios Titas
The env_hint message applies perfectly to the case when user.useConfigOnly is set and at least one of the user.name and the user.email are not provided. Additionally, use a more descriptive error message when that happens. Signed-off-by: Marios Titas --- ident.c | 12 1 file

[PATCH 1/2] ident: check for useConfigOnly before auto-detection of name/email

2016-03-30 Thread Marios Titas
If user.useConfigOnly is set, it does not make sense to try to auto-detect the name and/or the email. So it's better to do the useConfigOnly checks first. Signed-off-by: Marios Titas --- ident.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ident.c b/id