[PATCH v3] stash: Add two config variables for stash show

2015-08-29 Thread Namhyung Kim
o show diffstat and patch output respectively. The stash.showStat is for diffstat and default is true. The stat.showPatch is for the patch output and default is false. Signed-off-by: Namhyung Kim --- Documentation/config.txt| 10 ++ Documentation/git-stash.txt | 2 +

Re: [PATCH] stash: Add stash.showFlag config variable

2015-08-29 Thread Namhyung Kim
Hi, On Sat, Aug 29, 2015 at 3:10 AM, Junio C Hamano wrote: > Namhyung Kim writes: > >>> Perhaps a pair of new booleans >>> >>> - stash.showStat (defaults to true but you can turn it off) >>> - stash.showPatch (defaults to false but you can turn i

Re: [PATCH] stash: Add stash.showFlag config variable

2015-08-27 Thread Namhyung Kim
Hi, On Thu, Aug 27, 2015 at 06:08:39PM -0700, Junio C Hamano wrote: > Namhyung Kim writes: > > > +stash.showFlag:: > > + The default option to pass to `git stash show` when no option is > > + given. The default is '--stat'. See description of 'show&

Re: [PATCH] stash: Add stash.showFlag config variable

2015-08-27 Thread Namhyung Kim
Hi, On Thu, Aug 27, 2015 at 08:16:35PM -0400, Eric Sunshine wrote: > On Thu, Aug 27, 2015 at 11:36 AM, Namhyung Kim wrote: > > On Fri, Aug 28, 2015 at 12:20 AM, SZEDER Gábor wrote: > >> - This hunk runs the the exact same 'git config' command twice. Run it > >

[PATCH v2.1] stash: Add stash.showFlag config variable

2015-08-27 Thread Namhyung Kim
Some users might want to see diff (patch) output always rather than diffstat when [s]he runs 'git stash show'. Although this can be done with adding -p option, it'd be better to provide a config option to control this behavior IMHO. Signed-off-by: Namhyung Kim --- Documenta

[PATCH v2] stash: Add stash.showFlag config variable

2015-08-27 Thread Namhyung Kim
Some users might want to see diff (patch) output always rather than diffstat when [s]he runs 'git stash show'. Although this can be done with adding -p option, it'd be better to provide a config option to control this behavior IMHO. Signed-off-by: Namhyung Kim --- Documenta

Re: [PATCH] stash: Add stash.showFlag config variable

2015-08-27 Thread Namhyung Kim
Hi, On Fri, Aug 28, 2015 at 12:20 AM, SZEDER Gábor wrote: > Hi, > > I haven't made up my mind about this feature yet, but have a few > comments about its implementation. Thanks for taking your time! > >> diff --git a/git-stash.sh b/git-stash.sh >> index 1d5ba7a..8432435 100755 >> --- a/git-stas

[PATCH] stash: Add stash.showFlag config variable

2015-08-27 Thread Namhyung Kim
Some users might want to see diff (patch) output always rather than diffstat when [s]he runs 'git stash show'. Although this can be done with adding -p option, it'd be better to provide a config option to control this behavior IMHO. Signed-off-by: Namhyung Kim --- Documenta

[PATCH] send-email: Fix documentation of --signed-off-by-cc option

2013-06-20 Thread Namhyung Kim
From: Namhyung Kim The man page says it'll control the Cc: lines being added also, but this is not true. Reported-by: Minchan Kim Signed-off-by: Namhyung Kim --- Documentation/git-send-email.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/git

[PATCH v2] name-rev: Allow to specify a subpath for --refs option

2013-06-18 Thread Namhyung Kim
From: Namhyung Kim In its current form, when an user wants to filter specific ref using --refs option, she needs to give something like --refs=refs/tags/v1.*. It'd be convenient providing a way to specify a subpath of ref pattern. For example, --refs=origin/* can find refs/remotes/o

Re: [PATCH] name-rev: Allow to omit refs/tags/ part in --refs option when --tags used

2013-06-18 Thread Namhyung Kim
2013-06-18 AM 12:53, Junio C Hamano wrote: Junio C Hamano writes: Wouldn't it make more sense to see if the given pattern matches a tail substring of the ref, instead of using the hardcoded "strip refs/heads/, refs/tags or refs/, and then match once" logic? That way, --refs=origin/* can find

Re: [PATCH] name-rev: Allow to omit refs/tags/ part in --refs option when --tags used

2013-06-18 Thread Namhyung Kim
Hi Junio, 2013-06-18 AM 12:27, Junio C Hamano wrote: Namhyung Kim writes: In its current form, when an user wants to filter specific ref using --refs option, she needs to give something like --refs=refs/tags/v1.*. This is not intuitive as users might think it's enough to give just a

[PATCH] config: Add description of --local option

2013-06-17 Thread Namhyung Kim
It was missed in the option list while mentioned from the general description. Add it for completeness. Signed-off-by: Namhyung Kim --- Documentation/git-config.txt |9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt index

[PATCH] name-rev: Allow to omit refs/tags/ part in --refs option when --tags used

2013-06-17 Thread Namhyung Kim
s too. Change it for users to be able to use --refs=sth or --refs=remotes/sth. Also remove the leading 'tags/' part in the output when --tags option was given since the option restricts to work with tags only. This is what we have if --name-only option was given also. Signed-off-b