> I'd vote for keeping it simple and not having the copyright notice. Most
> t/*.sh do not have one. The Git history + mailing-list archives are much
> better than in-code comments to keep track of who wrote what.
> Remi: any objection on removing it?
Sorry for not having resent the patches mysel
Matthieu Moy writes:
> Your git send-email does not seem to like PATCHes 08-10/10 ;-).
>
> Up to PATCH 07, the series looks good.
Yes, I get "Too many recipients" error... If I specify
--no-signoff-by-cc then this is also aborted but I get no error (at
least I've not seen it last time...). If I
like
" j...@example.com ", "\t j...@example.com " or
"j...@example.com".
- interprets aliases in string containing leading and trailing
whitespaces such as " alias" or "alias\t" like other options.
Signed-off-by: Remi Lespinet
---
g
ument
with comma in --cc, --to and --bcc.
Helped-by: Remi Lespinet
Signed-off-by: Mathieu Lienard--Mayor
Signed-off-by: Jorge Juan Garcia Garcia
Signed-off-by: Matthieu Moy
Signed-off-by: Remi Lespinet
---
Documentation/git-send-email.txt | 12 +--
git-send-email.perl
Do not consider quote inside a recipient name as character when
they are not escaped. This interprets:
"Jane" "Doe"
as:
"Jane Doe"
instead of:
"Jane\" \"Doe"
Signed-off-by: Remi Lespinet
---
git-send-email.perl | 6 --
1 f
uot;e
In this case the result of parse_address_line is:
With M::A : "Jane Do" e
Without : "Jane Do e"
When the user input is not correct, the behavior is also mostly
the same.
Unlike Mail::Address, this doesn't parse groups and recursive
commentaries.
Signed-o
and
--to-cmd. Example of script:
#!/bin/sh
echo alias1
echo alias2
Signed-off-by: Remi Lespinet
---
git-send-email.perl | 2 ++
t/t9001-send-email.sh | 60 +++
2 files changed, 62 insertions(+)
diff --git a/git-send
Simplify code by creating a function which transform a list of strings
containing email addresses (separated by commas, comporting aliases)
into a clean list of valid email addresses.
Signed-off-by: Remi Lespinet
---
git-send-email.perl | 22 --
1 file changed, 12 insertions
Aliases were expanded before considering the From field of the
--compose option. This is inconsistent with other fields
(To, Cc, ...) which already support aliases.
Signed-off-by: Remi Lespinet
---
git-send-email.perl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/git
Group expressions in a single if statement. This avoid checking
multiple time if the variable $sender is defined.
Signed-off-by: Remi Lespinet
---
git-send-email.perl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index
Create a function which replaces Date, Message-Id and
X-Mailer lines generated by git-send-email by a specific string:
Date:.*$ -> Date: DATE-STRING
Message-Id:.*$ -> Message-Id: MESSAGE-ID-STRING
X-Mailer:.*$ -> X-Mailer: X-MAILER-STRING
Signed-off-by: Remi Lespinet
---
t/t
Move the creation of the scripts used in to-cmd and cc-cmd tests
in a setup test to make them available for later tests.
Signed-off-by: Remi Lespinet
---
t/t9001-send-email.sh | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/t/t9001-send-email.sh b/t/t9001
Matthieu Moy writes:
> > We can redirect todo_output to a variable but I've not found better...
> > (Maybe someone has the solution here ?). Also there's no summary at
> > the end of the test (as with other perl tests).
>
> You can get the 1..44 at the end with
>
> printf "1..%d\n", Test::More->
Matthieu Moy writes:
> This is the last message I received in the series, and it's labeled
> 07/10. Is that normal?
No, it wasn't, I have seen no error message though... I'll take a look
at that later. I just sent 0008, 0009 and 0010 but I seems that I've pasted
the wrong line in the in-reply-t
Do not consider quote inside a recipient name as character when
they are not escaped. This interprets:
"Jane" "Doe"
as:
"Jane Doe"
instead of:
"Jane\" \"Doe"
Signed-off-by: Remi Lespinet
---
git-send-email.perl | 6 --
1 f
like
" j...@example.com ", "\t j...@example.com " or
"j...@example.com".
- interprets aliases in string containing leading and trailing
whitespaces such as " alias" or "alias\t" like other options.
Signed-off-by: Remi Lespinet
---
g
ument
with comma in --cc, --to and --bcc.
Helped-by: Remi Lespinet
Signed-off-by: Mathieu Lienard--Mayor
Signed-off-by: Jorge Juan Garcia Garcia
Signed-off-by: Matthieu Moy
Signed-off-by: Remi Lespinet
---
Documentation/git-send-email.txt | 12 +--
git-send-email.perl
Create a function which replaces Date, Message-Id and
X-Mailer lines generated by git-send-email by a specific string:
Date:.*$ -> Date: DATE-STRING
Message-Id:.*$ -> Message-Id: MESSAGE-ID-STRING
X-Mailer:.*$ -> X-Mailer: X-MAILER-STRING
Signed-off-by: Remi Lespinet
---
t/t
Simplify code by creating a function which transform a list of strings
containing email addresses (separated by commas, comporting aliases)
into a clean list of valid email addresses.
Signed-off-by: Remi Lespinet
---
git-send-email.perl | 22 --
1 file changed, 12 insertions
Group expressions in a single if statement. This avoid checking
multiple time if the variable $sender is defined.
Signed-off-by: Remi Lespinet
---
git-send-email.perl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index
and
--to-cmd. Example of script:
#!/bin/sh
echo alias1
echo alias2
Signed-off-by: Remi Lespinet
---
git-send-email.perl | 2 ++
t/t9001-send-email.sh | 60 +++
2 files changed, 62 insertions(+)
diff --git a/git-send
Aliases were expanded before considering the From field of the
--compose option. This is inconsistent with other fields
(To, Cc, ...) which already support aliases.
Signed-off-by: Remi Lespinet
---
git-send-email.perl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/git
uot;e
In this case the result of parse_address_line is:
With M::A : "Jane Do" e
Without : "Jane Do e"
When the user input is not correct, the behavior is also mostly
the same.
Unlike Mail::Address, this doesn't parse groups and recursive
commentaries.
Signed-off-
Move the creation of the scripts used in to-cmd and cc-cmd tests
in a setup test to make them available for later tests.
Signed-off-by: Remi Lespinet
---
t/t9001-send-email.sh | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/t/t9001-send-email.sh b/t/t9001
Matthieu Moy writes:
> Cool. Then almost all the work is done to get an automated test. Next
> step would be to add the tests itself in the code. I would do that by
> adding a hidden --selfcheck option to git send-email that would compare
> Mail::Address->parse($string); and split_addrs($string);
> Remi Lespinet writes:
>
> > I've some more tests, maybe I should put them all in this post ?
>
> Yes, please post as much as you have. Ideally, this should be
> automatically tested, but if you don't have time to write the automated
> tests, at least having a
> Junio C Hamano writes
> Suffix "rgx" that means "regular expression" is a bit unusual, and
> also hard to read when squashed to another word. Elsewhere in the
> same script, we seem to use $re_whatever to store precompiled
> regular expressions, so perhaps $re_comment, $re_quote, etc.?
Yes it'
Matthieu Moy writes
> > + my $commentrgx=qr/\((?:[^)]*)\)/;
> > + my $quotergx=qr/"(?:[^\"\\]|\\.)*"/;
> > + my $wordrgx=qr/(?:[^]["\s()<>:;@\\,.]|\\.)+/;
>
> Spaces around = please.
> ...
> > + foreach my $token (@tokens) {
> > + if ($token =~ /^[,;]$/) {
>
> Here and below: you'
Matthieu Moy writes
> Remi Lespinet writes:
> > if (defined $sender) {
> > + $sender =~ s/^\s+|\s$//g;
> I would say \s+ also for the second \s. Not really different, but it
> feels wrong to iterate the substitution as many times as there are
> trailing spaces
Do not consider quote inside a recipient name as character when
they are not escaped. This interprets:
"Jane" "Doe"
as:
"Jane Doe"
instead of:
"Jane\" \"Doe"
Signed-off-by: Remi Lespinet
---
I don't know if it's an
like
" j...@example.com ", "\t j...@example.com " or
"j...@example.com".
- interprets aliases in string containing leading and trailing
whitespaces such as " alias" or "alias\t" like other options.
Signed-off-by: Remi Lespinet
---
g
ument
with comma in --cc, --to and --bcc.
Helped-by: Remi Lespinet
Signed-off-by: Mathieu Lienard--Mayor
Signed-off-by: Jorge Juan Garcia Garcia
Signed-off-by: Matthieu Moy
Signed-off-by: Remi Lespinet
---
Documentation/git-send-email.txt | 12 +--
git-send-email.perl
uot;e
In this case the result of parse_address_line is:
With M::A : "Jane Do" e
Without : "Jane Do e"
When the user input is not correct, the behavior is also mostly
the same.
Unlike Mail::Address, this doesn't parse groups and recursive
commentaries.
Signed-o
Move the creation of the scripts used in to-cmd and cc-cmd tests
in a setup test to make them available for later tests.
Signed-off-by: Remi Lespinet
---
t/t9001-send-email.sh | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/t/t9001-send-email.sh b/t/t9001
Simplify code by creating a function which transform a list of strings
containing email addresses (separated by commas, comporting aliases)
into a clean list of valid email addresses.
Signed-off-by: Remi Lespinet
---
git-send-email.perl | 22 --
1 file changed, 12 insertions
Aliases were expanded before checking the From field of the
--compose option. This is inconsistent with other fields
(To, Cc, ...) which already support aliases.
Signed-off-by: Remi Lespinet
---
git-send-email.perl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-send
Create a function which replaces Date, Message-Id and
X-Mailer lines generated by git-send-email by a specific string:
Date:.*$ -> Date: DATE-STRING
Message-Id:.*$ -> Message-Id: MESSAGE-ID-STRING
X-Mailer:.*$ -> X-Mailer: X-MAILER-STRING
Signed-off-by: Remi Lespinet
---
t/t
Group expressions in a single if statement. This avoid checking
multiple time if the variable $sender is defined.
Signed-off-by: Remi Lespinet
---
git-send-email.perl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index
and
--to-cmd. Example of script:
#!/bin/sh
echo alias1
echo alias2
Signed-off-by: Remi Lespinet
---
git-send-email.perl | 2 ++
t/t9001-send-email.sh | 60 +++
2 files changed, 62 insertions(+)
diff --git a/git-send
Matthieu Moy writes
> To me, the answer should be: do whatever the RFC says in email headers.
> I'd expect anything that works in the To: header to work in the --to
> option of git send-email.
Ok sounds good to me !
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body
Matthieu Moy writes
> I would say that using parse_address_line is good for consistancy in Git
> anyway. If the behavior of parse_address_line is broken on some
> corner-cases, then it should be fixed anyway.
Ok, but I don't know what fixed means in these particular cases.
Actually the proble
Hi,
I'm currently working on git send-email to allow passing names
containing commas. I would like to specify that the comma
shouldn't be interpreted as a delimiter when there's quotes
around:
"Jane, Katarina Doe"
This changes the behavior of the double quote. For example
when passing:
--t
Matthieu Moy writes:
> Junio C Hamano writes:
>
> > Remi Lespinet writes:
> >
> >> I agree, I'd like to put it right after split_at_commas in a separate
> >> function "trim_list". Is it a good idea even if the function is one
> >&
Matthieu Moy writes:
> Actually, once you have this, PATCH 6/7 becomes useless, right? (at
> least, the test passes if I revert it)
> It seems to me that doing this space trimming just once, inside or right
> after split_at_commas would be clearer.
You're right, I put it twice because of there'
> Nothing serious, but you did something weird while sending. This message
> does not have a References: or an In-reply-to: field, so it breaks
> threading. See how it's displayed on
>
> http://thread.gmane.org/gmane.comp.version-control.git
Yes, send-email was aborted after 5/7, I realized and
Remove leading and trailing whitespaces when sanitizing addresses so
that git send-email give the same output when passing arguments like
" j...@example.com " or "\t j...@example.com " as with
"j...@example.com".
The next commit will introduce a test for thi
, --bcc options or by the git send-email prompt.
Signed-off-by: Remi Lespinet
---
git-send-email.perl | 1 +
t/t9001-send-email.sh | 24
2 files changed, 25 insertions(+)
diff --git a/git-send-email.perl b/git-send-email.perl
index 3d144bd..34c8b8b 100755
--- a/git-
Simplify code by creating a funct (comma separated, with aliases ...)
into a simple list of valid email addresses.
Signed-off-by: Remi Lespinet
---
git-send-email.perl | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/git-send-email.perl b/git-send
.
Signed-off-by: Remi Lespinet
---
t/t9001-send-email.sh | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 062c703..806f066 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -522,6 +522,12 @@ Result
ing an alias as an
argument of --from is not possible, but modifying the from field in
the patch manually is.
Signed-off-by: Remi Lespinet
---
git-send-email.perl | 2 ++
t/t9001-send-email.sh | 60 +++
2 files changed, 62 insertions(+)
diff --git
;Jane, Doe" '
Remove the limitation imposed by 79ee555b (Check and document the
options to prevent mistakes, 2006-06-21) which rejected every argument
with comma in --cc, --to and --bcc.
Helped-by: Remi Lespinet
Signed-off-by: Mathieu Lienard--Mayor
Signed-off-by: Jorge Juan Garcia Garcia
Move the creation of the scripts used in to-cmd and cc-cmd tests
in a setup test to make them available for later tests.
This will be used in the next commit.
Signed-off-by: Remi Lespinet
---
t/t9001-send-email.sh | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff
CHANGES (since last submitted version)
1/7 : identical to previous 1/5
2/7 : identical to previous 2/5
3/7 : identical to previous 3/5
4/7 : Modification previously done by 5/5 (refactoring address process)
5/7 : identical modulo a minor change at hunk @@ -1023,8 +1009,13 @@
in the function
Junio C Hamano writes
> Matthieu Moy writes:
>
> > Remi Lespinet writes:
> >
> >> Simplify code by creating a function to transform list of email lists
> >> (comma separated, with aliases ...) into a simple list of valid email
> >> addresses.
&g
Matthieu Moy writes:
> To me, the series is ready now, and I don't think re-rolling it would be
> a good time investment. Plus, I spent time reviewing this series and
> with my proposal I'd need to review a relatively different one.
Ok, thanks.
--
To unsubscribe from this list: send the line "un
Matthieu Moy writes:
> Remi Lespinet writes:
>
> > Simplify code by creating a function to transform list of email lists
> > (comma separated, with aliases ...) into a simple list of valid email
> > addresses.
>
> I would have found the series easier to
Simplify code by creating a function to transform list of email lists
(comma separated, with aliases ...) into a simple list of valid email
addresses.
Signed-off-by: Remi Lespinet
---
I'm not sure about the name of the function...
git-send-email.perl | 28 +---
1
.
Signed-off-by: Remi Lespinet
---
t/t9001-send-email.sh | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 062c703..806f066 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -522,6 +522,12 @@ Result
and
--to-cmd. Example of script:
#!/bin/sh
echo alias1
echo alias2
Signed-off-by: Remi Lespinet
---
Note that the --from option of git format-patch takes an argument which
must be formated as .*<.*> (if not, git format-patch will be aborted with
fatal: invalid iden
;Jane, Doe" '
Remove the limitation imposed by 79ee555b (Check and document the
options to prevent mistakes, 2006-06-21) which rejected every argument
with comma in --cc, --to and --bcc.
Helped-by: Remi Lespinet
Signed-off-by: Mathieu Lienard--Mayor
Signed-off-by: Jorge Juan Garcia Garcia
Move the creation of the scripts used in to-cmd and cc-cmd tests
in a setup test to make them available for later tests.
This will be used in the next commit.
Signed-off-by: Remi Lespinet
---
t/t9001-send-email.sh | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff
Add the am.threeWay configuration variable to use the -3 or --3way
option of git am by default. When am.threeway is set and not desired
for a specific git am command, the --no-3way option can be used to
override it.
Signed-off-by: Remi Lespinet
---
Only one change compared to previous version
Initialization for the threeway variable was missing. This caused
a behavior change for command lines like:
threeway=t git am ...
This commit adds initialization for this variable.
Signed-off-by: Remi Lespinet
---
git-am.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/git-am.sh
Create a setup for git am -3 in a separate test instead of creating
this setup each time.
This prepares for the next commit which will use this setup as well.
Signed-off-by: Remi Lespinet
---
t/t4150-am.sh | 32 ++--
1 file changed, 14 insertions(+), 18 deletions
On Thu, Jun 4, 2015 at 1:17 PM, Remi LESPINET
wrote:
>
> Hi,
>
> Working on git-send-email, I've seen that there's no aliases support
> when manually adding a recipient in a 'To' or 'Cc' field in a patch
> and for the --to-cmd and --cc-cmd.
>
> On Thu, Jun 4, 2015 at 5:11 PM, Stefan Beller wrote:
> > On Thu, Jun 4, 2015 at 1:17 PM, Remi LESPINET
> > wrote:
> >> Working on git-send-email, I've seen that there's no aliases support
> >> when manually adding a recipient in a 'To' o
Hi,
Working on git-send-email, I've seen that there's no aliases support
when manually adding a recipient in a 'To' or 'Cc' field in a patch
and for the --to-cmd and --cc-cmd.
I would like to add this support, and I wonder if there are reasons
not to do it.
Thanks.
--
To unsubscribe from this l
Initialization for the threeway variable was missing. This caused
a behavior change for command lines like:
threeway=t git am ...
This commit adds initialization for this variable.
Signed-off-by: Remi Lespinet
---
git-am.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/git-am.sh
Create a setup for git am -3 in a separate test instead of creating
this setup each time.
This prepares for the next commit which will use this setup as well.
Signed-off-by: Remi Lespinet
---
t/t4150-am.sh | 32 ++--
1 file changed, 14 insertions(+), 18 deletions
Add the am.threeWay configuration variable to use the -3 or --3way
option of git am by default. When am.threeway is set and not desired
for a specific git am command, the --no-3way option can be used to
override it.
Signed-off-by: Remi Lespinet
---
Documentation/config.txt | 8
> Matthieu Moy writes
> > > +CONFIGURATION
> > > +-
> > > +
> > > +am.keepcr::
> > > +If true, git-am will call git-mailsplit for patches in mbox
> > > format
> >
> > `git am`
> > `git mailsplit`
> >
> > > +with parameter '--keep-cr'. In this case git-mailsplit will
>
Matthieu Moy writes
> Most git-*.txt do not have this CONFIGURATION section.
>
> In an ideal world, we would have such section automatically generated
> (i.e. the description for each variable would exist in one place, and we
> would make sure that both "man git-config" and "man git-" show
> it
Matthieu Moy writes
> Remi Lespinet writes:
>
> > +am.threeWay::
> > +By default, git-am will fail if the patch does not apply cleanly.
>
> http://article.gmane.org/gmane.comp.version-control.git/270538
Ok sorry.
Thanks
--
To unsubscribe from this list: se
> On 06/03/2015 07:50 AM Torsten Bögershausen wrote
>
> > +CONFIGURATION
> > +-
> > +
> > +am.keepcr::
> > +If true, git-am will call git-mailsplit for patches in mbox format
> > +with parameter '--keep-cr'. In this case git-mailsplit will
> > +not remove `\r` f
Create a setup for git am -3 in a separate test instead of creating
this setup each time.
This prepares for the next commit which will use this setup as well.
Signed-off-by: Remi Lespinet
---
t/t4150-am.sh | 32 ++--
1 file changed, 14 insertions(+), 18 deletions
be used in the next commit.
Signed-off-by: Remi Lespinet
---
Documentation/git-am.txt | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/Documentation/git-am.txt b/Documentation/git-am.txt
index 0d8ba48..d412f6b 100644
--- a/Documentation/git-am.txt
+++ b
Add the am.threeWay configuration variable to use the -3 or --3way
option of git am by default. When am.threeway is set and not desired
for a specific git am command, the --no-3way option can be used to
override it.
Signed-off-by: Remi Lespinet
---
Even if git am will be rewritten soon, the
Initialization for the threeway variable was missing. This caused
a behavior change for command lines like:
threeway=t git am ...
This commit fixes the bug.
Signed-off-by: Remi Lespinet
---
git-am.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/git-am.sh b/git-am.sh
index
Matthieu Moy writes:
> Remi Lespinet writes:
>
> > +if test "$(git config --bool --get am.threeWay)" = true
> > +then
> > +threeway=t
> > +fi
>
> I think you missed Paul's remark on this:
>
> http://article.gmane.org/gmane.comp.versi
Create a setup for git am -3 in a separate test instead of creating
this setup each time.
This prepares for the next commit which will use this setup as well.
Signed-off-by: Remi Lespinet
---
I removed the function creating temporary branch for now, because this
would have cost too much time
Add the am.threeWay configuration variable to use the -3 or --3way
option of git am by default. When am.threeway is set and not desired
for a specific git am command, the --no-3way option can be used to
override it.
Signed-off-by: Remi Lespinet
---
Documentation/config.txt | 7
Ok, Thanks for all the informations
> Notice that the pre-context lines in this second example is only one
> line. Is it giving the same degree of safety if we rejected an
> attempt to apply this patch only when the original does not have 10,
> 20, 30 and 40 in this order?
>
> No. Because we ar
==
= 1. The bug
==
hunks of the form:
@@ -1,k +n,m @@
have a special behavior because of the variable match_begining. For
these hunks, offset is not allowed w
mitation imposed by 79ee555b (Check and document the
options to prevent mistakes, 2006-06-21) which rejected every argument
with comma in --cc, --to and --bcc
Helped-by: Remi Lespinet
Signed-off-by: Mathieu Lienard--Mayor
Signed-off-by: Jorge Juan Garcia Garcia
Signed-off-by: Matthie
mit which uses this
function
Signed-off-by: Remi Lespinet
---
t/t9001-send-email.sh | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index a3663da..71968ee 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
Eric Sunshine writes:
> wrote:
>
> validate_address_list(sanitize_address_list(
> split_address_list(@xx))
>
> That's pretty verbose, so introducing a new function to encapsulates
> that behavior might be reasonable.
Agreed, If you have any suggestion for the name of this function
Junio C Hamano writes:
> Remi Lespinet writes:
> Accept a list of emails separated by commas in flags --cc, --to
> and --bcc. Multiple addresses can already be given by using
> these options multiple times, but it is more convenient to allow
> cutting-and-pa
Eric Sunshine writes:
> Paul Tan writes:
>
> >> Remi LESPINET writes:
> >> + tmp_name=${2-"temporary"}
> >
> > I don't think the quotes are required. Also, I don't feel good about
> > swapping the order of the arguments to
to='Foo, Bar '
This artificial limitation is imposed by 79ee555b (Check and document
the options to prevent mistakes, 2006-06-21).
Signed-off-by: Mathieu Lienard--Mayor
Signed-off-by: Jorge Juan Garcia Garcia
Signed-off-by: Matthieu Moy
Contributions-by: Remi Lespinet
---
Documen
Hello,
I've corrected an old patch from an Ensimag student.
(http://thread.gmane.org/gmane.comp.version-control.git/228182). This
patch allows multiple email addresses for options --cc, --to and
--bcc. As said in the commit message, this patch doesn't handle commas
in name, and the only possibilit
Move the creation of the file, commit and branch used in git am -3 tests
in a setup test, to avoid creating this setup several time.
Signed-off-by: Remi Lespinet
---
t/t4150-am.sh | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/t/t4150-am.sh b/t/t4150
Add the am.threeWay configuration variable to use the -3 or --3way
option of git am by default. When am.threeway is set and not desired
for a specific git am command, the --no-3way option can be used to
override it.
Signed-off-by: Remi Lespinet
---
Even if git am will be rewritten soon, the
Add new functions to keep the setup cleaner:
- setup_temporary_branch: creates a new branch, check it out
and automatically delete it after the test is over
- setup_fixed_branch: creates a fixed branch, which can be re-used
in later tests
Signed-off-by: Remi Lespinet
---
t/t4150-am.sh
93 matches
Mail list logo
