Re: [PATCH 0/2] git-p4: fix for handling of multiple depot paths

2015-12-15 Thread Sam Hocevar
in order by the perforce change number. :) > > - James > > > From: Luke Diamand <l...@diamand.org> > Sent: Monday, December 14, 2015 3:09 PM > To: Junio C Hamano > Cc: Git Users; James Farwell; Lars Schneider; Eric Sunshine; Sam Hocevar

Re: [PATCH 1/2] git-p4: support multiple depot paths in p4 submit

2015-12-08 Thread Sam Hocevar
On Tue, Dec 08, 2015, Lars Schneider wrote: > > Would a refactor of lib-git-p4.sh (and probably all git-p4 tests) to > > support multiple depots be acceptable and/or welcome? I prefer to ask > > before I dig into the task. > > Can you outline your idea a bit? Are you aware of the following way

Re: [PATCH 1/2] git-p4: support multiple depot paths in p4 submit

2015-12-07 Thread Sam Hocevar
On Sun, Dec 06, 2015, Lars Schneider wrote: > Thanks for the patch! Do you see a way to demonstrate the bug in a test case > similar to t9821 [1]? Not yet, I'm afraid. It's proving trickier than expected because for now I can only reproduce the bug when the view uses multiples depots

[PATCH 1/2] git-p4: support multiple depot paths in p4 submit

2015-12-05 Thread Sam Hocevar
When submitting from a repository that was cloned using a client spec, use the full list of paths when ruling out files that are outside the view. This fixes a bug where only files pertaining to the first path would be included in the p4 submit. Signed-off-by: Sam Hocevar <s...@hocevar.

[PATCH 2/2] git-p4: reduce number of server queries for fetches

2015-12-05 Thread Sam Hocevar
-by: Sam Hocevar <s...@hocevar.net> --- git-p4.py | 43 --- 1 file changed, 20 insertions(+), 23 deletions(-) diff --git a/git-p4.py b/git-p4.py index 210f100..ea2bbb2 100755 --- a/git-p4.py +++ b/git-p4.py @@ -796,39 +796,36 @@ def p4ChangesForPaths(depo