Re: [PATCH v3 2/2] http: fix the silent ignoring of proxy misconfiguraion

On Tue, Apr 11, 2017 at 8:37 PM, Jeff King <p...@peff.net> wrote: > On Tue, Apr 11, 2017 at 08:17:50PM +0300, Sergey Ryazanov wrote: >> Earlier, the whole http.proxy option string was passed to curl without >> any preprocessing so curl could complain about the invalid p

[PATCH v4 1/2] http: honor empty http.proxy option to bypass proxy

t work anymore. Fix this issue by explicitly handling http.proxy being set the empty string. This also makes the code a bit more clear and should help us avoid such regressions in the future. Helped-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> Helped-by: Jeff King <p...@peff.net>

[PATCH v4 0/2] http: few fixes for the proxy configuration handling

Sergey Ryazanov (2): http: honor empty http.proxy option to bypass proxy http: fix the silent ignoring of proxy misconfiguraion http.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) -- 2.10.2

[PATCH v4 2/2] http: fix the silent ignoring of proxy misconfiguraion

ing result. If parsing failed then print an error message and die. Such behaviour allows the user to quickly figure the proxy misconfiguration and correct it. Helped-by: Jeff King <p...@peff.net> Signed-off-by: Sergey Ryazanov <ryazanov@gmail.com> --- Changes since v2: - new p

[PATCH v3 2/2] http: fix the silent ignoring of proxy misconfiguraion

on parsing result. If parsing failed then print error message and die. Such behaviour allows user to quickly figure the proxy misconfiguration and correct it. Helped-by: Jeff King <p...@peff.net> Signed-off-by: Sergey Ryazanov <ryazanov@gmail.com> --- Changes since v2: - new patch

[PATCH v3 0/2] http: few fixes for the proxy configuration handling

Hello, this is few patches, which fixes regressions in the proxy handling. Changes since v2: - fix grammar (thanks to Ævar) - add new patch which fixes the silent ignoring of proxy missconfiguration Sergey Ryazanov (2): http: honor empty http.proxy option to bypass proxy http: fix

[PATCH v3 1/2] http: honor empty http.proxy option to bypass proxy

t work anymore. Fix this issue by explicitly handling http.proxy being set the empty string. This also makes the code a bit more clear and should help us avoid such regressions in the future. Helped-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> Helped-by: Jeff King <p...@peff.net>

Re: [PATCH v2] http: honnor empty http.proxy option to bypass proxy

On Tue, Apr 11, 2017 at 4:06 PM, Jeff King <p...@peff.net> wrote: > On Tue, Apr 11, 2017 at 12:20:50PM +0300, Sergey Ryazanov wrote: >> diff --git a/http.c b/http.c >> index 96d84bb..8be75b2 100644 >> --- a/http.c >> +++ b/http.c >> @@ -836,8 +836,

Re: [PATCH v2] http: honnor empty http.proxy option to bypass proxy

On Tue, Apr 11, 2017 at 1:09 PM, Ævar Arnfjörð Bjarmason wrote: > Since nobody pointed this out already, some grammar/spelling fixes. > Also CC-ing Knut who wrote the commit you're referencing. > Thanks a lot! Will fix in v3. -- Sergey

[PATCH v2] http: honnor empty http.proxy option to bypass proxy

also makes code a bit more clear and should help us avoid such regressions in the future. Signed-off-by: Sergey Ryazanov <ryazanov@gmail.com> --- Changes since v1: - explicitly handle this case instead of mangling the common code http.c | 10 -- 1 file changed, 8 insertions

Re: [PATCH] http: honnor empty http.proxy option to bypass proxy

On Mon, Apr 10, 2017 at 7:33 PM, Jeff King <p...@peff.net> wrote: > On Mon, Apr 10, 2017 at 06:15:56PM +0300, Sergey Ryazanov wrote: >> Curl distinguish between empty proxy address and NULL proxy address. In >> the first case it completly disable proxy usage, but if proxy addr

[PATCH] http: honnor empty http.proxy option to bypass proxy

t if proxy option is empty then proxy host field become NULL this force curl to fallback to proxy configuration detection from environment. This caused empty http.proxy option not working any more. Avoid setting NULL CURLOPT_PROXY from proxy_auth.host to fix this issue. Signed-off-by: Serge